Re: [PATCH 08/10] cpufreq: Fix broken usage of governor->owner's refcount

2013-08-03 Thread Rafael J. Wysocki
gt; >> only > >> when CPUFREQ_GOV_POLICY_INIT event has come and should decrement only if > >> CPUFREQ_GOV_POLICY_EXIT has come. > >> > >> Lets fix it. > > > > OK, and what happens if we don't fix it? > > What about this changelog: > > Subject: [PATCH

Re: [PATCH 08/10] cpufreq: Fix broken usage of governor->owner's refcount

2013-08-03 Thread Viresh Kumar
UFREQ_GOV_POLICY_EXIT has come. >> >> Lets fix it. > > OK, and what happens if we don't fix it? What about this changelog: Subject: [PATCH 08/10] cpufreq: Fix broken usage of governor->owner's refcount Governor's owner refcount usage was broken. We should increment refcount o

Re: [PATCH 08/10] cpufreq: Fix broken usage of governor->owner's refcount

2013-08-03 Thread Rafael J. Wysocki
On Saturday, August 03, 2013 05:19:26 PM Viresh Kumar wrote: > Governor's owner refcount usage was broken. We should increment refcount only > when CPUFREQ_GOV_POLICY_INIT event has come and should decrement only if > CPUFREQ_GOV_POLICY_EXIT has come. > > Lets fix it. OK, and what happens if we

[PATCH 08/10] cpufreq: Fix broken usage of governor->owner's refcount

2013-08-03 Thread Viresh Kumar
Governor's owner refcount usage was broken. We should increment refcount only when CPUFREQ_GOV_POLICY_INIT event has come and should decrement only if CPUFREQ_GOV_POLICY_EXIT has come. Lets fix it. Signed-off-by: Viresh Kumar --- drivers/cpufreq/cpufreq.c | 14 +++--- 1 file changed, 7

[PATCH 08/10] cpufreq: Fix broken usage of governor-owner's refcount

2013-08-03 Thread Viresh Kumar
Governor's owner refcount usage was broken. We should increment refcount only when CPUFREQ_GOV_POLICY_INIT event has come and should decrement only if CPUFREQ_GOV_POLICY_EXIT has come. Lets fix it. Signed-off-by: Viresh Kumar viresh.ku...@linaro.org --- drivers/cpufreq/cpufreq.c | 14

Re: [PATCH 08/10] cpufreq: Fix broken usage of governor-owner's refcount

2013-08-03 Thread Rafael J. Wysocki
On Saturday, August 03, 2013 05:19:26 PM Viresh Kumar wrote: Governor's owner refcount usage was broken. We should increment refcount only when CPUFREQ_GOV_POLICY_INIT event has come and should decrement only if CPUFREQ_GOV_POLICY_EXIT has come. Lets fix it. OK, and what happens if we don't

Re: [PATCH 08/10] cpufreq: Fix broken usage of governor-owner's refcount

2013-08-03 Thread Viresh Kumar
if CPUFREQ_GOV_POLICY_EXIT has come. Lets fix it. OK, and what happens if we don't fix it? What about this changelog: Subject: [PATCH 08/10] cpufreq: Fix broken usage of governor-owner's refcount Governor's owner refcount usage was broken. We should increment refcount only when CPUFREQ_GOV_POLICY_INIT event has

Re: [PATCH 08/10] cpufreq: Fix broken usage of governor-owner's refcount

2013-08-03 Thread Rafael J. Wysocki
CPUFREQ_GOV_POLICY_INIT event has come and should decrement only if CPUFREQ_GOV_POLICY_EXIT has come. Lets fix it. OK, and what happens if we don't fix it? What about this changelog: Subject: [PATCH 08/10] cpufreq: Fix broken usage of governor-owner's refcount Governor's owner refcount usage