Re: [PATCH 08/17] ARM: at91: unused variable in at91_pm_verify_clocks

2012-10-04 Thread Jean-Christophe PLAGNIOL-VILLARD
On 08:28 Thu 04 Oct , Arnd Bergmann wrote: > On Tuesday 02 October 2012, Jean-Christophe PLAGNIOL-VILLARD wrote: > > > unsigned long scsr; > > > +#ifdef CONFIG_AT91_PROGRAMMABLE_CLOCKS > > > int i; > > > +#endif > > please is if (IS_ENBLED()) > > > > #ifdef drop code coverage > > > >

Re: [PATCH 08/17] ARM: at91: unused variable in at91_pm_verify_clocks

2012-10-04 Thread Arnd Bergmann
On Tuesday 02 October 2012, Jean-Christophe PLAGNIOL-VILLARD wrote: > > unsigned long scsr; > > +#ifdef CONFIG_AT91_PROGRAMMABLE_CLOCKS > > int i; > > +#endif > please is if (IS_ENBLED()) > > #ifdef drop code coverage > Ok, agreed. Here is the new version: >From

Re: [PATCH 08/17] ARM: at91: unused variable in at91_pm_verify_clocks

2012-10-04 Thread Arnd Bergmann
On Tuesday 02 October 2012, Jean-Christophe PLAGNIOL-VILLARD wrote: unsigned long scsr; +#ifdef CONFIG_AT91_PROGRAMMABLE_CLOCKS int i; +#endif please is if (IS_ENBLED()) #ifdef drop code coverage Ok, agreed. Here is the new version: From

Re: [PATCH 08/17] ARM: at91: unused variable in at91_pm_verify_clocks

2012-10-04 Thread Jean-Christophe PLAGNIOL-VILLARD
On 08:28 Thu 04 Oct , Arnd Bergmann wrote: On Tuesday 02 October 2012, Jean-Christophe PLAGNIOL-VILLARD wrote: unsigned long scsr; +#ifdef CONFIG_AT91_PROGRAMMABLE_CLOCKS int i; +#endif please is if (IS_ENBLED()) #ifdef drop code coverage Ok, agreed. Here is the

Re: [PATCH 08/17] ARM: at91: unused variable in at91_pm_verify_clocks

2012-10-02 Thread Jean-Christophe PLAGNIOL-VILLARD
On 18:36 Tue 02 Oct , Arnd Bergmann wrote: > The code using the variable 'i' in this function is conditional, so > we have to make the declaration conditional as well to avoid a harmless > warning. > > Without this patch, building at91sam9263_defconfig results in: > >

[PATCH 08/17] ARM: at91: unused variable in at91_pm_verify_clocks

2012-10-02 Thread Arnd Bergmann
The code using the variable 'i' in this function is conditional, so we have to make the declaration conditional as well to avoid a harmless warning. Without this patch, building at91sam9263_defconfig results in: /home/arnd/linux-arm/arch/arm/mach-at91/pm.c: In function 'at91_pm_verify_clocks':

[PATCH 08/17] ARM: at91: unused variable in at91_pm_verify_clocks

2012-10-02 Thread Arnd Bergmann
The code using the variable 'i' in this function is conditional, so we have to make the declaration conditional as well to avoid a harmless warning. Without this patch, building at91sam9263_defconfig results in: /home/arnd/linux-arm/arch/arm/mach-at91/pm.c: In function 'at91_pm_verify_clocks':

Re: [PATCH 08/17] ARM: at91: unused variable in at91_pm_verify_clocks

2012-10-02 Thread Jean-Christophe PLAGNIOL-VILLARD
On 18:36 Tue 02 Oct , Arnd Bergmann wrote: The code using the variable 'i' in this function is conditional, so we have to make the declaration conditional as well to avoid a harmless warning. Without this patch, building at91sam9263_defconfig results in: