On Mon, Feb 11, 2013 at 02:53:47PM +0100, Linus Walleij wrote:
> NB: among the error codes people want to propagate from
> consumer interfaces such as say, clk_get(), regulator_get()
> and pinctrl_get() is -EPROBE_DEFER. So just "something
> failed" (return NULL) isn't enough.
>
> We then
On Sat, Feb 9, 2013 at 2:52 PM, Grant Likely wrote:
> On Mon, 21 Jan 2013 16:22:21 +0530, Viresh Kumar
> wrote:
>> > - spics->base = devm_request_and_ioremap(>dev, res);
>> > - if (!spics->base) {
>> > - dev_err(>dev, "request and ioremap fail\n");
>>
>> can we keep
On Sat, Feb 9, 2013 at 2:52 PM, Grant Likely grant.lik...@secretlab.ca wrote:
On Mon, 21 Jan 2013 16:22:21 +0530, Viresh Kumar viresh.ku...@linaro.org
wrote:
- spics-base = devm_request_and_ioremap(pdev-dev, res);
- if (!spics-base) {
- dev_err(pdev-dev, request
On Mon, Feb 11, 2013 at 02:53:47PM +0100, Linus Walleij wrote:
NB: among the error codes people want to propagate from
consumer interfaces such as say, clk_get(), regulator_get()
and pinctrl_get() is -EPROBE_DEFER. So just something
failed (return NULL) isn't enough.
We then obviously need
On Mon, 21 Jan 2013 16:22:21 +0530, Viresh Kumar
wrote:
> On Mon, Jan 21, 2013 at 3:39 PM, Thierry Reding
> wrote:
> > diff --git a/drivers/gpio/gpio-spear-spics.c
> > b/drivers/gpio/gpio-spear-spics.c
> > index 5f45fc4..7a4bf7c 100644
> > --- a/drivers/gpio/gpio-spear-spics.c
> > +++
On Mon, 21 Jan 2013 16:22:21 +0530, Viresh Kumar viresh.ku...@linaro.org
wrote:
On Mon, Jan 21, 2013 at 3:39 PM, Thierry Reding
thierry.red...@avionic-design.de wrote:
diff --git a/drivers/gpio/gpio-spear-spics.c
b/drivers/gpio/gpio-spear-spics.c
index 5f45fc4..7a4bf7c 100644
---
On Tue, Jan 22, 2013 at 11:25 AM, Thierry Reding
wrote:
> On Tue, Jan 22, 2013 at 11:15:11AM +0100, Linus Walleij wrote:
>> On Mon, Jan 21, 2013 at 11:09 AM, Thierry Reding
>> wrote:
>>
>> > Convert all uses of devm_request_and_ioremap() to the newly introduced
>> > devm_ioremap_resource() which
On Tue, Jan 22, 2013 at 11:25 AM, Thierry Reding
thierry.red...@avionic-design.de wrote:
On Tue, Jan 22, 2013 at 11:15:11AM +0100, Linus Walleij wrote:
On Mon, Jan 21, 2013 at 11:09 AM, Thierry Reding
thierry.red...@avionic-design.de wrote:
Convert all uses of devm_request_and_ioremap() to
On Tue, Jan 22, 2013 at 08:08:09AM -0800, Greg Kroah-Hartman wrote:
> On Tue, Jan 22, 2013 at 11:25:59AM +0100, Thierry Reding wrote:
> > On Tue, Jan 22, 2013 at 11:15:11AM +0100, Linus Walleij wrote:
> > > On Mon, Jan 21, 2013 at 11:09 AM, Thierry Reding
> > > wrote:
> > >
> > > > Convert all
On Tue, Jan 22, 2013 at 11:25:59AM +0100, Thierry Reding wrote:
> On Tue, Jan 22, 2013 at 11:15:11AM +0100, Linus Walleij wrote:
> > On Mon, Jan 21, 2013 at 11:09 AM, Thierry Reding
> > wrote:
> >
> > > Convert all uses of devm_request_and_ioremap() to the newly introduced
> > >
On Tue, Jan 22, 2013 at 12:39:03PM +0100, Gregory CLEMENT wrote:
> On 01/22/2013 11:15 AM, Linus Walleij wrote:
> > On Mon, Jan 21, 2013 at 11:09 AM, Thierry Reding
> > wrote:
> >
> >> Convert all uses of devm_request_and_ioremap() to the newly introduced
> >> devm_ioremap_resource() which
On 01/22/2013 11:15 AM, Linus Walleij wrote:
> On Mon, Jan 21, 2013 at 11:09 AM, Thierry Reding
> wrote:
>
>> Convert all uses of devm_request_and_ioremap() to the newly introduced
>> devm_ioremap_resource() which provides more consistent error handling.
>>
>> devm_ioremap_resource() provides
On Tue, Jan 22, 2013 at 11:15:11AM +0100, Linus Walleij wrote:
> On Mon, Jan 21, 2013 at 11:09 AM, Thierry Reding
> wrote:
>
> > Convert all uses of devm_request_and_ioremap() to the newly introduced
> > devm_ioremap_resource() which provides more consistent error handling.
> >
> >
On Mon, Jan 21, 2013 at 11:09 AM, Thierry Reding
wrote:
> Convert all uses of devm_request_and_ioremap() to the newly introduced
> devm_ioremap_resource() which provides more consistent error handling.
>
> devm_ioremap_resource() provides its own error messages so all explicit
> error messages
On Mon, Jan 21, 2013 at 11:09 AM, Thierry Reding
thierry.red...@avionic-design.de wrote:
Convert all uses of devm_request_and_ioremap() to the newly introduced
devm_ioremap_resource() which provides more consistent error handling.
devm_ioremap_resource() provides its own error messages so all
On Tue, Jan 22, 2013 at 11:15:11AM +0100, Linus Walleij wrote:
On Mon, Jan 21, 2013 at 11:09 AM, Thierry Reding
thierry.red...@avionic-design.de wrote:
Convert all uses of devm_request_and_ioremap() to the newly introduced
devm_ioremap_resource() which provides more consistent error
On 01/22/2013 11:15 AM, Linus Walleij wrote:
On Mon, Jan 21, 2013 at 11:09 AM, Thierry Reding
thierry.red...@avionic-design.de wrote:
Convert all uses of devm_request_and_ioremap() to the newly introduced
devm_ioremap_resource() which provides more consistent error handling.
On Tue, Jan 22, 2013 at 12:39:03PM +0100, Gregory CLEMENT wrote:
On 01/22/2013 11:15 AM, Linus Walleij wrote:
On Mon, Jan 21, 2013 at 11:09 AM, Thierry Reding
thierry.red...@avionic-design.de wrote:
Convert all uses of devm_request_and_ioremap() to the newly introduced
On Tue, Jan 22, 2013 at 11:25:59AM +0100, Thierry Reding wrote:
On Tue, Jan 22, 2013 at 11:15:11AM +0100, Linus Walleij wrote:
On Mon, Jan 21, 2013 at 11:09 AM, Thierry Reding
thierry.red...@avionic-design.de wrote:
Convert all uses of devm_request_and_ioremap() to the newly introduced
On Tue, Jan 22, 2013 at 08:08:09AM -0800, Greg Kroah-Hartman wrote:
On Tue, Jan 22, 2013 at 11:25:59AM +0100, Thierry Reding wrote:
On Tue, Jan 22, 2013 at 11:15:11AM +0100, Linus Walleij wrote:
On Mon, Jan 21, 2013 at 11:09 AM, Thierry Reding
thierry.red...@avionic-design.de wrote:
On Mon, Jan 21, 2013 at 3:39 PM, Thierry Reding
wrote:
> diff --git a/drivers/gpio/gpio-spear-spics.c b/drivers/gpio/gpio-spear-spics.c
> index 5f45fc4..7a4bf7c 100644
> --- a/drivers/gpio/gpio-spear-spics.c
> +++ b/drivers/gpio/gpio-spear-spics.c
> @@ -140,11 +140,9 @@ static int
Convert all uses of devm_request_and_ioremap() to the newly introduced
devm_ioremap_resource() which provides more consistent error handling.
devm_ioremap_resource() provides its own error messages so all explicit
error messages can be removed from the failure code paths.
Signed-off-by: Thierry
Convert all uses of devm_request_and_ioremap() to the newly introduced
devm_ioremap_resource() which provides more consistent error handling.
devm_ioremap_resource() provides its own error messages so all explicit
error messages can be removed from the failure code paths.
Signed-off-by: Thierry
On Mon, Jan 21, 2013 at 3:39 PM, Thierry Reding
thierry.red...@avionic-design.de wrote:
diff --git a/drivers/gpio/gpio-spear-spics.c b/drivers/gpio/gpio-spear-spics.c
index 5f45fc4..7a4bf7c 100644
--- a/drivers/gpio/gpio-spear-spics.c
+++ b/drivers/gpio/gpio-spear-spics.c
@@ -140,11 +140,9 @@
24 matches
Mail list logo
