Re: [PATCH 09/12] thp: introduce khugepaged_prealloc_page and khugepaged_alloc_page

2012-09-13 Thread Xiao Guangrong
On 09/13/2012 02:27 PM, Hugh Dickins wrote: > On Wed, 12 Sep 2012, Xiao Guangrong wrote: >> On 09/12/2012 10:03 AM, Hugh Dickins wrote: >> >>> What brought me to look at it was hitting "BUG at mm/huge_memory.c:1842!" >>> running tmpfs kbuild swapping load (with memcg's memory.limit_in_bytes >>>

Re: [PATCH 09/12] thp: introduce khugepaged_prealloc_page and khugepaged_alloc_page

2012-09-13 Thread Hugh Dickins
On Wed, 12 Sep 2012, Hugh Dickins wrote: > > @@ -1825,6 +1825,7 @@ static bool khugepaged_prealloc_page(struct page > > **hpage, bool *wait) > > return false; > > > > *wait = false; > > + *hpage = NULL; > > khugepaged_alloc_sleep(); > > }

Re: [PATCH 09/12] thp: introduce khugepaged_prealloc_page and khugepaged_alloc_page

2012-09-13 Thread Hugh Dickins
On Wed, 12 Sep 2012, Xiao Guangrong wrote: > On 09/12/2012 10:03 AM, Hugh Dickins wrote: > > > What brought me to look at it was hitting "BUG at mm/huge_memory.c:1842!" > > running tmpfs kbuild swapping load (with memcg's memory.limit_in_bytes > > forcing out to swap), while I happened to have

Re: [PATCH 09/12] thp: introduce khugepaged_prealloc_page and khugepaged_alloc_page

2012-09-13 Thread Hugh Dickins
On Wed, 12 Sep 2012, Xiao Guangrong wrote: On 09/12/2012 10:03 AM, Hugh Dickins wrote: What brought me to look at it was hitting BUG at mm/huge_memory.c:1842! running tmpfs kbuild swapping load (with memcg's memory.limit_in_bytes forcing out to swap), while I happened to have

Re: [PATCH 09/12] thp: introduce khugepaged_prealloc_page and khugepaged_alloc_page

2012-09-13 Thread Hugh Dickins
On Wed, 12 Sep 2012, Hugh Dickins wrote: @@ -1825,6 +1825,7 @@ static bool khugepaged_prealloc_page(struct page **hpage, bool *wait) return false; *wait = false; + *hpage = NULL; khugepaged_alloc_sleep(); } else if

Re: [PATCH 09/12] thp: introduce khugepaged_prealloc_page and khugepaged_alloc_page

2012-09-13 Thread Xiao Guangrong
On 09/13/2012 02:27 PM, Hugh Dickins wrote: On Wed, 12 Sep 2012, Xiao Guangrong wrote: On 09/12/2012 10:03 AM, Hugh Dickins wrote: What brought me to look at it was hitting BUG at mm/huge_memory.c:1842! running tmpfs kbuild swapping load (with memcg's memory.limit_in_bytes forcing out to

Re: [PATCH 09/12] thp: introduce khugepaged_prealloc_page and khugepaged_alloc_page

2012-09-11 Thread Xiao Guangrong
On 09/12/2012 10:03 AM, Hugh Dickins wrote: > What brought me to look at it was hitting "BUG at mm/huge_memory.c:1842!" > running tmpfs kbuild swapping load (with memcg's memory.limit_in_bytes > forcing out to swap), while I happened to have CONFIG_NUMA=y. > > That's the VM_BUG_ON(*hpage) on

Re: [PATCH 09/12] thp: introduce khugepaged_prealloc_page and khugepaged_alloc_page

2012-09-11 Thread Xiao Guangrong
On 09/12/2012 10:03 AM, Hugh Dickins wrote: > On Mon, 13 Aug 2012, Xiao Guangrong wrote: > >> They are used to abstract the difference between NUMA enabled and NUMA >> disabled >> to make the code more readable >> >> Signed-off-by: Xiao Guangrong >> --- >> mm/huge_memory.c | 166 >>

Re: [PATCH 09/12] thp: introduce khugepaged_prealloc_page and khugepaged_alloc_page

2012-09-11 Thread Hugh Dickins
On Mon, 13 Aug 2012, Xiao Guangrong wrote: > They are used to abstract the difference between NUMA enabled and NUMA > disabled > to make the code more readable > > Signed-off-by: Xiao Guangrong > --- > mm/huge_memory.c | 166 > -- > 1

Re: [PATCH 09/12] thp: introduce khugepaged_prealloc_page and khugepaged_alloc_page

2012-09-11 Thread Hugh Dickins
On Mon, 13 Aug 2012, Xiao Guangrong wrote: They are used to abstract the difference between NUMA enabled and NUMA disabled to make the code more readable Signed-off-by: Xiao Guangrong xiaoguangr...@linux.vnet.ibm.com --- mm/huge_memory.c | 166

Re: [PATCH 09/12] thp: introduce khugepaged_prealloc_page and khugepaged_alloc_page

2012-09-11 Thread Xiao Guangrong
On 09/12/2012 10:03 AM, Hugh Dickins wrote: On Mon, 13 Aug 2012, Xiao Guangrong wrote: They are used to abstract the difference between NUMA enabled and NUMA disabled to make the code more readable Signed-off-by: Xiao Guangrong xiaoguangr...@linux.vnet.ibm.com --- mm/huge_memory.c |

Re: [PATCH 09/12] thp: introduce khugepaged_prealloc_page and khugepaged_alloc_page

2012-09-11 Thread Xiao Guangrong
On 09/12/2012 10:03 AM, Hugh Dickins wrote: What brought me to look at it was hitting BUG at mm/huge_memory.c:1842! running tmpfs kbuild swapping load (with memcg's memory.limit_in_bytes forcing out to swap), while I happened to have CONFIG_NUMA=y. That's the VM_BUG_ON(*hpage) on entry to

[PATCH 09/12] thp: introduce khugepaged_prealloc_page and khugepaged_alloc_page

2012-08-13 Thread Xiao Guangrong
They are used to abstract the difference between NUMA enabled and NUMA disabled to make the code more readable Signed-off-by: Xiao Guangrong --- mm/huge_memory.c | 166 -- 1 files changed, 98 insertions(+), 68 deletions(-) diff --git

[PATCH 09/12] thp: introduce khugepaged_prealloc_page and khugepaged_alloc_page

2012-08-13 Thread Xiao Guangrong
They are used to abstract the difference between NUMA enabled and NUMA disabled to make the code more readable Signed-off-by: Xiao Guangrong xiaoguangr...@linux.vnet.ibm.com --- mm/huge_memory.c | 166 -- 1 files changed, 98 insertions(+), 68