Re: [PATCH 09/14] fs/pstore: Use %pS printk format for direct addresses
On Thu, Nov 29, 2018 at 3:49 PM Luck, Tony wrote:
>
> On Thu, Nov 29, 2018 at 03:26:51PM -0800, Kees Cook wrote:
> > On Wed, Sep 6, 2017 at 1:28 PM Helge Deller wrote:
> > >
> > > Use the %pS instead of the %pF printk format specifier for printing
> > > symbols
> > > from direct addresses. This is needed for the ia64, ppc64 and parisc64
> > > architectures.
> > >
> > > Signed-off-by: Helge Deller
> > > Cc: Kees Cook
> > > Cc: Tony Luck
> >
> > I missed this email from some time ago. I've now applied it, thanks!
>
> Though it isn't really needed any more. See
>
> 04b8eb7a4ccd ("symbol lookup: introduce dereference_symbol_descriptor()")
>
> which is part of the plan to deprecate %pF
Ah-ha! Okay then, nevermind. :) Thanks!
--
Kees Cook
Re: [PATCH 09/14] fs/pstore: Use %pS printk format for direct addresses
On Thu, Nov 29, 2018 at 03:26:51PM -0800, Kees Cook wrote:
> On Wed, Sep 6, 2017 at 1:28 PM Helge Deller wrote:
> >
> > Use the %pS instead of the %pF printk format specifier for printing symbols
> > from direct addresses. This is needed for the ia64, ppc64 and parisc64
> > architectures.
> >
> > Signed-off-by: Helge Deller
> > Cc: Kees Cook
> > Cc: Tony Luck
>
> I missed this email from some time ago. I've now applied it, thanks!
Though it isn't really needed any more. See
04b8eb7a4ccd ("symbol lookup: introduce dereference_symbol_descriptor()")
which is part of the plan to deprecate %pF
-Tony
Re: [PATCH 09/14] fs/pstore: Use %pS printk format for direct addresses
On Wed, Sep 6, 2017 at 1:28 PM Helge Deller wrote: > > Use the %pS instead of the %pF printk format specifier for printing symbols > from direct addresses. This is needed for the ia64, ppc64 and parisc64 > architectures. > > Signed-off-by: Helge Deller > Cc: Kees Cook > Cc: Tony Luck I missed this email from some time ago. I've now applied it, thanks! -Kees > --- > fs/pstore/inode.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/pstore/inode.c b/fs/pstore/inode.c > index fefd226..59f65d7 100644 > --- a/fs/pstore/inode.c > +++ b/fs/pstore/inode.c > @@ -116,7 +116,7 @@ static int pstore_ftrace_seq_show(struct seq_file *s, > void *v) > > rec = (struct pstore_ftrace_record *)(ps->record->buf + data->off); > > - seq_printf(s, "CPU:%d ts:%llu %08lx %08lx %pf <- %pF\n", > + seq_printf(s, "CPU:%d ts:%llu %08lx %08lx %ps <- %pS\n", >pstore_ftrace_decode_cpu(rec), >pstore_ftrace_read_timestamp(rec), >rec->ip, rec->parent_ip, (void *)rec->ip, > -- > 2.1.0 > -- Kees Cook
[PATCH 09/14] fs/pstore: Use %pS printk format for direct addresses
Use the %pS instead of the %pF printk format specifier for printing symbols from direct addresses. This is needed for the ia64, ppc64 and parisc64 architectures. Signed-off-by: Helge Deller Cc: Kees Cook Cc: Tony Luck --- fs/pstore/inode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/pstore/inode.c b/fs/pstore/inode.c index fefd226..59f65d7 100644 --- a/fs/pstore/inode.c +++ b/fs/pstore/inode.c @@ -116,7 +116,7 @@ static int pstore_ftrace_seq_show(struct seq_file *s, void *v) rec = (struct pstore_ftrace_record *)(ps->record->buf + data->off); - seq_printf(s, "CPU:%d ts:%llu %08lx %08lx %pf <- %pF\n", + seq_printf(s, "CPU:%d ts:%llu %08lx %08lx %ps <- %pS\n", pstore_ftrace_decode_cpu(rec), pstore_ftrace_read_timestamp(rec), rec->ip, rec->parent_ip, (void *)rec->ip, -- 2.1.0
