Re: [PATCH 09/16] iommu/amd: Add IOAPIC remapping routines

2012-10-01 Thread Konrad Rzeszutek Wilk
>> I was thinking the other way around. You recover the old affinity. Should >> you print out a warning mentioning to the system admin that you could not >> set the new affinity but reverted to the old one? Or will that not serve >> anything except spam the kernel logs? > > Well, I don't think it

Re: [PATCH 09/16] iommu/amd: Add IOAPIC remapping routines

2012-10-01 Thread Joerg Roedel
On Mon, Oct 01, 2012 at 09:47:53AM -0400, Konrad Rzeszutek Wilk wrote: > On Mon, Oct 01, 2012 at 10:40:51AM +0200, Joerg Roedel wrote: > > Don't understand this. What is not set? > > the IRQ_DELAYED_DISABLE. But I could not even find that enum anymore? > Has that been obsoleted? You are right,

Re: [PATCH 09/16] iommu/amd: Add IOAPIC remapping routines

2012-10-01 Thread Konrad Rzeszutek Wilk
On Mon, Oct 01, 2012 at 10:40:51AM +0200, Joerg Roedel wrote: > On Fri, Sep 28, 2012 at 10:45:15AM -0400, Konrad Rzeszutek Wilk wrote: > > On Fri, Sep 28, 2012 at 02:23:59PM +0200, Joerg Roedel wrote: > > > + /* > > > + * Mask level triggered irqs. > > > + * Use IRQ_DELAYED_DISABLE for edge

Re: [PATCH 09/16] iommu/amd: Add IOAPIC remapping routines

2012-10-01 Thread Joerg Roedel
On Fri, Sep 28, 2012 at 10:45:15AM -0400, Konrad Rzeszutek Wilk wrote: > On Fri, Sep 28, 2012 at 02:23:59PM +0200, Joerg Roedel wrote: > > + /* > > +* Mask level triggered irqs. > > +* Use IRQ_DELAYED_DISABLE for edge triggered irqs. > > so how come it is not set? Don't understand

Re: [PATCH 09/16] iommu/amd: Add IOAPIC remapping routines

2012-10-01 Thread Joerg Roedel
On Fri, Sep 28, 2012 at 10:45:15AM -0400, Konrad Rzeszutek Wilk wrote: On Fri, Sep 28, 2012 at 02:23:59PM +0200, Joerg Roedel wrote: + /* +* Mask level triggered irqs. +* Use IRQ_DELAYED_DISABLE for edge triggered irqs. so how come it is not set? Don't understand this. What is

Re: [PATCH 09/16] iommu/amd: Add IOAPIC remapping routines

2012-10-01 Thread Konrad Rzeszutek Wilk
On Mon, Oct 01, 2012 at 10:40:51AM +0200, Joerg Roedel wrote: On Fri, Sep 28, 2012 at 10:45:15AM -0400, Konrad Rzeszutek Wilk wrote: On Fri, Sep 28, 2012 at 02:23:59PM +0200, Joerg Roedel wrote: + /* + * Mask level triggered irqs. + * Use IRQ_DELAYED_DISABLE for edge triggered irqs.

Re: [PATCH 09/16] iommu/amd: Add IOAPIC remapping routines

2012-10-01 Thread Joerg Roedel
On Mon, Oct 01, 2012 at 09:47:53AM -0400, Konrad Rzeszutek Wilk wrote: On Mon, Oct 01, 2012 at 10:40:51AM +0200, Joerg Roedel wrote: Don't understand this. What is not set? the IRQ_DELAYED_DISABLE. But I could not even find that enum anymore? Has that been obsoleted? You are right, its

Re: [PATCH 09/16] iommu/amd: Add IOAPIC remapping routines

2012-10-01 Thread Konrad Rzeszutek Wilk
I was thinking the other way around. You recover the old affinity. Should you print out a warning mentioning to the system admin that you could not set the new affinity but reverted to the old one? Or will that not serve anything except spam the kernel logs? Well, I don't think it makes

Re: [PATCH 09/16] iommu/amd: Add IOAPIC remapping routines

2012-09-28 Thread Konrad Rzeszutek Wilk
On Fri, Sep 28, 2012 at 02:23:59PM +0200, Joerg Roedel wrote: > Add the routine to setup interrupt remapping for ioapic > interrupts. Also add a routine to change the affinity of an > irq and to free an irq allocation for interrupt remapping. > The last two functions will also be used for MSI

[PATCH 09/16] iommu/amd: Add IOAPIC remapping routines

2012-09-28 Thread Joerg Roedel
Add the routine to setup interrupt remapping for ioapic interrupts. Also add a routine to change the affinity of an irq and to free an irq allocation for interrupt remapping. The last two functions will also be used for MSI interrupts. Signed-off-by: Joerg Roedel --- drivers/iommu/amd_iommu.c |

[PATCH 09/16] iommu/amd: Add IOAPIC remapping routines

2012-09-28 Thread Joerg Roedel
Add the routine to setup interrupt remapping for ioapic interrupts. Also add a routine to change the affinity of an irq and to free an irq allocation for interrupt remapping. The last two functions will also be used for MSI interrupts. Signed-off-by: Joerg Roedel joerg.roe...@amd.com ---

Re: [PATCH 09/16] iommu/amd: Add IOAPIC remapping routines

2012-09-28 Thread Konrad Rzeszutek Wilk
On Fri, Sep 28, 2012 at 02:23:59PM +0200, Joerg Roedel wrote: Add the routine to setup interrupt remapping for ioapic interrupts. Also add a routine to change the affinity of an irq and to free an irq allocation for interrupt remapping. The last two functions will also be used for MSI