Re: [PATCH 09/26 v5] tracing/probes: Do not use return value of trace_seq_printf()
On Fri 2014-11-14 23:58:56, Steven Rostedt wrote: > From: "Steven Rostedt (Red Hat)" > > The functions trace_seq_printf() and friends will soon not have a return > value and will only be a void function. Use trace_seq_has_overflowed() > instead to know if the trace_seq operations succeeded or not. > > Link: http://lkml.kernel.org/r/20141114011411.530216...@goodmis.org > > Cc: Namhyung Kim > Acked-by: Masami Hiramatsu > Signed-off-by: Steven Rostedt Reviewed-by: Petr Mladek Best Regards, Petr -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 09/26 v5] tracing/probes: Do not use return value of trace_seq_printf()
On Fri 2014-11-14 23:58:56, Steven Rostedt wrote: From: Steven Rostedt (Red Hat) rost...@goodmis.org The functions trace_seq_printf() and friends will soon not have a return value and will only be a void function. Use trace_seq_has_overflowed() instead to know if the trace_seq operations succeeded or not. Link: http://lkml.kernel.org/r/20141114011411.530216...@goodmis.org Cc: Namhyung Kim namhy...@kernel.org Acked-by: Masami Hiramatsu masami.hiramatsu...@hitachi.com Signed-off-by: Steven Rostedt rost...@goodmis.org Reviewed-by: Petr Mladek pmla...@suse.cz Best Regards, Petr -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 09/26 v5] tracing/probes: Do not use return value of trace_seq_printf()
From: "Steven Rostedt (Red Hat)"
The functions trace_seq_printf() and friends will soon not have a return
value and will only be a void function. Use trace_seq_has_overflowed()
instead to know if the trace_seq operations succeeded or not.
Link: http://lkml.kernel.org/r/20141114011411.530216...@goodmis.org
Cc: Namhyung Kim
Acked-by: Masami Hiramatsu
Signed-off-by: Steven Rostedt
---
kernel/trace/trace_probe.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/kernel/trace/trace_probe.c b/kernel/trace/trace_probe.c
index d4b9fc22cd27..b983b2fd2ca1 100644
--- a/kernel/trace/trace_probe.c
+++ b/kernel/trace/trace_probe.c
@@ -40,7 +40,8 @@ const char *reserved_field_names[] = {
int PRINT_TYPE_FUNC_NAME(type)(struct trace_seq *s, const char *name, \
void *data, void *ent) \
{ \
- return trace_seq_printf(s, " %s=" fmt, name, *(type *)data);\
+ trace_seq_printf(s, " %s=" fmt, name, *(type *)data); \
+ return !trace_seq_has_overflowed(s);\
} \
const char PRINT_TYPE_FMT_NAME(type)[] = fmt; \
NOKPROBE_SYMBOL(PRINT_TYPE_FUNC_NAME(type));
@@ -61,10 +62,11 @@ int PRINT_TYPE_FUNC_NAME(string)(struct trace_seq *s, const
char *name,
int len = *(u32 *)data >> 16;
if (!len)
- return trace_seq_printf(s, " %s=(fault)", name);
+ trace_seq_printf(s, " %s=(fault)", name);
else
- return trace_seq_printf(s, " %s=\"%s\"", name,
- (const char *)get_loc_data(data, ent));
+ trace_seq_printf(s, " %s=\"%s\"", name,
+(const char *)get_loc_data(data, ent));
+ return !trace_seq_has_overflowed(s);
}
NOKPROBE_SYMBOL(PRINT_TYPE_FUNC_NAME(string));
--
2.1.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 09/26 v5] tracing/probes: Do not use return value of trace_seq_printf()
From: Steven Rostedt (Red Hat) rost...@goodmis.org
The functions trace_seq_printf() and friends will soon not have a return
value and will only be a void function. Use trace_seq_has_overflowed()
instead to know if the trace_seq operations succeeded or not.
Link: http://lkml.kernel.org/r/20141114011411.530216...@goodmis.org
Cc: Namhyung Kim namhy...@kernel.org
Acked-by: Masami Hiramatsu masami.hiramatsu...@hitachi.com
Signed-off-by: Steven Rostedt rost...@goodmis.org
---
kernel/trace/trace_probe.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/kernel/trace/trace_probe.c b/kernel/trace/trace_probe.c
index d4b9fc22cd27..b983b2fd2ca1 100644
--- a/kernel/trace/trace_probe.c
+++ b/kernel/trace/trace_probe.c
@@ -40,7 +40,8 @@ const char *reserved_field_names[] = {
int PRINT_TYPE_FUNC_NAME(type)(struct trace_seq *s, const char *name, \
void *data, void *ent) \
{ \
- return trace_seq_printf(s, %s= fmt, name, *(type *)data);\
+ trace_seq_printf(s, %s= fmt, name, *(type *)data); \
+ return !trace_seq_has_overflowed(s);\
} \
const char PRINT_TYPE_FMT_NAME(type)[] = fmt; \
NOKPROBE_SYMBOL(PRINT_TYPE_FUNC_NAME(type));
@@ -61,10 +62,11 @@ int PRINT_TYPE_FUNC_NAME(string)(struct trace_seq *s, const
char *name,
int len = *(u32 *)data 16;
if (!len)
- return trace_seq_printf(s, %s=(fault), name);
+ trace_seq_printf(s, %s=(fault), name);
else
- return trace_seq_printf(s, %s=\%s\, name,
- (const char *)get_loc_data(data, ent));
+ trace_seq_printf(s, %s=\%s\, name,
+(const char *)get_loc_data(data, ent));
+ return !trace_seq_has_overflowed(s);
}
NOKPROBE_SYMBOL(PRINT_TYPE_FUNC_NAME(string));
--
2.1.1
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
