Re: [PATCH 09/83] hsa/radeon: Add code base of hsa driver for AMD's GPUs

2014-07-17 Thread Oded Gabbay
On 11/07/14 20:28, Joe Perches wrote: On Fri, 2014-07-11 at 13:04 -0400, Jerome Glisse wrote: On Fri, Jul 11, 2014 at 12:50:09AM +0300, Oded Gabbay wrote: [] +static long kfd_ioctl(struct file *, unsigned int, unsigned long); Nitpick, avoid unsigned int just use unsigned. I suggest

Re: [PATCH 09/83] hsa/radeon: Add code base of hsa driver for AMD's GPUs

2014-07-17 Thread Oded Gabbay
; Lewycky, Andrew; Joerg Roedel; Gabbay, Oded; Greg Kroah-Hartman; Rafael J. Wysocki; Kishon Vijay Abraham I; Sandeep Nair; Kenneth Heitke; Srinivas Pandruvada; Santosh Shilimkar; Andreas Noever; Lucas Stach; Philipp Zabel Subject: Re: [PATCH 09/83] hsa/radeon: Add code base of hsa driver for AMD's

Re: [PATCH 09/83] hsa/radeon: Add code base of hsa driver for AMD's GPUs

2014-07-17 Thread Oded Gabbay
; Lewycky, Andrew; Joerg Roedel; Gabbay, Oded; Greg Kroah-Hartman; Rafael J. Wysocki; Kishon Vijay Abraham I; Sandeep Nair; Kenneth Heitke; Srinivas Pandruvada; Santosh Shilimkar; Andreas Noever; Lucas Stach; Philipp Zabel Subject: Re: [PATCH 09/83] hsa/radeon: Add code base of hsa driver for AMD's

Re: [PATCH 09/83] hsa/radeon: Add code base of hsa driver for AMD's GPUs

2014-07-17 Thread Oded Gabbay
On 11/07/14 20:28, Joe Perches wrote: On Fri, 2014-07-11 at 13:04 -0400, Jerome Glisse wrote: On Fri, Jul 11, 2014 at 12:50:09AM +0300, Oded Gabbay wrote: [] +static long kfd_ioctl(struct file *, unsigned int, unsigned long); Nitpick, avoid unsigned int just use unsigned. I suggest

Re: [PATCH 09/83] hsa/radeon: Add code base of hsa driver for AMD's GPUs

2014-07-11 Thread Joe Perches
On Fri, 2014-07-11 at 15:22 -0400, Jerome Glisse wrote: > Just to be explicit, my point is that is you claim GPL in MODULE_LICENSE > then this is a GPL licensed code, if you claim GPL with additional rights > than this is dual licensed code. This is how i read and interpret this > with additional

Re: [PATCH 09/83] hsa/radeon: Add code base of hsa driver for AMD's GPUs

2014-07-11 Thread Jerome Glisse
ay Abraham I; Sandeep Nair; Kenneth Heitke; > >> >Srinivas Pandruvada; Santosh Shilimkar; Andreas Noever; Lucas Stach; > >> >Philipp Zabel > >> >Subject: Re: [PATCH 09/83] hsa/radeon: Add code base of hsa driver > >> >for AMD's GPUs > >> >

RE: [PATCH 09/83] hsa/radeon: Add code base of hsa driver for AMD's GPUs

2014-07-11 Thread Bridgman, John
Roedel; Gabbay, Oded; Greg Kroah-Hartman; Rafael J. Wysocki; Kishon >Vijay Abraham I; Sandeep Nair; Kenneth Heitke; Srinivas Pandruvada; >Santosh Shilimkar; Andreas Noever; Lucas Stach; Philipp Zabel >Subject: Re: [PATCH 09/83] hsa/radeon: Add code base of hsa driver for >AMD's GPUs >

RE: [PATCH 09/83] hsa/radeon: Add code base of hsa driver for AMD's GPUs

2014-07-11 Thread Bridgman, John
Roedel; Gabbay, Oded; Greg Kroah-Hartman; Rafael J. Wysocki; Kishon >Vijay Abraham I; Sandeep Nair; Kenneth Heitke; Srinivas Pandruvada; >Santosh Shilimkar; Andreas Noever; Lucas Stach; Philipp Zabel >Subject: Re: [PATCH 09/83] hsa/radeon: Add code base of hsa driver for >AMD's GPUs >

Re: [PATCH 09/83] hsa/radeon: Add code base of hsa driver for AMD's GPUs

2014-07-11 Thread Jerome Glisse
ay Abraham I; Sandeep Nair; Kenneth Heitke; Srinivas > >> >Pandruvada; Santosh Shilimkar; Andreas Noever; Lucas Stach; Philipp > >> >Zabel > >> >Subject: Re: [PATCH 09/83] hsa/radeon: Add code base of hsa driver > >> >for AMD's GPUs > >> > &g

Re: [PATCH 09/83] hsa/radeon: Add code base of hsa driver for AMD's GPUs

2014-07-11 Thread Jerome Glisse
reedesktop.org; Bridgman, John; Lewycky, Andrew; Joerg > >Roedel; Gabbay, Oded; Greg Kroah-Hartman; Rafael J. Wysocki; Kishon Vijay > >Abraham I; Sandeep Nair; Kenneth Heitke; Srinivas Pandruvada; Santosh > >Shilimkar; Andreas Noever; Lucas Stach; Philipp Zabel > >Subject: Re:

RE: [PATCH 09/83] hsa/radeon: Add code base of hsa driver for AMD's GPUs

2014-07-11 Thread Bridgman, John
;Roedel; Gabbay, Oded; Greg Kroah-Hartman; Rafael J. Wysocki; Kishon Vijay >Abraham I; Sandeep Nair; Kenneth Heitke; Srinivas Pandruvada; Santosh >Shilimkar; Andreas Noever; Lucas Stach; Philipp Zabel >Subject: Re: [PATCH 09/83] hsa/radeon: Add code base of hsa driver for >AMD's GPUs >

Re: [PATCH 09/83] hsa/radeon: Add code base of hsa driver for AMD's GPUs

2014-07-11 Thread Daniel Vetter
On Fri, Jul 11, 2014 at 7:04 PM, Jerome Glisse wrote: > Are we to assume that for eternity this will not work on iommu that do support > PASID/ATS but are not from AMD ? If it was an APU specific function i would > understand but it seems that the IOMMU API needs to grow. I am pretty sure > Intel

Re: [PATCH 09/83] hsa/radeon: Add code base of hsa driver for AMD's GPUs

2014-07-11 Thread Joe Perches
On Fri, 2014-07-11 at 13:04 -0400, Jerome Glisse wrote: > On Fri, Jul 11, 2014 at 12:50:09AM +0300, Oded Gabbay wrote: [] > > +static long kfd_ioctl(struct file *, unsigned int, unsigned long); > > Nitpick, avoid unsigned int just use unsigned. I suggest unsigned int is much more common (and

Re: [PATCH 09/83] hsa/radeon: Add code base of hsa driver for AMD's GPUs

2014-07-11 Thread Joe Perches
On Fri, 2014-07-11 at 13:04 -0400, Jerome Glisse wrote: On Fri, Jul 11, 2014 at 12:50:09AM +0300, Oded Gabbay wrote: [] +static long kfd_ioctl(struct file *, unsigned int, unsigned long); Nitpick, avoid unsigned int just use unsigned. I suggest unsigned int is much more common (and better)

Re: [PATCH 09/83] hsa/radeon: Add code base of hsa driver for AMD's GPUs

2014-07-11 Thread Daniel Vetter
On Fri, Jul 11, 2014 at 7:04 PM, Jerome Glisse j.gli...@gmail.com wrote: Are we to assume that for eternity this will not work on iommu that do support PASID/ATS but are not from AMD ? If it was an APU specific function i would understand but it seems that the IOMMU API needs to grow. I am

RE: [PATCH 09/83] hsa/radeon: Add code base of hsa driver for AMD's GPUs

2014-07-11 Thread Bridgman, John
Kroah-Hartman; Rafael J. Wysocki; Kishon Vijay Abraham I; Sandeep Nair; Kenneth Heitke; Srinivas Pandruvada; Santosh Shilimkar; Andreas Noever; Lucas Stach; Philipp Zabel Subject: Re: [PATCH 09/83] hsa/radeon: Add code base of hsa driver for AMD's GPUs On Fri, Jul 11, 2014 at 12:50:09AM +0300, Oded

Re: [PATCH 09/83] hsa/radeon: Add code base of hsa driver for AMD's GPUs

2014-07-11 Thread Jerome Glisse
, Andrew; Joerg Roedel; Gabbay, Oded; Greg Kroah-Hartman; Rafael J. Wysocki; Kishon Vijay Abraham I; Sandeep Nair; Kenneth Heitke; Srinivas Pandruvada; Santosh Shilimkar; Andreas Noever; Lucas Stach; Philipp Zabel Subject: Re: [PATCH 09/83] hsa/radeon: Add code base of hsa driver for AMD's GPUs

Re: [PATCH 09/83] hsa/radeon: Add code base of hsa driver for AMD's GPUs

2014-07-11 Thread Jerome Glisse
, Andrew; Joerg Roedel; Gabbay, Oded; Greg Kroah-Hartman; Rafael J. Wysocki; Kishon Vijay Abraham I; Sandeep Nair; Kenneth Heitke; Srinivas Pandruvada; Santosh Shilimkar; Andreas Noever; Lucas Stach; Philipp Zabel Subject: Re: [PATCH 09/83] hsa/radeon: Add code base of hsa driver for AMD's GPUs

RE: [PATCH 09/83] hsa/radeon: Add code base of hsa driver for AMD's GPUs

2014-07-11 Thread Bridgman, John
Kroah-Hartman; Rafael J. Wysocki; Kishon Vijay Abraham I; Sandeep Nair; Kenneth Heitke; Srinivas Pandruvada; Santosh Shilimkar; Andreas Noever; Lucas Stach; Philipp Zabel Subject: Re: [PATCH 09/83] hsa/radeon: Add code base of hsa driver for AMD's GPUs On Fri, Jul 11, 2014 at 06:02:39PM +

RE: [PATCH 09/83] hsa/radeon: Add code base of hsa driver for AMD's GPUs

2014-07-11 Thread Bridgman, John
Kroah-Hartman; Rafael J. Wysocki; Kishon Vijay Abraham I; Sandeep Nair; Kenneth Heitke; Srinivas Pandruvada; Santosh Shilimkar; Andreas Noever; Lucas Stach; Philipp Zabel Subject: Re: [PATCH 09/83] hsa/radeon: Add code base of hsa driver for AMD's GPUs On Fri, Jul 11, 2014 at 06:46:30PM +

Re: [PATCH 09/83] hsa/radeon: Add code base of hsa driver for AMD's GPUs

2014-07-11 Thread Jerome Glisse
, Andrew; Joerg Roedel; Gabbay, Oded; Greg Kroah-Hartman; Rafael J. Wysocki; Kishon Vijay Abraham I; Sandeep Nair; Kenneth Heitke; Srinivas Pandruvada; Santosh Shilimkar; Andreas Noever; Lucas Stach; Philipp Zabel Subject: Re: [PATCH 09/83] hsa/radeon: Add code base of hsa driver for AMD's GPUs

Re: [PATCH 09/83] hsa/radeon: Add code base of hsa driver for AMD's GPUs

2014-07-11 Thread Joe Perches
On Fri, 2014-07-11 at 15:22 -0400, Jerome Glisse wrote: Just to be explicit, my point is that is you claim GPL in MODULE_LICENSE then this is a GPL licensed code, if you claim GPL with additional rights than this is dual licensed code. This is how i read and interpret this with additional