Re: [PATCH 1/1] Documentation: security: core.rst: add missing argument

2020-05-26 Thread David Howells
Jonathan Corbet  wrote:

> Applied, thanks.

Ah - I've applied it to my keys-next branch.

David



Re: [PATCH 1/1] Documentation: security: core.rst: add missing argument

2020-05-25 Thread Jonathan Corbet
On Mon, 25 May 2020 10:33:10 -0600
Jonathan Corbet  wrote:

> On Fri, 15 May 2020 20:39:17 -0400
> Ben Boeckel  wrote:
> 
> > From: Ben Boeckel 
> > 
> > This argument was just never documented in the first place.
> > 
> > Signed-off-by: Ben Boeckel 
> > ---
> >  Documentation/security/keys/core.rst | 8 ++--
> >  1 file changed, 6 insertions(+), 2 deletions(-)  
> 
> Applied, thanks.

...or not...looks like David got there first.  Sorry for the noise.

jon


Re: [PATCH 1/1] Documentation: security: core.rst: add missing argument

2020-05-25 Thread Jonathan Corbet
On Fri, 15 May 2020 20:39:17 -0400
Ben Boeckel  wrote:

> From: Ben Boeckel 
> 
> This argument was just never documented in the first place.
> 
> Signed-off-by: Ben Boeckel 
> ---
>  Documentation/security/keys/core.rst | 8 ++--
>  1 file changed, 6 insertions(+), 2 deletions(-)

Applied, thanks.

jon


Re: [PATCH 1/1] Documentation: security: core.rst: add missing argument

2020-05-18 Thread David Howells
Ben Boeckel  wrote:

>   long keyctl(KEYCTL_PKEY_QUERY,
>   key_serial_t key_id, unsigned long reserved,
> + const char* params,
>   struct keyctl_pkey_query *info);

"const char *params".  I fixed that and applied it.

David



Re: [PATCH 1/1] Documentation: security: core.rst: add missing argument

2020-05-16 Thread Jarkko Sakkinen
On Fri, 2020-05-15 at 20:39 -0400, Ben Boeckel wrote:
> From: Ben Boeckel 
> 
> This argument was just never documented in the first place.
> 
> Signed-off-by: Ben Boeckel 

Reviewed-by: Jarkko Sakkinen 

/Jarkko



[PATCH 1/1] Documentation: security: core.rst: add missing argument

2020-05-15 Thread Ben Boeckel
From: Ben Boeckel 

This argument was just never documented in the first place.

Signed-off-by: Ben Boeckel 
---
 Documentation/security/keys/core.rst | 8 ++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/Documentation/security/keys/core.rst 
b/Documentation/security/keys/core.rst
index d9b0b859018b..c26b9e7d47c2 100644
--- a/Documentation/security/keys/core.rst
+++ b/Documentation/security/keys/core.rst
@@ -920,10 +920,14 @@ The keyctl syscall functions are:
 
long keyctl(KEYCTL_PKEY_QUERY,
key_serial_t key_id, unsigned long reserved,
+   const char* params,
struct keyctl_pkey_query *info);
 
- Get information about an asymmetric key.  The information is returned in
- the keyctl_pkey_query struct::
+ Get information about an asymmetric key.  Specific algorithms and
+ encodings may be queried by using the ``params`` argument.  This is a
+ string containing a space- or tab-separated string of key-value pairs.
+ Currently supported keys include ``enc`` and ``hash``.  The information
+ is returned in the keyctl_pkey_query struct::
 
__u32   supported_ops;
__u32   key_size;
-- 
2.25.4