Re: [PATCH 1/1] dmaengine:jz4740:fix memory leak

2018-04-04 Thread Lars-Peter Clausen
On 04/04/2018 05:21 AM, Xidong Wang wrote: > In function jz4740_dma_probe(), the memory allocated by > clk_get() is not released on the error path that ret, which holds > the return value of dma_async_device_register(), is not NULL. > This will result in a memory leak bug. > > Signed-off-by:

Re: [PATCH 1/1] dmaengine:jz4740:fix memory leak

2018-04-04 Thread Lars-Peter Clausen
On 04/04/2018 05:21 AM, Xidong Wang wrote: > In function jz4740_dma_probe(), the memory allocated by > clk_get() is not released on the error path that ret, which holds > the return value of dma_async_device_register(), is not NULL. > This will result in a memory leak bug. > > Signed-off-by:

Re: [PATCH 1/1] dmaengine:jz4740:fix memory leak

2018-04-03 Thread Vinod Koul
On Wed, Apr 04, 2018 at 11:21:58AM +0800, Xidong Wang wrote: > In function jz4740_dma_probe(), the memory allocated by > clk_get() is not released on the error path that ret, which holds > the return value of dma_async_device_register(), is not NULL. > This will result in a memory leak bug. I

Re: [PATCH 1/1] dmaengine:jz4740:fix memory leak

2018-04-03 Thread Vinod Koul
On Wed, Apr 04, 2018 at 11:21:58AM +0800, Xidong Wang wrote: > In function jz4740_dma_probe(), the memory allocated by > clk_get() is not released on the error path that ret, which holds > the return value of dma_async_device_register(), is not NULL. > This will result in a memory leak bug. I

[PATCH 1/1] dmaengine:jz4740:fix memory leak

2018-04-03 Thread Xidong Wang
In function jz4740_dma_probe(), the memory allocated by clk_get() is not released on the error path that ret, which holds the return value of dma_async_device_register(), is not NULL. This will result in a memory leak bug. Signed-off-by: Xidong Wang ---

[PATCH 1/1] dmaengine:jz4740:fix memory leak

2018-04-03 Thread Xidong Wang
In function jz4740_dma_probe(), the memory allocated by clk_get() is not released on the error path that ret, which holds the return value of dma_async_device_register(), is not NULL. This will result in a memory leak bug. Signed-off-by: Xidong Wang --- drivers/dma/dma-jz4740.c | 1 + 1 file