Re: [PATCH 1/1] driver core: Fix unbalance probe_count in really_probe()

2020-06-03 Thread Geert Uytterhoeven
Hi Ji-Ze, On Wed, Jun 3, 2020 at 9:35 AM Ji-Ze Hong (Peter Hong) wrote: > Geert Uytterhoeven 於 2020/6/3 下午 03:13 寫道: > > If devres_head is not empty, you have a serious problem on your system, > > as those resources may be in an unknown state (e.g. freed but still in > > use). While I had

Re: [PATCH 1/1] driver core: Fix unbalance probe_count in really_probe()

2020-06-03 Thread Ji-Ze Hong (Peter Hong)
Hi Geert, Geert Uytterhoeven 於 2020/6/3 下午 03:13 寫道: Hi Ji-Ze, If devres_head is not empty, you have a serious problem on your system, as those resources may be in an unknown state (e.g. freed but still in use). While I had missed the probe_count imbalance when implementing the original

Re: [PATCH 1/1] driver core: Fix unbalance probe_count in really_probe()

2020-06-03 Thread Geert Uytterhoeven
Hi Ji-Ze, On Wed, Jun 3, 2020 at 8:45 AM Ji-Ze Hong (Peter Hong) wrote: > In previous patch, using return -EBUSY in really_probe() instead WARN_ON() > only. The following is the partial code. > > ... > atomic_inc(_count); > pr_debug("bus: '%s': %s: probing driver %s with

[PATCH 1/1] driver core: Fix unbalance probe_count in really_probe()

2020-06-03 Thread Ji-Ze Hong (Peter Hong)
In previous patch, using return -EBUSY in really_probe() instead WARN_ON() only. The following is the partial code. ... atomic_inc(_count); pr_debug("bus: '%s': %s: probing driver %s with device %s\n", drv->bus->name, __func__, drv->name, dev_name(dev));