Re: [PATCH 1/1] ethernet driver: dm9000: davicom: Upgrade the driver to suit for all DM9000 series chips

2013-03-25 Thread Jonathan Corbet
On Mon, 25 Mar 2013 16:04:42 +0800 Joseph CHANG wrote: > From: Joseph CHANG > > Some necessary modification for DM9000 series chips to be better in operation! Interesting, this had been sent to me privately at about the same time. For the record, here's what I sent back: From: Jonathan

Re: [PATCH 1/1] ethernet driver: dm9000: davicom: Upgrade the driver to suit for all DM9000 series chips

2013-03-25 Thread David Miller
From: Joseph CHANG Date: Mon, 25 Mar 2013 16:04:42 +0800 > #define CARDNAME "dm9000" > -#define DRV_VERSION "1.31" > +/* [KERN-ADD-1](upgrade) */ > +#define DRV_VERSION "1.39" ... > + /* [KERN-ADD-2] */ These kinds of comments are absolutely inapproprate. -- To

Re: [PATCH 1/1] ethernet driver: dm9000: davicom: Upgrade the driver to suit for all DM9000 series chips

2013-03-25 Thread David Miller
From: Joseph CHANG josright...@gmail.com Date: Mon, 25 Mar 2013 16:04:42 +0800 #define CARDNAME dm9000 -#define DRV_VERSION 1.31 +/* [KERN-ADD-1](upgrade) */ +#define DRV_VERSION 1.39 ... + /* [KERN-ADD-2] */ These kinds of comments are absolutely inapproprate.

Re: [PATCH 1/1] ethernet driver: dm9000: davicom: Upgrade the driver to suit for all DM9000 series chips

2013-03-25 Thread Jonathan Corbet
On Mon, 25 Mar 2013 16:04:42 +0800 Joseph CHANG josright...@gmail.com wrote: From: Joseph CHANG joseph_ch...@davicom.com.tw Some necessary modification for DM9000 series chips to be better in operation! Interesting, this had been sent to me privately at about the same time. For the record,