Re: [PATCH 1/1] ext4: better error handling of kstrdup()

2015-04-03 Thread Taesoo Kim
Hi Ted, It's my fault. I didn't properly check the case of having data = NULL to kstrdup() as my system has long mounting options.. Sorry for the trouble. I think there is no clean way to handle this error (better), other than implicitly letting kstrdup() fail (and ignore). Taesoo On 04/03/15

Re: [PATCH 1/1] ext4: better error handling of kstrdup()

2015-04-03 Thread Taesoo Kim
Hi Ted, It's my fault. I didn't properly check the case of having data = NULL to kstrdup() as my system has long mounting options.. Sorry for the trouble. I think there is no clean way to handle this error (better), other than implicitly letting kstrdup() fail (and ignore). Taesoo On 04/03/15

Re: [PATCH 1/1] ext4: better error handling of kstrdup()

2015-04-02 Thread Theodore Ts'o
On Fri, Mar 20, 2015 at 05:21:54PM -0400, Taesoo Kim wrote: > Upon memory pressure, kstrdup() might fail and correctly > handle memory error, although current implementation do not > refer orig_data. > > NOTE. fortunately the correct impl works, other than a > corner case where kstrdup() fails

Re: [PATCH 1/1] ext4: better error handling of kstrdup()

2015-04-02 Thread Theodore Ts'o
On Fri, Mar 20, 2015 at 05:21:54PM -0400, Taesoo Kim wrote: > Upon memory pressure, kstrdup() might fail and correctly > handle memory error, although current implementation do not > refer orig_data. > > NOTE. fortunately the correct impl works, other than a > corner case where kstrdup() fails

Re: [PATCH 1/1] ext4: better error handling of kstrdup()

2015-04-02 Thread Theodore Ts'o
On Fri, Mar 20, 2015 at 05:21:54PM -0400, Taesoo Kim wrote: Upon memory pressure, kstrdup() might fail and correctly handle memory error, although current implementation do not refer orig_data. NOTE. fortunately the correct impl works, other than a corner case where kstrdup() fails and

Re: [PATCH 1/1] ext4: better error handling of kstrdup()

2015-04-02 Thread Theodore Ts'o
On Fri, Mar 20, 2015 at 05:21:54PM -0400, Taesoo Kim wrote: Upon memory pressure, kstrdup() might fail and correctly handle memory error, although current implementation do not refer orig_data. NOTE. fortunately the correct impl works, other than a corner case where kstrdup() fails and

[PATCH 1/1] ext4: better error handling of kstrdup()

2015-03-20 Thread Taesoo Kim
Upon memory pressure, kstrdup() might fail and correctly handle memory error, although current implementation do not refer orig_data. NOTE. fortunately the correct impl works, other than a corner case where kstrdup() fails and kzalloc() succeeds; it might record 'NULL' in the log. Signed-off-by:

[PATCH 1/1] ext4: better error handling of kstrdup()

2015-03-20 Thread Taesoo Kim
Upon memory pressure, kstrdup() might fail and correctly handle memory error, although current implementation do not refer orig_data. NOTE. fortunately the correct impl works, other than a corner case where kstrdup() fails and kzalloc() succeeds; it might record 'NULL' in the log. Signed-off-by: