Re: [PATCH 1/1] gpio: max77620: get gpio value based on direction

2016-07-04 Thread Linus Walleij 
On Mon, Jun 27, 2016 at 12:56 PM, Venkat Reddy Talla
 wrote:

> Gpio direction is determined by DIRx bit of GPIO
> configuration register, return max77620 gpio value
> based on direction in or out.
>
> Signed-off-by: Venkat Reddy Talla 

Patch applied with Alex' ACK.

Yours,
Linus Walleij

Re: [PATCH 1/1] gpio: max77620: get gpio value based on direction

2016-07-04 Thread Linus Walleij 
On Mon, Jun 27, 2016 at 12:56 PM, Venkat Reddy Talla
 wrote:

> Gpio direction is determined by DIRx bit of GPIO
> configuration register, return max77620 gpio value
> based on direction in or out.
>
> Signed-off-by: Venkat Reddy Talla 

Patch applied with Alex' ACK.

Yours,
Linus Walleij

Re: [PATCH 1/1] gpio: max77620: get gpio value based on direction

2016-06-28 Thread Alexandre Courbot 
On Mon, Jun 27, 2016 at 7:56 PM, Venkat Reddy Talla
 wrote:
> Gpio direction is determined by DIRx bit of GPIO
> configuration register, return max77620 gpio value
> based on direction in or out.
>
> Signed-off-by: Venkat Reddy Talla 
> ---
>  drivers/gpio/gpio-max77620.c | 5 -
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-max77620.c b/drivers/gpio/gpio-max77620.c
> index 8658c32..b46b436 100644
> --- a/drivers/gpio/gpio-max77620.c
> +++ b/drivers/gpio/gpio-max77620.c
> @@ -123,7 +123,10 @@ static int max77620_gpio_get(struct gpio_chip *gc, 
> unsigned int offset)
> return ret;
> }
>
> -   return !!(val & MAX77620_CNFG_GPIO_INPUT_VAL_MASK);
> +   if  (val & MAX77620_CNFG_GPIO_DIR_MASK)
> +   return !!(val & MAX77620_CNFG_GPIO_INPUT_VAL_MASK);
> +   else
> +   return !!(val & MAX77620_CNFG_GPIO_OUTPUT_VAL_MASK);

Looks sensible!

Reviewed-by: Alexandre Courbot

Re: [PATCH 1/1] gpio: max77620: get gpio value based on direction

2016-06-28 Thread Alexandre Courbot 
On Mon, Jun 27, 2016 at 7:56 PM, Venkat Reddy Talla
 wrote:
> Gpio direction is determined by DIRx bit of GPIO
> configuration register, return max77620 gpio value
> based on direction in or out.
>
> Signed-off-by: Venkat Reddy Talla 
> ---
>  drivers/gpio/gpio-max77620.c | 5 -
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-max77620.c b/drivers/gpio/gpio-max77620.c
> index 8658c32..b46b436 100644
> --- a/drivers/gpio/gpio-max77620.c
> +++ b/drivers/gpio/gpio-max77620.c
> @@ -123,7 +123,10 @@ static int max77620_gpio_get(struct gpio_chip *gc, 
> unsigned int offset)
> return ret;
> }
>
> -   return !!(val & MAX77620_CNFG_GPIO_INPUT_VAL_MASK);
> +   if  (val & MAX77620_CNFG_GPIO_DIR_MASK)
> +   return !!(val & MAX77620_CNFG_GPIO_INPUT_VAL_MASK);
> +   else
> +   return !!(val & MAX77620_CNFG_GPIO_OUTPUT_VAL_MASK);

Looks sensible!

Reviewed-by: Alexandre Courbot

[PATCH 1/1] gpio: max77620: get gpio value based on direction

2016-06-27 Thread Venkat Reddy Talla 
Gpio direction is determined by DIRx bit of GPIO
configuration register, return max77620 gpio value
based on direction in or out.

Signed-off-by: Venkat Reddy Talla 
---
 drivers/gpio/gpio-max77620.c | 5 -
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/gpio/gpio-max77620.c b/drivers/gpio/gpio-max77620.c
index 8658c32..b46b436 100644
--- a/drivers/gpio/gpio-max77620.c
+++ b/drivers/gpio/gpio-max77620.c
@@ -123,7 +123,10 @@ static int max77620_gpio_get(struct gpio_chip *gc, 
unsigned int offset)
return ret;
}
 
-   return !!(val & MAX77620_CNFG_GPIO_INPUT_VAL_MASK);
+   if  (val & MAX77620_CNFG_GPIO_DIR_MASK)
+   return !!(val & MAX77620_CNFG_GPIO_INPUT_VAL_MASK);
+   else
+   return !!(val & MAX77620_CNFG_GPIO_OUTPUT_VAL_MASK);
 }
 
 static int max77620_gpio_dir_output(struct gpio_chip *gc, unsigned int offset,
-- 
2.1.4

[PATCH 1/1] gpio: max77620: get gpio value based on direction

2016-06-27 Thread Venkat Reddy Talla 
Gpio direction is determined by DIRx bit of GPIO
configuration register, return max77620 gpio value
based on direction in or out.

Signed-off-by: Venkat Reddy Talla 
---
 drivers/gpio/gpio-max77620.c | 5 -
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/gpio/gpio-max77620.c b/drivers/gpio/gpio-max77620.c
index 8658c32..b46b436 100644
--- a/drivers/gpio/gpio-max77620.c
+++ b/drivers/gpio/gpio-max77620.c
@@ -123,7 +123,10 @@ static int max77620_gpio_get(struct gpio_chip *gc, 
unsigned int offset)
return ret;
}
 
-   return !!(val & MAX77620_CNFG_GPIO_INPUT_VAL_MASK);
+   if  (val & MAX77620_CNFG_GPIO_DIR_MASK)
+   return !!(val & MAX77620_CNFG_GPIO_INPUT_VAL_MASK);
+   else
+   return !!(val & MAX77620_CNFG_GPIO_OUTPUT_VAL_MASK);
 }
 
 static int max77620_gpio_dir_output(struct gpio_chip *gc, unsigned int offset,
-- 
2.1.4