Re: [PATCH 1/1] irq-gic: add capability to set bypass flag in GIC

2013-11-26 Thread Anup Patel
On Tue, Nov 26, 2013 at 9:05 PM, Rob Herring wrote: > On Mon, Nov 25, 2013 at 10:00 AM, Anup Patel wrote: >> On Mon, Nov 25, 2013 at 9:13 PM, Rob Herring wrote: >>> On Sat, Nov 23, 2013 at 2:41 AM, Anup Patel wrote: On Wed, Nov 20, 2013 at 4:28 PM, Marc Zyngier wrote: > [dropping

Re: [PATCH 1/1] irq-gic: add capability to set bypass flag in GIC

2013-11-26 Thread Rob Herring
On Mon, Nov 25, 2013 at 10:00 AM, Anup Patel wrote: > On Mon, Nov 25, 2013 at 9:13 PM, Rob Herring wrote: >> On Sat, Nov 23, 2013 at 2:41 AM, Anup Patel wrote: >>> On Wed, Nov 20, 2013 at 4:28 PM, Marc Zyngier wrote: [dropping from the CC list, as someone seems to have tripped on

Re: [PATCH 1/1] irq-gic: add capability to set bypass flag in GIC

2013-11-26 Thread Rob Herring
On Mon, Nov 25, 2013 at 10:00 AM, Anup Patel a...@brainfault.org wrote: On Mon, Nov 25, 2013 at 9:13 PM, Rob Herring robherri...@gmail.com wrote: On Sat, Nov 23, 2013 at 2:41 AM, Anup Patel a...@brainfault.org wrote: On Wed, Nov 20, 2013 at 4:28 PM, Marc Zyngier marc.zyng...@arm.com wrote:

Re: [PATCH 1/1] irq-gic: add capability to set bypass flag in GIC

2013-11-26 Thread Anup Patel
On Tue, Nov 26, 2013 at 9:05 PM, Rob Herring robherri...@gmail.com wrote: On Mon, Nov 25, 2013 at 10:00 AM, Anup Patel a...@brainfault.org wrote: On Mon, Nov 25, 2013 at 9:13 PM, Rob Herring robherri...@gmail.com wrote: On Sat, Nov 23, 2013 at 2:41 AM, Anup Patel a...@brainfault.org wrote: On

Re: [PATCH 1/1] irq-gic: add capability to set bypass flag in GIC

2013-11-25 Thread Feng Kan
> >> The Legacy-IRQ bypass disable and Legacy-FIQ bypass disable is a >> feature of GIC-400 and its not X-Gene specific. The only difference in X-Gene >> is that we use PPI31 (Legacy-IRQ) for timer and PPI28 (Legacy-FIQ) for perf > > Amazing. Someone managed to push the weird-o-meter one level

Re: [PATCH 1/1] irq-gic: add capability to set bypass flag in GIC

2013-11-25 Thread Anup Patel
On Mon, Nov 25, 2013 at 9:13 PM, Rob Herring wrote: > On Sat, Nov 23, 2013 at 2:41 AM, Anup Patel wrote: >> On Wed, Nov 20, 2013 at 4:28 PM, Marc Zyngier wrote: >>> [dropping from the CC list, as someone seems to have >>> tripped on the config file, and I'm tired of getting bounces] >>> >>>

Re: [PATCH 1/1] irq-gic: add capability to set bypass flag in GIC

2013-11-25 Thread Rob Herring
On Sat, Nov 23, 2013 at 2:41 AM, Anup Patel wrote: > On Wed, Nov 20, 2013 at 4:28 PM, Marc Zyngier wrote: >> [dropping from the CC list, as someone seems to have >> tripped on the config file, and I'm tired of getting bounces] >> >> Feng, >> >> On 19/11/13 21:42, Feng Kan wrote: >>> The

Re: [PATCH 1/1] irq-gic: add capability to set bypass flag in GIC

2013-11-25 Thread Anup Patel
(Adding correct "Kumar Sankaran" to CC. My mistake.) (Adding back patc...@apm.com. It is fixed now). On Mon, Nov 25, 2013 at 2:52 PM, Marc Zyngier wrote: > On 23/11/13 08:41, Anup Patel wrote: >> On Wed, Nov 20, 2013 at 4:28 PM, Marc Zyngier wrote: >>> [dropping from the CC list, as someone

Re: [PATCH 1/1] irq-gic: add capability to set bypass flag in GIC

2013-11-25 Thread Marc Zyngier
On 23/11/13 08:41, Anup Patel wrote: > On Wed, Nov 20, 2013 at 4:28 PM, Marc Zyngier wrote: >> [dropping from the CC list, as someone seems to have >> tripped on the config file, and I'm tired of getting bounces] >> >> Feng, >> >> On 19/11/13 21:42, Feng Kan wrote: >>> The GIC-400

Re: [PATCH 1/1] irq-gic: add capability to set bypass flag in GIC

2013-11-25 Thread Marc Zyngier
On 23/11/13 08:41, Anup Patel wrote: On Wed, Nov 20, 2013 at 4:28 PM, Marc Zyngier marc.zyng...@arm.com wrote: [dropping patc...@apm.com from the CC list, as someone seems to have tripped on the config file, and I'm tired of getting bounces] Feng, On 19/11/13 21:42, Feng Kan wrote: The

Re: [PATCH 1/1] irq-gic: add capability to set bypass flag in GIC

2013-11-25 Thread Anup Patel
(Adding correct Kumar Sankaran to CC. My mistake.) (Adding back patc...@apm.com. It is fixed now). On Mon, Nov 25, 2013 at 2:52 PM, Marc Zyngier marc.zyng...@arm.com wrote: On 23/11/13 08:41, Anup Patel wrote: On Wed, Nov 20, 2013 at 4:28 PM, Marc Zyngier marc.zyng...@arm.com wrote: [dropping

Re: [PATCH 1/1] irq-gic: add capability to set bypass flag in GIC

2013-11-25 Thread Rob Herring
On Sat, Nov 23, 2013 at 2:41 AM, Anup Patel a...@brainfault.org wrote: On Wed, Nov 20, 2013 at 4:28 PM, Marc Zyngier marc.zyng...@arm.com wrote: [dropping patc...@apm.com from the CC list, as someone seems to have tripped on the config file, and I'm tired of getting bounces] Feng, On

Re: [PATCH 1/1] irq-gic: add capability to set bypass flag in GIC

2013-11-25 Thread Anup Patel
On Mon, Nov 25, 2013 at 9:13 PM, Rob Herring robherri...@gmail.com wrote: On Sat, Nov 23, 2013 at 2:41 AM, Anup Patel a...@brainfault.org wrote: On Wed, Nov 20, 2013 at 4:28 PM, Marc Zyngier marc.zyng...@arm.com wrote: [dropping patc...@apm.com from the CC list, as someone seems to have

Re: [PATCH 1/1] irq-gic: add capability to set bypass flag in GIC

2013-11-25 Thread Feng Kan
The Legacy-IRQ bypass disable and Legacy-FIQ bypass disable is a feature of GIC-400 and its not X-Gene specific. The only difference in X-Gene is that we use PPI31 (Legacy-IRQ) for timer and PPI28 (Legacy-FIQ) for perf Amazing. Someone managed to push the weird-o-meter one level higher.

Re: [PATCH 1/1] irq-gic: add capability to set bypass flag in GIC

2013-11-23 Thread Anup Patel
On Sat, Nov 23, 2013 at 2:11 PM, Anup Patel wrote: > On Wed, Nov 20, 2013 at 4:28 PM, Marc Zyngier wrote: >> [dropping from the CC list, as someone seems to have >> tripped on the config file, and I'm tired of getting bounces] >> >> Feng, >> >> On 19/11/13 21:42, Feng Kan wrote: >>> The

Re: [PATCH 1/1] irq-gic: add capability to set bypass flag in GIC

2013-11-23 Thread Anup Patel
On Wed, Nov 20, 2013 at 4:28 PM, Marc Zyngier wrote: > [dropping from the CC list, as someone seems to have > tripped on the config file, and I'm tired of getting bounces] > > Feng, > > On 19/11/13 21:42, Feng Kan wrote: >> The GIC-400 implementation allows for FIQ and IRQ bypass. In the >>

Re: [PATCH 1/1] irq-gic: add capability to set bypass flag in GIC

2013-11-23 Thread Anup Patel
On Wed, Nov 20, 2013 at 4:28 PM, Marc Zyngier marc.zyng...@arm.com wrote: [dropping patc...@apm.com from the CC list, as someone seems to have tripped on the config file, and I'm tired of getting bounces] Feng, On 19/11/13 21:42, Feng Kan wrote: The GIC-400 implementation allows for FIQ

Re: [PATCH 1/1] irq-gic: add capability to set bypass flag in GIC

2013-11-23 Thread Anup Patel
On Sat, Nov 23, 2013 at 2:11 PM, Anup Patel a...@brainfault.org wrote: On Wed, Nov 20, 2013 at 4:28 PM, Marc Zyngier marc.zyng...@arm.com wrote: [dropping patc...@apm.com from the CC list, as someone seems to have tripped on the config file, and I'm tired of getting bounces] Feng, On

Re: [PATCH 1/1] irq-gic: add capability to set bypass flag in GIC

2013-11-22 Thread Feng Kan
>> set_handle_irq(gic_handle_irq); >> >> + gic->bypass_flag = (bypass_val & 0xf) << 4; >Beware, the top 2 bits are reserved on GICv1, and shouldn't be messed with. The only time those bits are touched are when the dts is modified with the bypass flag. Otherwise those bits remain

Re: [PATCH 1/1] irq-gic: add capability to set bypass flag in GIC

2013-11-22 Thread Feng Kan
set_handle_irq(gic_handle_irq); + gic-bypass_flag = (bypass_val 0xf) 4; Beware, the top 2 bits are reserved on GICv1, and shouldn't be messed with. The only time those bits are touched are when the dts is modified with the bypass flag. Otherwise those bits remain untouched as

Re: [PATCH 1/1] irq-gic: add capability to set bypass flag in GIC

2013-11-20 Thread Marc Zyngier
[dropping from the CC list, as someone seems to have tripped on the config file, and I'm tired of getting bounces] Feng, On 19/11/13 21:42, Feng Kan wrote: > The GIC-400 implementation allows for FIQ and IRQ bypass. In the > X-Gene implementation, the FIQ bypass must be enabled at all time. >

Re: [PATCH 1/1] irq-gic: add capability to set bypass flag in GIC

2013-11-20 Thread Marc Zyngier
[dropping patc...@apm.com from the CC list, as someone seems to have tripped on the config file, and I'm tired of getting bounces] Feng, On 19/11/13 21:42, Feng Kan wrote: The GIC-400 implementation allows for FIQ and IRQ bypass. In the X-Gene implementation, the FIQ bypass must be enabled at

[PATCH 1/1] irq-gic: add capability to set bypass flag in GIC

2013-11-19 Thread Feng Kan
The GIC-400 implementation allows for FIQ and IRQ bypass. In the X-Gene implementation, the FIQ bypass must be enabled at all time. Otherwise, some PPI will appear as FIQ and cause kernel problem. Signed-off-by: Feng Kan --- drivers/irqchip/irq-gic.c | 15 +++

[PATCH 1/1] irq-gic: add capability to set bypass flag in GIC

2013-11-19 Thread Feng Kan
The GIC-400 implementation allows for FIQ and IRQ bypass. In the X-Gene implementation, the FIQ bypass must be enabled at all time. Otherwise, some PPI will appear as FIQ and cause kernel problem. Signed-off-by: Feng Kan f...@apm.com --- drivers/irqchip/irq-gic.c | 15 +++