Re: [REMINDER: PATCH 1/1] mtd:nand:clk: preparation for switch to common clock framework
On Thu, 2012-10-11 at 15:37 +0530, Sekhar Nori wrote: > Hi Artem, > > On 10/11/2012 3:27 PM, Artem Bityutskiy wrote: > > On Fri, 2012-09-28 at 16:10 +, Karicheri, Muralidharan wrote: > >>>> -Original Message- > >>>> From: Karicheri, Muralidharan > >>>> Sent: Monday, September 17, 2012 12:38 PM > >>>> To: dw...@infradead.org; artem.bityuts...@linux.intel.com; h...@denx.de; > >>>> miked...@newsguy.com; linux-...@lists.infradead.org; > >>>> linux-kernel@vger.kernel.org; > >>>> davinci-linux-open-sou...@linux.davincidsp.com; > >>>> linux-arm-ker...@lists.infradead.org > >>>> Cc: Karicheri, Muralidharan > >>>> Subject: [PATCH 1/1] mtd:nand:clk: preparation for switch to common > >>>> clock framework > > > > I do not see this patch in my mailbox. Can you please re-send with all > > the acks? > > This patch is already applied to linux-next. Do you need it still? > > http://git.kernel.org/?p=linux/kernel/git/next/linux-next.git;a=commit;h=ea73fe7f0d562154975a77fe77ae3da6ab4d3e77 Ah, right, no, I don't, thanks! -- Best Regards, Artem Bityutskiy signature.asc Description: This is a digitally signed message part
Re: [REMINDER: PATCH 1/1] mtd:nand:clk: preparation for switch to common clock framework
Hi Artem, On 10/11/2012 3:27 PM, Artem Bityutskiy wrote: > On Fri, 2012-09-28 at 16:10 +, Karicheri, Muralidharan wrote: >>>> -Original Message- >>>> From: Karicheri, Muralidharan >>>> Sent: Monday, September 17, 2012 12:38 PM >>>> To: dw...@infradead.org; artem.bityuts...@linux.intel.com; h...@denx.de; >>>> miked...@newsguy.com; linux-...@lists.infradead.org; >>>> linux-kernel@vger.kernel.org; >>>> davinci-linux-open-sou...@linux.davincidsp.com; >>>> linux-arm-ker...@lists.infradead.org >>>> Cc: Karicheri, Muralidharan >>>> Subject: [PATCH 1/1] mtd:nand:clk: preparation for switch to common clock >>>> framework > > I do not see this patch in my mailbox. Can you please re-send with all > the acks? This patch is already applied to linux-next. Do you need it still? http://git.kernel.org/?p=linux/kernel/git/next/linux-next.git;a=commit;h=ea73fe7f0d562154975a77fe77ae3da6ab4d3e77 Thanks, Sekhar -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [REMINDER: PATCH 1/1] mtd:nand:clk: preparation for switch to common clock framework
On Fri, 2012-09-28 at 16:10 +, Karicheri, Muralidharan wrote: > >> -Original Message- > >> From: Karicheri, Muralidharan > >> Sent: Monday, September 17, 2012 12:38 PM > >> To: dw...@infradead.org; artem.bityuts...@linux.intel.com; h...@denx.de; > >> miked...@newsguy.com; linux-...@lists.infradead.org; > >> linux-kernel@vger.kernel.org; > >> davinci-linux-open-sou...@linux.davincidsp.com; > >> linux-arm-ker...@lists.infradead.org > >> Cc: Karicheri, Muralidharan > >> Subject: [PATCH 1/1] mtd:nand:clk: preparation for switch to common clock > >> framework I do not see this patch in my mailbox. Can you please re-send with all the acks? -- Best Regards, Artem Bityutskiy signature.asc Description: This is a digitally signed message part
Re: [REMINDER: PATCH 1/1] mtd:nand:clk: preparation for switch to common clock framework
On Fri, 2012-09-28 at 16:10 +, Karicheri, Muralidharan wrote: -Original Message- From: Karicheri, Muralidharan Sent: Monday, September 17, 2012 12:38 PM To: dw...@infradead.org; artem.bityuts...@linux.intel.com; h...@denx.de; miked...@newsguy.com; linux-...@lists.infradead.org; linux-kernel@vger.kernel.org; davinci-linux-open-sou...@linux.davincidsp.com; linux-arm-ker...@lists.infradead.org Cc: Karicheri, Muralidharan Subject: [PATCH 1/1] mtd:nand:clk: preparation for switch to common clock framework I do not see this patch in my mailbox. Can you please re-send with all the acks? -- Best Regards, Artem Bityutskiy signature.asc Description: This is a digitally signed message part
Re: [REMINDER: PATCH 1/1] mtd:nand:clk: preparation for switch to common clock framework
Hi Artem, On 10/11/2012 3:27 PM, Artem Bityutskiy wrote: On Fri, 2012-09-28 at 16:10 +, Karicheri, Muralidharan wrote: -Original Message- From: Karicheri, Muralidharan Sent: Monday, September 17, 2012 12:38 PM To: dw...@infradead.org; artem.bityuts...@linux.intel.com; h...@denx.de; miked...@newsguy.com; linux-...@lists.infradead.org; linux-kernel@vger.kernel.org; davinci-linux-open-sou...@linux.davincidsp.com; linux-arm-ker...@lists.infradead.org Cc: Karicheri, Muralidharan Subject: [PATCH 1/1] mtd:nand:clk: preparation for switch to common clock framework I do not see this patch in my mailbox. Can you please re-send with all the acks? This patch is already applied to linux-next. Do you need it still? http://git.kernel.org/?p=linux/kernel/git/next/linux-next.git;a=commit;h=ea73fe7f0d562154975a77fe77ae3da6ab4d3e77 Thanks, Sekhar -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [REMINDER: PATCH 1/1] mtd:nand:clk: preparation for switch to common clock framework
On Thu, 2012-10-11 at 15:37 +0530, Sekhar Nori wrote: Hi Artem, On 10/11/2012 3:27 PM, Artem Bityutskiy wrote: On Fri, 2012-09-28 at 16:10 +, Karicheri, Muralidharan wrote: -Original Message- From: Karicheri, Muralidharan Sent: Monday, September 17, 2012 12:38 PM To: dw...@infradead.org; artem.bityuts...@linux.intel.com; h...@denx.de; miked...@newsguy.com; linux-...@lists.infradead.org; linux-kernel@vger.kernel.org; davinci-linux-open-sou...@linux.davincidsp.com; linux-arm-ker...@lists.infradead.org Cc: Karicheri, Muralidharan Subject: [PATCH 1/1] mtd:nand:clk: preparation for switch to common clock framework I do not see this patch in my mailbox. Can you please re-send with all the acks? This patch is already applied to linux-next. Do you need it still? http://git.kernel.org/?p=linux/kernel/git/next/linux-next.git;a=commit;h=ea73fe7f0d562154975a77fe77ae3da6ab4d3e77 Ah, right, no, I don't, thanks! -- Best Regards, Artem Bityutskiy signature.asc Description: This is a digitally signed message part
Re: [PATCH 1/1] mtd:nand:clk: preparation for switch to common clock framework
On 10/9/2012 6:33 PM, Sekhar Nori wrote: > On 9/17/2012 10:07 PM, Murali Karicheri wrote: >> As a first step towards migrating davinci platforms to use common clock >> framework, replace all instances of clk_enable() with clk_prepare_enable() >> and clk_disable() with clk_disable_unprepare(). Until the platform is >> switched to use the CONFIG_HAVE_CLK_PREPARE Kconfig variable, this just >> adds a might_sleep() call and would work without any issues. >> >> This will make it easy later to switch to common clk based implementation >> of clk driver from DaVinci specific driver. >> >> Signed-off-by: Murali Karicheri >> Reviewed-by: Mike Turquette > > Tested this using NAND flash on DA850 EVM. > > Acked-by: Sekhar Nori > > Any chance this can make into the v3.7 kernel? Just noticed another thread where Artem replied saying this patch is pushed. Sorry about the noise. Thanks, Sekhar -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/1] mtd:nand:clk: preparation for switch to common clock framework
On 9/17/2012 10:07 PM, Murali Karicheri wrote: > As a first step towards migrating davinci platforms to use common clock > framework, replace all instances of clk_enable() with clk_prepare_enable() > and clk_disable() with clk_disable_unprepare(). Until the platform is > switched to use the CONFIG_HAVE_CLK_PREPARE Kconfig variable, this just > adds a might_sleep() call and would work without any issues. > > This will make it easy later to switch to common clk based implementation > of clk driver from DaVinci specific driver. > > Signed-off-by: Murali Karicheri > Reviewed-by: Mike Turquette Tested this using NAND flash on DA850 EVM. Acked-by: Sekhar Nori Any chance this can make into the v3.7 kernel? Thanks, Sekhar -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/1] mtd:nand:clk: preparation for switch to common clock framework
On 9/17/2012 10:07 PM, Murali Karicheri wrote: As a first step towards migrating davinci platforms to use common clock framework, replace all instances of clk_enable() with clk_prepare_enable() and clk_disable() with clk_disable_unprepare(). Until the platform is switched to use the CONFIG_HAVE_CLK_PREPARE Kconfig variable, this just adds a might_sleep() call and would work without any issues. This will make it easy later to switch to common clk based implementation of clk driver from DaVinci specific driver. Signed-off-by: Murali Karicheri m-kariche...@ti.com Reviewed-by: Mike Turquette mturque...@linaro.org Tested this using NAND flash on DA850 EVM. Acked-by: Sekhar Nori nsek...@ti.com Any chance this can make into the v3.7 kernel? Thanks, Sekhar -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/1] mtd:nand:clk: preparation for switch to common clock framework
On 10/9/2012 6:33 PM, Sekhar Nori wrote: On 9/17/2012 10:07 PM, Murali Karicheri wrote: As a first step towards migrating davinci platforms to use common clock framework, replace all instances of clk_enable() with clk_prepare_enable() and clk_disable() with clk_disable_unprepare(). Until the platform is switched to use the CONFIG_HAVE_CLK_PREPARE Kconfig variable, this just adds a might_sleep() call and would work without any issues. This will make it easy later to switch to common clk based implementation of clk driver from DaVinci specific driver. Signed-off-by: Murali Karicheri m-kariche...@ti.com Reviewed-by: Mike Turquette mturque...@linaro.org Tested this using NAND flash on DA850 EVM. Acked-by: Sekhar Nori nsek...@ti.com Any chance this can make into the v3.7 kernel? Just noticed another thread where Artem replied saying this patch is pushed. Sorry about the noise. Thanks, Sekhar -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[REMINDER: PATCH 1/1] mtd:nand:clk: preparation for switch to common clock framework
>> -Original Message-
>> From: Karicheri, Muralidharan
>> Sent: Monday, September 17, 2012 12:38 PM
>> To: dw...@infradead.org; artem.bityuts...@linux.intel.com; h...@denx.de;
>> miked...@newsguy.com; linux-...@lists.infradead.org;
>> linux-kernel@vger.kernel.org;
>> davinci-linux-open-sou...@linux.davincidsp.com;
>> linux-arm-ker...@lists.infradead.org
>> Cc: Karicheri, Muralidharan
>> Subject: [PATCH 1/1] mtd:nand:clk: preparation for switch to common clock
>> framework
>>
>> As a first step towards migrating davinci platforms to use common clock
>> framework, replace all instances of clk_enable() with clk_prepare_enable()
>> and clk_disable() with clk_disable_unprepare(). Until the platform is
>> switched to use the CONFIG_HAVE_CLK_PREPARE Kconfig variable, this just
>> adds a might_sleep() call and would work without any issues.
>>
>> This will make it easy later to switch to common clk based implementation
>> of clk driver from DaVinci specific driver.
>>
>> Signed-off-by: Murali Karicheri
>> Reviewed-by: Mike Turquette
>>
>> diff --git a/drivers/mtd/nand/davinci_nand.c
>> b/drivers/mtd/nand/davinci_nand.c
>> index f386b3c..df1ab7d 100644
>> --- a/drivers/mtd/nand/davinci_nand.c
>> +++ b/drivers/mtd/nand/davinci_nand.c
>> @@ -724,7 +724,7 @@ static int __init nand_davinci_probe(struct
>> platform_device
>> *pdev)
>> goto err_clk;
>> }
>>
>> -ret = clk_enable(info->clk);
>> +ret = clk_prepare_enable(info->clk);
>> if (ret < 0) {
>> dev_dbg(>dev, "unable to enable AEMIF clock, err %d\n",
>> ret);
>> @@ -835,7 +835,7 @@ syndrome_done:
>>
>> err_scan:
>> err_timing:
>> -clk_disable(info->clk);
>> +clk_disable_unprepare(info->clk);
>>
>> err_clk_enable:
>> clk_put(info->clk);
>> @@ -872,7 +872,7 @@ static int __exit nand_davinci_remove(struct
>> platform_device
>> *pdev)
>>
>> nand_release(>mtd);
>>
>> -clk_disable(info->clk);
>> +clk_disable_unprepare(info->clk);
>> clk_put(info->clk);
>>
>> kfree(info);
>> --
>> 1.7.9.5
Could you please review and apply this patch to mtd subsystem tree for
linux-next?
Murali Karicheri
Software Design Engineer
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[REMINDER: PATCH 1/1] mtd:nand:clk: preparation for switch to common clock framework
-Original Message-
From: Karicheri, Muralidharan
Sent: Monday, September 17, 2012 12:38 PM
To: dw...@infradead.org; artem.bityuts...@linux.intel.com; h...@denx.de;
miked...@newsguy.com; linux-...@lists.infradead.org;
linux-kernel@vger.kernel.org;
davinci-linux-open-sou...@linux.davincidsp.com;
linux-arm-ker...@lists.infradead.org
Cc: Karicheri, Muralidharan
Subject: [PATCH 1/1] mtd:nand:clk: preparation for switch to common clock
framework
As a first step towards migrating davinci platforms to use common clock
framework, replace all instances of clk_enable() with clk_prepare_enable()
and clk_disable() with clk_disable_unprepare(). Until the platform is
switched to use the CONFIG_HAVE_CLK_PREPARE Kconfig variable, this just
adds a might_sleep() call and would work without any issues.
This will make it easy later to switch to common clk based implementation
of clk driver from DaVinci specific driver.
Signed-off-by: Murali Karicheri m-kariche...@ti.com
Reviewed-by: Mike Turquette mturque...@linaro.org
diff --git a/drivers/mtd/nand/davinci_nand.c
b/drivers/mtd/nand/davinci_nand.c
index f386b3c..df1ab7d 100644
--- a/drivers/mtd/nand/davinci_nand.c
+++ b/drivers/mtd/nand/davinci_nand.c
@@ -724,7 +724,7 @@ static int __init nand_davinci_probe(struct
platform_device
*pdev)
goto err_clk;
}
-ret = clk_enable(info-clk);
+ret = clk_prepare_enable(info-clk);
if (ret 0) {
dev_dbg(pdev-dev, unable to enable AEMIF clock, err %d\n,
ret);
@@ -835,7 +835,7 @@ syndrome_done:
err_scan:
err_timing:
-clk_disable(info-clk);
+clk_disable_unprepare(info-clk);
err_clk_enable:
clk_put(info-clk);
@@ -872,7 +872,7 @@ static int __exit nand_davinci_remove(struct
platform_device
*pdev)
nand_release(info-mtd);
-clk_disable(info-clk);
+clk_disable_unprepare(info-clk);
clk_put(info-clk);
kfree(info);
--
1.7.9.5
Could you please review and apply this patch to mtd subsystem tree for
linux-next?
Murali Karicheri
Software Design Engineer
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
