Re: [PATCH 1/1] perf annotate: Fix fallback to unparsed disassembler line

2015-03-09 Thread Ingo Molnar
* Arnaldo Carvalho de Melo a...@kernel.org wrote: [...] Further investigation is needed to figure out the nature of the objdump output change so as to make the parser grok it. Btw., maybe someone finds this interesting: we could also (re-)use the in-kernel disassembler (on x86 and any

Re: [PATCH 1/1] perf annotate: Fix fallback to unparsed disassembler line

2015-03-09 Thread Arnaldo Carvalho de Melo
Em Mon, Mar 09, 2015 at 12:09:58PM +0100, Ingo Molnar escreveu: * Arnaldo Carvalho de Melo a...@kernel.org wrote: [...] Further investigation is needed to figure out the nature of the objdump output change so as to make the parser grok it. Btw., maybe someone finds this

Re: [PATCH 1/1] perf annotate: Fix fallback to unparsed disassembler line

2015-03-05 Thread Rabin Vincent
On Thu, Mar 05, 2015 at 04:03:20PM -0300, Arnaldo Carvalho de Melo wrote: When fixing a leak in the 0fb9f2aab738 commit (perf annotate: Fix memory leaks in LOCK handling) we failed to take that into account and instead tried to free one of the data structures that should be freed only when

[PATCH 1/1] perf annotate: Fix fallback to unparsed disassembler line

2015-03-05 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo a...@redhat.com When annotating source/disasm lines the perf tools parse the output of objdump, trying to provide augmented output that allows navigating jumps, calls, etc. But when a line output by objdump can't be parsed the annotation code falls back to just