Re: [PATCH 1/1] regulator: new driver for LP8755

2012-12-02 Thread Mark Brown
On Mon, Dec 03, 2012 at 04:24:43PM +0900, GShark Jeong wrote: > 2012/12/3 Mark Brown > > On Mon, Dec 03, 2012 at 01:44:24PM +0900, Daniel Jeong wrote: > > > + if (ret < 0) > > > + goto out_i2c_error; > > > + dev_info(pchip->dev, "lp8755 : chip ID is 0x%x\n", regval); > >

Re: [PATCH 1/1] regulator: new driver for LP8755

2012-12-02 Thread Mark Brown
On Mon, Dec 03, 2012 at 01:44:24PM +0900, Daniel Jeong wrote: > + regval &= ~(0x01 << id); > + > + /* mode fast means forced pwm mode. > +mode normal means not forced pwm mode, according to > +current load it could be one of modes, PWM/PFM/LPPFM. */ > + return regval ?

Re: [PATCH 1/1] regulator: new driver for LP8755

2012-12-02 Thread Wanlong Gao
<...> > + > +static int __devinit lp8755_regulator_init(struct lp8755_chip *pchip) CONFIG_HOTPLUG is going away; it's already defined to always be 'Y'. So, please don't use __devinit anymore. refer to : http://marc.info/?l=linux-i2c=135341812915168=2 > +{ > + int ret, icnt, buck_num; > +

[PATCH 1/1] regulator: new driver for LP8755

2012-12-02 Thread Daniel Jeong
From: Daniel Jeong This driver is a general version for lp8755 regulator driver of TI. LP8755 : The LP8755 is a high performance power management unit.It contains six step-down DC-DC converters which can be filexibly bundled together in multiphase converters as required by application.

[PATCH 1/1] regulator: new driver for LP8755

2012-12-02 Thread Daniel Jeong
From: Daniel Jeong daniel.je...@ti.com This driver is a general version for lp8755 regulator driver of TI. LP8755 : The LP8755 is a high performance power management unit.It contains six step-down DC-DC converters which can be filexibly bundled together in multiphase converters as required by

Re: [PATCH 1/1] regulator: new driver for LP8755

2012-12-02 Thread Wanlong Gao
... + +static int __devinit lp8755_regulator_init(struct lp8755_chip *pchip) CONFIG_HOTPLUG is going away; it's already defined to always be 'Y'. So, please don't use __devinit anymore. refer to : http://marc.info/?l=linux-i2cm=135341812915168w=2 +{ + int ret, icnt, buck_num; +

Re: [PATCH 1/1] regulator: new driver for LP8755

2012-12-02 Thread Mark Brown
On Mon, Dec 03, 2012 at 01:44:24PM +0900, Daniel Jeong wrote: + regval = ~(0x01 id); + + /* mode fast means forced pwm mode. +mode normal means not forced pwm mode, according to +current load it could be one of modes, PWM/PFM/LPPFM. */ + return regval ?

Re: [PATCH 1/1] regulator: new driver for LP8755

2012-12-02 Thread Mark Brown
On Mon, Dec 03, 2012 at 04:24:43PM +0900, GShark Jeong wrote: 2012/12/3 Mark Brown broo...@opensource.wolfsonmicro.com On Mon, Dec 03, 2012 at 01:44:24PM +0900, Daniel Jeong wrote: + if (ret 0) + goto out_i2c_error; + dev_info(pchip-dev, lp8755 : chip ID is