Re: [PATCH 1/1] sched/headers: fix thread_info. is overwritten by STACK_END_MAGIC

2018-12-11 Thread Wang, Dongsheng
Hello all, Any comments about this patch? Cheers, Dongsheng On 2018/11/30 10:19, Wang, Dongsheng wrote: > On 2018/11/30 10:04, Wang, Dongsheng wrote: >> On 2018/11/30 5:22, Kees Cook wrote: >>> On Tue, Nov 27, 2018 at 8:38 PM Wang, Dongsheng >>> wrote: Hello Kees, On 2018/11/28

Re: [PATCH 1/1] sched/headers: fix thread_info. is overwritten by STACK_END_MAGIC

2018-11-29 Thread Wang, Dongsheng
On 2018/11/30 10:04, Wang, Dongsheng wrote: > On 2018/11/30 5:22, Kees Cook wrote: >> On Tue, Nov 27, 2018 at 8:38 PM Wang, Dongsheng >> wrote: >>> Hello Kees, >>> >>> On 2018/11/28 6:38, Kees Cook wrote: On Thu, Nov 22, 2018 at 11:54 PM, Wang Dongsheng wrote: > When select

Re: [PATCH 1/1] sched/headers: fix thread_info. is overwritten by STACK_END_MAGIC

2018-11-29 Thread Wang, Dongsheng
On 2018/11/30 10:04, Wang, Dongsheng wrote: > On 2018/11/30 5:22, Kees Cook wrote: >> On Tue, Nov 27, 2018 at 8:38 PM Wang, Dongsheng >> wrote: >>> Hello Kees, >>> >>> On 2018/11/28 6:38, Kees Cook wrote: On Thu, Nov 22, 2018 at 11:54 PM, Wang Dongsheng wrote: > When select

Re: [PATCH 1/1] sched/headers: fix thread_info. is overwritten by STACK_END_MAGIC

2018-11-29 Thread Wang, Dongsheng
On 2018/11/30 5:22, Kees Cook wrote: > On Tue, Nov 27, 2018 at 8:38 PM Wang, Dongsheng > wrote: >> Hello Kees, >> >> On 2018/11/28 6:38, Kees Cook wrote: >>> On Thu, Nov 22, 2018 at 11:54 PM, Wang Dongsheng >>> wrote: When select ARCH_TASK_STRUCT_ON_STACK the first of thread_info variable

Re: [PATCH 1/1] sched/headers: fix thread_info. is overwritten by STACK_END_MAGIC

2018-11-29 Thread Wang, Dongsheng
On 2018/11/30 5:22, Kees Cook wrote: > On Tue, Nov 27, 2018 at 8:38 PM Wang, Dongsheng > wrote: >> Hello Kees, >> >> On 2018/11/28 6:38, Kees Cook wrote: >>> On Thu, Nov 22, 2018 at 11:54 PM, Wang Dongsheng >>> wrote: When select ARCH_TASK_STRUCT_ON_STACK the first of thread_info variable

Re: [PATCH 1/1] sched/headers: fix thread_info. is overwritten by STACK_END_MAGIC

2018-11-29 Thread Kees Cook
On Tue, Nov 27, 2018 at 8:38 PM Wang, Dongsheng wrote: > > Hello Kees, > > On 2018/11/28 6:38, Kees Cook wrote: > > On Thu, Nov 22, 2018 at 11:54 PM, Wang Dongsheng > > wrote: > >> When select ARCH_TASK_STRUCT_ON_STACK the first of thread_info variable > >> is overwritten by STACK_END_MAGIC. In

Re: [PATCH 1/1] sched/headers: fix thread_info. is overwritten by STACK_END_MAGIC

2018-11-29 Thread Kees Cook
On Tue, Nov 27, 2018 at 8:38 PM Wang, Dongsheng wrote: > > Hello Kees, > > On 2018/11/28 6:38, Kees Cook wrote: > > On Thu, Nov 22, 2018 at 11:54 PM, Wang Dongsheng > > wrote: > >> When select ARCH_TASK_STRUCT_ON_STACK the first of thread_info variable > >> is overwritten by STACK_END_MAGIC. In

Re: [PATCH 1/1] sched/headers: fix thread_info. is overwritten by STACK_END_MAGIC

2018-11-27 Thread Wang, Dongsheng
Hello Kees, On 2018/11/28 6:38, Kees Cook wrote: > On Thu, Nov 22, 2018 at 11:54 PM, Wang Dongsheng > wrote: >> When select ARCH_TASK_STRUCT_ON_STACK the first of thread_info variable >> is overwritten by STACK_END_MAGIC. In fact, the ARCH_TASK_STRUCT_ON_STACK >> is not a real task on stack,

Re: [PATCH 1/1] sched/headers: fix thread_info. is overwritten by STACK_END_MAGIC

2018-11-27 Thread Wang, Dongsheng
Hello Kees, On 2018/11/28 6:38, Kees Cook wrote: > On Thu, Nov 22, 2018 at 11:54 PM, Wang Dongsheng > wrote: >> When select ARCH_TASK_STRUCT_ON_STACK the first of thread_info variable >> is overwritten by STACK_END_MAGIC. In fact, the ARCH_TASK_STRUCT_ON_STACK >> is not a real task on stack,

Re: [PATCH 1/1] sched/headers: fix thread_info. is overwritten by STACK_END_MAGIC

2018-11-27 Thread Kees Cook
On Thu, Nov 22, 2018 at 11:54 PM, Wang Dongsheng wrote: > When select ARCH_TASK_STRUCT_ON_STACK the first of thread_info variable > is overwritten by STACK_END_MAGIC. In fact, the ARCH_TASK_STRUCT_ON_STACK > is not a real task on stack, it's only init_task on init_stack. > > Commit 0500871f21b2

Re: [PATCH 1/1] sched/headers: fix thread_info. is overwritten by STACK_END_MAGIC

2018-11-27 Thread Kees Cook
On Thu, Nov 22, 2018 at 11:54 PM, Wang Dongsheng wrote: > When select ARCH_TASK_STRUCT_ON_STACK the first of thread_info variable > is overwritten by STACK_END_MAGIC. In fact, the ARCH_TASK_STRUCT_ON_STACK > is not a real task on stack, it's only init_task on init_stack. > > Commit 0500871f21b2

[PATCH 1/1] sched/headers: fix thread_info. is overwritten by STACK_END_MAGIC

2018-11-22 Thread Wang Dongsheng
When select ARCH_TASK_STRUCT_ON_STACK the first of thread_info variable is overwritten by STACK_END_MAGIC. In fact, the ARCH_TASK_STRUCT_ON_STACK is not a real task on stack, it's only init_task on init_stack. Commit 0500871f21b2 ("Construct init thread stack in the linker script rather than by

[PATCH 1/1] sched/headers: fix thread_info. is overwritten by STACK_END_MAGIC

2018-11-22 Thread Wang Dongsheng
When select ARCH_TASK_STRUCT_ON_STACK the first of thread_info variable is overwritten by STACK_END_MAGIC. In fact, the ARCH_TASK_STRUCT_ON_STACK is not a real task on stack, it's only init_task on init_stack. Commit 0500871f21b2 ("Construct init thread stack in the linker script rather than by