Re: [PATCH 1/1] staging: iio: cdc: fix improper return value

2016-12-04 Thread Jonathan Cameron
On 03/12/16 13:44, Pan Bian wrote: > From: Pan Bian > > At the end of function ad7150_write_event_config(), directly returns 0. > As a result, the errors will be ignored by the callers. It may be better > to return variable "ret". > > Signed-off-by: Pan Bian

Re: [PATCH 1/1] staging: iio: cdc: fix improper return value

2016-12-04 Thread Jonathan Cameron
On 03/12/16 13:44, Pan Bian wrote: > From: Pan Bian > > At the end of function ad7150_write_event_config(), directly returns 0. > As a result, the errors will be ignored by the callers. It may be better > to return variable "ret". > > Signed-off-by: Pan Bian Applied to the togreg branch of

[PATCH 1/1] staging: iio: cdc: fix improper return value

2016-12-03 Thread Pan Bian
From: Pan Bian At the end of function ad7150_write_event_config(), directly returns 0. As a result, the errors will be ignored by the callers. It may be better to return variable "ret". Signed-off-by: Pan Bian --- drivers/staging/iio/cdc/ad7150.c | 2

[PATCH 1/1] staging: iio: cdc: fix improper return value

2016-12-03 Thread Pan Bian
From: Pan Bian At the end of function ad7150_write_event_config(), directly returns 0. As a result, the errors will be ignored by the callers. It may be better to return variable "ret". Signed-off-by: Pan Bian --- drivers/staging/iio/cdc/ad7150.c | 2 +- 1 file changed, 1 insertion(+), 1