Re: [PATCH 1/1] usb: serial: option: add Quectel EC200T module support

[Johan Hovold]

On Wed, Oct 28, 2020 at 08:34:09AM +0800, Ziyi Cao wrote:
> Hi Johan:
> 
> `lsusb -d 2c7c:6026 -v` dump, in attachment file.

Thank you, I've applied the patch now.

Johan

Re: [PATCH 1/1] usb: serial: option: add Quectel EC200T module support

[Ziyi Cao]

Hi Johan:

`lsusb -d 2c7c:6026 -v` dump, in attachment file.

Thanks.

On Tue, Oct 27, 2020, at 16:43, Johan Hovold wrote:
> On Tue, Oct 20, 2020 at 12:08:06AM +0800, Ziyi Cao wrote:
> > Add usb product id of the Quectel EC200T module.
> > 
> > Signed-off-by: Ziyi Cao 
> > ---
> 
> For reference, can you provide the output of "lsusb -v" for this device?
> 
> Johan
>
Bus 001 Device 006: ID 2c7c:6026 Quectel Wireless Solutions Co., Ltd. Android
Device Descriptor:
  bLength18
  bDescriptorType 1
  bcdUSB   2.00
  bDeviceClass  239 Miscellaneous Device
  bDeviceSubClass 2 
  bDeviceProtocol 1 Interface Association
  bMaxPacketSize064
  idVendor   0x2c7c Quectel Wireless Solutions Co., Ltd.
  idProduct  0x6026 
  bcdDevice3.18
  iManufacturer   1 
  iProduct2 
  iSerial 3 
  bNumConfigurations  1
  Configuration Descriptor:
bLength 9
bDescriptorType 2
wTotalLength   0x00d1
bNumInterfaces  5
bConfigurationValue 1
iConfiguration  0 
bmAttributes 0xe0
  Self Powered
  Remote Wakeup
MaxPower  500mA
Interface Association:
  bLength 8
  bDescriptorType11
  bFirstInterface 0
  bInterfaceCount 2
  bFunctionClass  2 Communications
  bFunctionSubClass   6 Ethernet Networking
  bFunctionProtocol   0 
  iFunction   5 
Interface Descriptor:
  bLength 9
  bDescriptorType 4
  bInterfaceNumber0
  bAlternateSetting   0
  bNumEndpoints   1
  bInterfaceClass 2 Communications
  bInterfaceSubClass  6 Ethernet Networking
  bInterfaceProtocol  0 
  iInterface  5 
  CDC Header:
bcdCDC   1.10
  CDC Ethernet:
iMacAddress 14 (??)
bmEthernetStatistics0x
wMaxSegmentSize   1544
wNumberMCFilters0x0001
bNumberPowerFilters  0
  CDC Union:
bMasterInterface0
bSlaveInterface 1 
  Endpoint Descriptor:
bLength 7
bDescriptorType 5
bEndpointAddress 0x85  EP 5 IN
bmAttributes3
  Transfer TypeInterrupt
  Synch Type   None
  Usage Type   Data
wMaxPacketSize 0x0040  1x 64 bytes
bInterval  16
Interface Descriptor:
  bLength 9
  bDescriptorType 4
  bInterfaceNumber1
  bAlternateSetting   0
  bNumEndpoints   0
  bInterfaceClass10 CDC Data
  bInterfaceSubClass  0 
  bInterfaceProtocol  0 
  iInterface  5 
Interface Descriptor:
  bLength 9
  bDescriptorType 4
  bInterfaceNumber1
  bAlternateSetting   1
  bNumEndpoints   2
  bInterfaceClass10 CDC Data
  bInterfaceSubClass  0 
  bInterfaceProtocol  0 
  iInterface  0 
  Endpoint Descriptor:
bLength 7
bDescriptorType 5
bEndpointAddress 0x87  EP 7 IN
bmAttributes2
  Transfer TypeBulk
  Synch Type   None
  Usage Type   Data
wMaxPacketSize 0x0200  1x 512 bytes
bInterval   0
  Endpoint Descriptor:
bLength 7
bDescriptorType 5
bEndpointAddress 0x06  EP 6 OUT
bmAttributes2
  Transfer TypeBulk
  Synch Type   None
  Usage Type   Data
wMaxPacketSize 0x0200  1x 512 bytes
bInterval   0
Interface Descriptor:
  bLength 9
  bDescriptorType 4
  bInterfaceNumber2
  bAlternateSetting   0
  bNumEndpoints   2
  bInterfaceClass   255 Vendor Specific Class
  bInterfaceSubClass  0 
  bInterfaceProtocol  0 
  iInterface  8 
  Endpoint Descriptor:
bLength 7
bDescriptorType 5
bEndpointAddress 0x84  EP 4 IN
bmAttributes2
  Transfer TypeBulk
  Synch Type   None
  Usage Type   Data
wMaxPacketSize 0x0200  1x 512 bytes
bInterval   0
  Endpoint Descriptor:
bLength 7
bDescriptorType 5
bEndpointAddress 0x03  EP 3 OUT
bmAttributes2
  Transfer Type 

Re: [PATCH 1/1] usb: serial: option: add Quectel EC200T module support

[Johan Hovold]

On Tue, Oct 20, 2020 at 12:08:06AM +0800, Ziyi Cao wrote:
> Add usb product id of the Quectel EC200T module.
> 
> Signed-off-by: Ziyi Cao 
> ---

For reference, can you provide the output of "lsusb -v" for this device?

Johan

Re: [PATCH 1/1] usb: serial: option: add Quectel EC200T module support

[Greg Kroah-Hartman]

On Thu, Oct 22, 2020 at 12:05:55AM +0800, Ziyi Cao wrote:
> Request to accept this patch, thanks.
> 
> On Tue, Oct 20, 2020, at 00:08, Ziyi Cao wrote:

It's been less than days, in the middle of the merge window, when we are
all totally busy and we can't take patches anyway.

Please relax, there is no rush.  If, after 2 weeks of not hearing
anything, then it is ok to ask what is up with a patch, or to resend it.

But to top-post after 1 1/2 days?  That's a recipe to get your patch
ignored :(

thanks,

greg k-h

Re: [PATCH 1/1] usb: serial: option: add Quectel EC200T module support

[Ziyi Cao]

Request to accept this patch, thanks.

On Tue, Oct 20, 2020, at 00:08, Ziyi Cao wrote:
> Add usb product id of the Quectel EC200T module.
> 
> Signed-off-by: Ziyi Cao 
> ---
>  drivers/usb/serial/option.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
> index 2a3bfd6f8..7e879233b 100644
> --- a/drivers/usb/serial/option.c
> +++ b/drivers/usb/serial/option.c
> @@ -250,6 +250,7 @@ static void option_instat_callback(struct urb *urb);
>  #define QUECTEL_PRODUCT_EP06 0x0306
>  #define QUECTEL_PRODUCT_EM12 0x0512
>  #define QUECTEL_PRODUCT_RM500Q   0x0800
> +#define QUECTEL_PRODUCT_EC200T   0x6026
>  
>  #define CMOTECH_VENDOR_ID0x16d8
>  #define CMOTECH_PRODUCT_6001 0x6001
> @@ -1117,6 +1118,7 @@ static const struct usb_device_id option_ids[] = {
>   { USB_DEVICE_AND_INTERFACE_INFO(QUECTEL_VENDOR_ID, 
> QUECTEL_PRODUCT_RM500Q, 0xff, 0, 0) },
>   { USB_DEVICE_AND_INTERFACE_INFO(QUECTEL_VENDOR_ID, 
> QUECTEL_PRODUCT_RM500Q, 0xff, 0xff, 0x10),
> .driver_info = ZLP },
> + { USB_DEVICE_AND_INTERFACE_INFO(QUECTEL_VENDOR_ID, 
> QUECTEL_PRODUCT_EC200T, 0xff, 0, 0) },
>  
>   { USB_DEVICE(CMOTECH_VENDOR_ID, CMOTECH_PRODUCT_6001) },
>   { USB_DEVICE(CMOTECH_VENDOR_ID, CMOTECH_PRODUCT_CMU_300) },
> -- 
> 2.25.1
>

[PATCH 1/1] usb: serial: option: add Quectel EC200T module support

[Ziyi Cao]

Add usb product id of the Quectel EC200T module.

Signed-off-by: Ziyi Cao 
---
 drivers/usb/serial/option.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
index 2a3bfd6f8..7e879233b 100644
--- a/drivers/usb/serial/option.c
+++ b/drivers/usb/serial/option.c
@@ -250,6 +250,7 @@ static void option_instat_callback(struct urb *urb);
 #define QUECTEL_PRODUCT_EP06   0x0306
 #define QUECTEL_PRODUCT_EM12   0x0512
 #define QUECTEL_PRODUCT_RM500Q 0x0800
+#define QUECTEL_PRODUCT_EC200T 0x6026
 
 #define CMOTECH_VENDOR_ID  0x16d8
 #define CMOTECH_PRODUCT_6001   0x6001
@@ -1117,6 +1118,7 @@ static const struct usb_device_id option_ids[] = {
{ USB_DEVICE_AND_INTERFACE_INFO(QUECTEL_VENDOR_ID, 
QUECTEL_PRODUCT_RM500Q, 0xff, 0, 0) },
{ USB_DEVICE_AND_INTERFACE_INFO(QUECTEL_VENDOR_ID, 
QUECTEL_PRODUCT_RM500Q, 0xff, 0xff, 0x10),
  .driver_info = ZLP },
+   { USB_DEVICE_AND_INTERFACE_INFO(QUECTEL_VENDOR_ID, 
QUECTEL_PRODUCT_EC200T, 0xff, 0, 0) },
 
{ USB_DEVICE(CMOTECH_VENDOR_ID, CMOTECH_PRODUCT_6001) },
{ USB_DEVICE(CMOTECH_VENDOR_ID, CMOTECH_PRODUCT_CMU_300) },
-- 
2.25.1

Re: [PATCH 1/1] usb: serial: option: add Quectel EC200T module support

[Greg Kroah-Hartman]

On Mon, Oct 19, 2020 at 01:07:10AM +0800, septs wrote:
> Add usb product id of the Quectel EC200T module.
> 
> Signed-off-by: septs 

Also, this address doesn't match your "From:" line, which means we can't
take it anyway.

Re: [PATCH 1/1] usb: serial: option: add Quectel EC200T module support

[Greg Kroah-Hartman]

On Mon, Oct 19, 2020 at 01:07:10AM +0800, septs wrote:
> Add usb product id of the Quectel EC200T module.
> 
> Signed-off-by: septs 

As my bot said before, you need to use your "legal name" here.  Is this
how you sign documents?  If so, that's fine, but I have to ask.

thanks,

greg k-h

Re: [PATCH 1/1] usb: serial: option: add Quectel EC200T module support

[septs]

Add usb product id of the Quectel EC200T module.

Signed-off-by: septs 
---
 drivers/usb/serial/option.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
index 2a3bfd6f8..7e879233b 100644
--- a/drivers/usb/serial/option.c
+++ b/drivers/usb/serial/option.c
@@ -250,6 +250,7 @@ static void option_instat_callback(struct urb *urb);
 #define QUECTEL_PRODUCT_EP06   0x0306
 #define QUECTEL_PRODUCT_EM12   0x0512
 #define QUECTEL_PRODUCT_RM500Q 0x0800
+#define QUECTEL_PRODUCT_EC200T 0x6026
 
 #define CMOTECH_VENDOR_ID  0x16d8
 #define CMOTECH_PRODUCT_6001   0x6001
@@ -1117,6 +1118,7 @@ static const struct usb_device_id option_ids[] = {
{ USB_DEVICE_AND_INTERFACE_INFO(QUECTEL_VENDOR_ID, 
QUECTEL_PRODUCT_RM500Q, 0xff, 0, 0) },
{ USB_DEVICE_AND_INTERFACE_INFO(QUECTEL_VENDOR_ID, 
QUECTEL_PRODUCT_RM500Q, 0xff, 0xff, 0x10),
  .driver_info = ZLP },
+   { USB_DEVICE_AND_INTERFACE_INFO(QUECTEL_VENDOR_ID, 
QUECTEL_PRODUCT_EC200T, 0xff, 0, 0) },
 
{ USB_DEVICE(CMOTECH_VENDOR_ID, CMOTECH_PRODUCT_6001) },
{ USB_DEVICE(CMOTECH_VENDOR_ID, CMOTECH_PRODUCT_CMU_300) },
-- 
2.25.1


On Sun, Oct 18, 2020, at 20:49, Greg Kroah-Hartman wrote:
> On Sun, Oct 18, 2020 at 06:51:11PM +0800, septs wrote:
> > Add usb product id of the Quectel EC200T module.
> > ---
> >  drivers/usb/serial/option.c | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
> > index 2a3bfd6f8..7e879233b 100644
> > --- a/drivers/usb/serial/option.c
> > +++ b/drivers/usb/serial/option.c
> > @@ -250,6 +250,7 @@ static void option_instat_callback(struct urb *urb);
> >  #define QUECTEL_PRODUCT_EP06   0x0306
> >  #define QUECTEL_PRODUCT_EM12   0x0512
> >  #define QUECTEL_PRODUCT_RM500Q 0x0800
> > +#define QUECTEL_PRODUCT_EC200T 0x6026
> >  
> >  #define CMOTECH_VENDOR_ID  0x16d8
> >  #define CMOTECH_PRODUCT_6001   0x6001
> > @@ -1117,6 +1118,7 @@ static const struct usb_device_id option_ids[] = {
> > { USB_DEVICE_AND_INTERFACE_INFO(QUECTEL_VENDOR_ID, 
> > QUECTEL_PRODUCT_RM500Q, 0xff, 0, 0) },
> > { USB_DEVICE_AND_INTERFACE_INFO(QUECTEL_VENDOR_ID, 
> > QUECTEL_PRODUCT_RM500Q, 0xff, 0xff, 0x10),
> >   .driver_info = ZLP },
> > +   { USB_DEVICE_AND_INTERFACE_INFO(QUECTEL_VENDOR_ID, 
> > QUECTEL_PRODUCT_EC200T, 0xff, 0, 0) },
> >  
> > { USB_DEVICE(CMOTECH_VENDOR_ID, CMOTECH_PRODUCT_6001) },
> > { USB_DEVICE(CMOTECH_VENDOR_ID, CMOTECH_PRODUCT_CMU_300) },
> > -- 
> > 2.25.1
> > 
> 
> Hi,
> 
> This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
> a patch that has triggered this response.  He used to manually respond
> to these common problems, but in order to save his sanity (he kept
> writing the same thing over and over, yet to different people), I was
> created.  Hopefully you will not take offence and will fix the problem
> in your patch and resubmit it so that it can be accepted into the Linux
> kernel tree.
> 
> You are receiving this message because of the following common error(s)
> as indicated below:
> 
> - Your patch does not have a Signed-off-by: line.  Please read the
>   kernel file, Documentation/SubmittingPatches and resend it after
>   adding that line.  Note, the line needs to be in the body of the
>   email, before the patch, not at the bottom of the patch or in the
>   email signature.
> 
> 
> - It looks like you did not use your "real" name for the patch on either
>   the Signed-off-by: line, or the From: line (both of which have to
>   match).  Please read the kernel file, Documentation/SubmittingPatches
>   for how to do this correctly.
> 
> If you wish to discuss this problem further, or you have questions about
> how to resolve this issue, please feel free to respond to this email and
> Greg will reply once he has dug out from the pending patches received
> from other developers.
> 
> thanks,
> 
> greg k-h's patch email bot
>

Re: [PATCH 1/1] usb: serial: option: add Quectel EC200T module support

[Greg Kroah-Hartman]

On Sun, Oct 18, 2020 at 06:51:11PM +0800, septs wrote:
> Add usb product id of the Quectel EC200T module.
> ---
>  drivers/usb/serial/option.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
> index 2a3bfd6f8..7e879233b 100644
> --- a/drivers/usb/serial/option.c
> +++ b/drivers/usb/serial/option.c
> @@ -250,6 +250,7 @@ static void option_instat_callback(struct urb *urb);
>  #define QUECTEL_PRODUCT_EP06 0x0306
>  #define QUECTEL_PRODUCT_EM12 0x0512
>  #define QUECTEL_PRODUCT_RM500Q   0x0800
> +#define QUECTEL_PRODUCT_EC200T   0x6026
>  
>  #define CMOTECH_VENDOR_ID0x16d8
>  #define CMOTECH_PRODUCT_6001 0x6001
> @@ -1117,6 +1118,7 @@ static const struct usb_device_id option_ids[] = {
>   { USB_DEVICE_AND_INTERFACE_INFO(QUECTEL_VENDOR_ID, 
> QUECTEL_PRODUCT_RM500Q, 0xff, 0, 0) },
>   { USB_DEVICE_AND_INTERFACE_INFO(QUECTEL_VENDOR_ID, 
> QUECTEL_PRODUCT_RM500Q, 0xff, 0xff, 0x10),
> .driver_info = ZLP },
> + { USB_DEVICE_AND_INTERFACE_INFO(QUECTEL_VENDOR_ID, 
> QUECTEL_PRODUCT_EC200T, 0xff, 0, 0) },
>  
>   { USB_DEVICE(CMOTECH_VENDOR_ID, CMOTECH_PRODUCT_6001) },
>   { USB_DEVICE(CMOTECH_VENDOR_ID, CMOTECH_PRODUCT_CMU_300) },
> -- 
> 2.25.1
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- Your patch does not have a Signed-off-by: line.  Please read the
  kernel file, Documentation/SubmittingPatches and resend it after
  adding that line.  Note, the line needs to be in the body of the
  email, before the patch, not at the bottom of the patch or in the
  email signature.


- It looks like you did not use your "real" name for the patch on either
  the Signed-off-by: line, or the From: line (both of which have to
  match).  Please read the kernel file, Documentation/SubmittingPatches
  for how to do this correctly.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot

[PATCH 1/1] usb: serial: option: add Quectel EC200T module support

[septs]

Add usb product id of the Quectel EC200T module.
---
 drivers/usb/serial/option.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
index 2a3bfd6f8..7e879233b 100644
--- a/drivers/usb/serial/option.c
+++ b/drivers/usb/serial/option.c
@@ -250,6 +250,7 @@ static void option_instat_callback(struct urb *urb);
 #define QUECTEL_PRODUCT_EP06   0x0306
 #define QUECTEL_PRODUCT_EM12   0x0512
 #define QUECTEL_PRODUCT_RM500Q 0x0800
+#define QUECTEL_PRODUCT_EC200T 0x6026
 
 #define CMOTECH_VENDOR_ID  0x16d8
 #define CMOTECH_PRODUCT_6001   0x6001
@@ -1117,6 +1118,7 @@ static const struct usb_device_id option_ids[] = {
{ USB_DEVICE_AND_INTERFACE_INFO(QUECTEL_VENDOR_ID, 
QUECTEL_PRODUCT_RM500Q, 0xff, 0, 0) },
{ USB_DEVICE_AND_INTERFACE_INFO(QUECTEL_VENDOR_ID, 
QUECTEL_PRODUCT_RM500Q, 0xff, 0xff, 0x10),
  .driver_info = ZLP },
+   { USB_DEVICE_AND_INTERFACE_INFO(QUECTEL_VENDOR_ID, 
QUECTEL_PRODUCT_EC200T, 0xff, 0, 0) },
 
{ USB_DEVICE(CMOTECH_VENDOR_ID, CMOTECH_PRODUCT_6001) },
{ USB_DEVICE(CMOTECH_VENDOR_ID, CMOTECH_PRODUCT_CMU_300) },
-- 
2.25.1