Re: [PATCH 1/1] vhost: Added pad cleanup if vnet_hdr is not present.

2024-02-26 Thread Andrew Melnichenko
Hi all, Ok, let me prepare a new patch v2, where I'll write a description/analysis of the issue in the commit message. On Thu, Feb 22, 2024 at 10:02 PM Michael S. Tsirkin wrote: > > On Mon, Jan 15, 2024 at 05:32:25PM -0500, Michael S. Tsirkin wrote: > > On Mon, Jan 15, 2024 at 09:48:40PM +0200,

Re: [PATCH 1/1] vhost: Added pad cleanup if vnet_hdr is not present.

2024-02-22 Thread Michael S. Tsirkin
On Mon, Jan 15, 2024 at 05:32:25PM -0500, Michael S. Tsirkin wrote: > On Mon, Jan 15, 2024 at 09:48:40PM +0200, Andrew Melnychenko wrote: > > When the Qemu launched with vhost but without tap vnet_hdr, > > vhost tries to copy vnet_hdr from socket iter with size 0 > > to the page that may contain

Re: [PATCH 1/1] vhost: Added pad cleanup if vnet_hdr is not present.

2024-02-08 Thread Yuri Benditovich
Just polite ping On Tue, Jan 16, 2024 at 12:32 AM Michael S. Tsirkin wrote: > > On Mon, Jan 15, 2024 at 09:48:40PM +0200, Andrew Melnychenko wrote: > > When the Qemu launched with vhost but without tap vnet_hdr, > > vhost tries to copy vnet_hdr from socket iter with size 0 > > to the page that

Re: [PATCH 1/1] vhost: Added pad cleanup if vnet_hdr is not present.

2024-01-15 Thread Michael S. Tsirkin
On Mon, Jan 15, 2024 at 09:48:40PM +0200, Andrew Melnychenko wrote: > When the Qemu launched with vhost but without tap vnet_hdr, > vhost tries to copy vnet_hdr from socket iter with size 0 > to the page that may contain some trash. > That trash can be interpreted as unpredictable values for >

Re: [PATCH 1/1] vhost: Added pad cleanup if vnet_hdr is not present.

2024-01-15 Thread Yuri Benditovich
See also https://issues.redhat.com/browse/RHEL-1303 On Mon, Jan 15, 2024 at 9:48 PM Andrew Melnychenko wrote: > > When the Qemu launched with vhost but without tap vnet_hdr, > vhost tries to copy vnet_hdr from socket iter with size 0 > to the page that may contain some trash. > That trash can

[PATCH 1/1] vhost: Added pad cleanup if vnet_hdr is not present.

2024-01-15 Thread Andrew Melnychenko
When the Qemu launched with vhost but without tap vnet_hdr, vhost tries to copy vnet_hdr from socket iter with size 0 to the page that may contain some trash. That trash can be interpreted as unpredictable values for vnet_hdr. That leads to dropping some packets and in some cases to stalling vhost