Re: [PATCH 1/2] ARM: dts: Add the CLCD controller to Cygnus.

2017-09-02 Thread Florian Fainelli 


On 09/02/2017 08:48 AM, Scott Branden wrote:
> Looks good
> 
> On Sep 1, 2017 7:10 PM, "Florian Fainelli"  > wrote:
> 
> 
> 
> On 08/31/2017 01:16 PM, Scott Branden wrote:
> > Hi Eric,
> >
> > mode is correct, location in file needs to be moved.
> >
> >
> > On 17-08-31 11:54 AM, Eric Anholt wrote:
> >> This doesn't yet enable it on any particular platform, as we still
> >> need a panel driver for bcm911360_entphn.
> >>
> >> Signed-off-by: Eric Anholt >
> >> ---
> >>
> >> These bits are just carving off a little bit of my 911360_entphn
> panel
> >> series, to reduce conflicts when rebasing (which I just did for
> >> testing pl111 changes for cygnus regressions).  I'm waiting to get my
> >> current RPi panel driver in before working on the 911360 panel again.
> >>
> >>   arch/arm/boot/dts/bcm-cygnus.dtsi | 10 ++
> >>   1 file changed, 10 insertions(+)
> >>
> >> diff --git a/arch/arm/boot/dts/bcm-cygnus.dtsi
> >> b/arch/arm/boot/dts/bcm-cygnus.dtsi
> >> index 7c957ea06c66..74f73ff24aec 100644
> >> --- a/arch/arm/boot/dts/bcm-cygnus.dtsi
> >> +++ b/arch/arm/boot/dts/bcm-cygnus.dtsi
> >> @@ -575,6 +575,16 @@
> >>   status = "disabled";
> >>   };
> >>   +clcd: clcd@180a {
> > please place in correct address ordered location in file
> 
> I moved it right above the v3d node to keep the nodes ordered by unit
> address, please check the result here:
> 
> 
> https://github.com/Broadcom/stblinux/commit/4d1e42c6b9d28ce7b74d92258435f9d16834ae75
> 
> 
> 
> 
> With Moved location
> Acked-by: Scott Branden  >

Pushed in place with your tag added, thanks!
-- 
Florian

Re: [PATCH 1/2] ARM: dts: Add the CLCD controller to Cygnus.

2017-09-02 Thread Florian Fainelli 


On 09/02/2017 08:48 AM, Scott Branden wrote:
> Looks good
> 
> On Sep 1, 2017 7:10 PM, "Florian Fainelli"  > wrote:
> 
> 
> 
> On 08/31/2017 01:16 PM, Scott Branden wrote:
> > Hi Eric,
> >
> > mode is correct, location in file needs to be moved.
> >
> >
> > On 17-08-31 11:54 AM, Eric Anholt wrote:
> >> This doesn't yet enable it on any particular platform, as we still
> >> need a panel driver for bcm911360_entphn.
> >>
> >> Signed-off-by: Eric Anholt mailto:e...@anholt.net>>
> >> ---
> >>
> >> These bits are just carving off a little bit of my 911360_entphn
> panel
> >> series, to reduce conflicts when rebasing (which I just did for
> >> testing pl111 changes for cygnus regressions).  I'm waiting to get my
> >> current RPi panel driver in before working on the 911360 panel again.
> >>
> >>   arch/arm/boot/dts/bcm-cygnus.dtsi | 10 ++
> >>   1 file changed, 10 insertions(+)
> >>
> >> diff --git a/arch/arm/boot/dts/bcm-cygnus.dtsi
> >> b/arch/arm/boot/dts/bcm-cygnus.dtsi
> >> index 7c957ea06c66..74f73ff24aec 100644
> >> --- a/arch/arm/boot/dts/bcm-cygnus.dtsi
> >> +++ b/arch/arm/boot/dts/bcm-cygnus.dtsi
> >> @@ -575,6 +575,16 @@
> >>   status = "disabled";
> >>   };
> >>   +clcd: clcd@180a {
> > please place in correct address ordered location in file
> 
> I moved it right above the v3d node to keep the nodes ordered by unit
> address, please check the result here:
> 
> 
> https://github.com/Broadcom/stblinux/commit/4d1e42c6b9d28ce7b74d92258435f9d16834ae75
> 
> 
> 
> 
> With Moved location
> Acked-by: Scott Branden  >

Pushed in place with your tag added, thanks!
-- 
Florian

Re: [PATCH 1/2] ARM: dts: Add the CLCD controller to Cygnus.

2017-09-01 Thread Florian Fainelli 


On 08/31/2017 01:16 PM, Scott Branden wrote:
> Hi Eric,
> 
> mode is correct, location in file needs to be moved.
> 
> 
> On 17-08-31 11:54 AM, Eric Anholt wrote:
>> This doesn't yet enable it on any particular platform, as we still
>> need a panel driver for bcm911360_entphn.
>>
>> Signed-off-by: Eric Anholt 
>> ---
>>
>> These bits are just carving off a little bit of my 911360_entphn panel
>> series, to reduce conflicts when rebasing (which I just did for
>> testing pl111 changes for cygnus regressions).  I'm waiting to get my
>> current RPi panel driver in before working on the 911360 panel again.
>>
>>   arch/arm/boot/dts/bcm-cygnus.dtsi | 10 ++
>>   1 file changed, 10 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/bcm-cygnus.dtsi
>> b/arch/arm/boot/dts/bcm-cygnus.dtsi
>> index 7c957ea06c66..74f73ff24aec 100644
>> --- a/arch/arm/boot/dts/bcm-cygnus.dtsi
>> +++ b/arch/arm/boot/dts/bcm-cygnus.dtsi
>> @@ -575,6 +575,16 @@
>>   status = "disabled";
>>   };
>>   +clcd: clcd@180a {
> please place in correct address ordered location in file

I moved it right above the v3d node to keep the nodes ordered by unit
address, please check the result here:

https://github.com/Broadcom/stblinux/commit/4d1e42c6b9d28ce7b74d92258435f9d16834ae75

>> +compatible = "arm,pl111", "arm,primecell";
>> +reg = <0x180a 0x1000>;
>> +interrupts = ;
>> +interrupt-names = "combined";
>> +clocks = <_clk>, <_clk>;
>> +clock-names = "clcdclk", "apb_pclk";
>> +status = "disabled";
>> +};
>> +
>>   keypad: keypad@180ac000 {
>>   compatible = "brcm,bcm-keypad";
>>   reg = <0x180ac000 0x14c>;
> 

-- 
Florian

Re: [PATCH 1/2] ARM: dts: Add the CLCD controller to Cygnus.

2017-09-01 Thread Florian Fainelli 


On 08/31/2017 01:16 PM, Scott Branden wrote:
> Hi Eric,
> 
> mode is correct, location in file needs to be moved.
> 
> 
> On 17-08-31 11:54 AM, Eric Anholt wrote:
>> This doesn't yet enable it on any particular platform, as we still
>> need a panel driver for bcm911360_entphn.
>>
>> Signed-off-by: Eric Anholt 
>> ---
>>
>> These bits are just carving off a little bit of my 911360_entphn panel
>> series, to reduce conflicts when rebasing (which I just did for
>> testing pl111 changes for cygnus regressions).  I'm waiting to get my
>> current RPi panel driver in before working on the 911360 panel again.
>>
>>   arch/arm/boot/dts/bcm-cygnus.dtsi | 10 ++
>>   1 file changed, 10 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/bcm-cygnus.dtsi
>> b/arch/arm/boot/dts/bcm-cygnus.dtsi
>> index 7c957ea06c66..74f73ff24aec 100644
>> --- a/arch/arm/boot/dts/bcm-cygnus.dtsi
>> +++ b/arch/arm/boot/dts/bcm-cygnus.dtsi
>> @@ -575,6 +575,16 @@
>>   status = "disabled";
>>   };
>>   +clcd: clcd@180a {
> please place in correct address ordered location in file

I moved it right above the v3d node to keep the nodes ordered by unit
address, please check the result here:

https://github.com/Broadcom/stblinux/commit/4d1e42c6b9d28ce7b74d92258435f9d16834ae75

>> +compatible = "arm,pl111", "arm,primecell";
>> +reg = <0x180a 0x1000>;
>> +interrupts = ;
>> +interrupt-names = "combined";
>> +clocks = <_clk>, <_clk>;
>> +clock-names = "clcdclk", "apb_pclk";
>> +status = "disabled";
>> +};
>> +
>>   keypad: keypad@180ac000 {
>>   compatible = "brcm,bcm-keypad";
>>   reg = <0x180ac000 0x14c>;
> 

-- 
Florian

Re: [PATCH 1/2] ARM: dts: Add the CLCD controller to Cygnus.

2017-08-31 Thread Scott Branden 

Hi Eric,

mode is correct, location in file needs to be moved.


On 17-08-31 11:54 AM, Eric Anholt wrote:

This doesn't yet enable it on any particular platform, as we still
need a panel driver for bcm911360_entphn.

Signed-off-by: Eric Anholt 
---

These bits are just carving off a little bit of my 911360_entphn panel
series, to reduce conflicts when rebasing (which I just did for
testing pl111 changes for cygnus regressions).  I'm waiting to get my
current RPi panel driver in before working on the 911360 panel again.

  arch/arm/boot/dts/bcm-cygnus.dtsi | 10 ++
  1 file changed, 10 insertions(+)

diff --git a/arch/arm/boot/dts/bcm-cygnus.dtsi 
b/arch/arm/boot/dts/bcm-cygnus.dtsi
index 7c957ea06c66..74f73ff24aec 100644
--- a/arch/arm/boot/dts/bcm-cygnus.dtsi
+++ b/arch/arm/boot/dts/bcm-cygnus.dtsi
@@ -575,6 +575,16 @@
status = "disabled";
};
  
+		clcd: clcd@180a {

please place in correct address ordered location in file

+   compatible = "arm,pl111", "arm,primecell";
+   reg = <0x180a 0x1000>;
+   interrupts = ;
+   interrupt-names = "combined";
+   clocks = <_clk>, <_clk>;
+   clock-names = "clcdclk", "apb_pclk";
+   status = "disabled";
+   };
+
keypad: keypad@180ac000 {
compatible = "brcm,bcm-keypad";
reg = <0x180ac000 0x14c>;

Re: [PATCH 1/2] ARM: dts: Add the CLCD controller to Cygnus.

2017-08-31 Thread Scott Branden 

Hi Eric,

mode is correct, location in file needs to be moved.


On 17-08-31 11:54 AM, Eric Anholt wrote:

This doesn't yet enable it on any particular platform, as we still
need a panel driver for bcm911360_entphn.

Signed-off-by: Eric Anholt 
---

These bits are just carving off a little bit of my 911360_entphn panel
series, to reduce conflicts when rebasing (which I just did for
testing pl111 changes for cygnus regressions).  I'm waiting to get my
current RPi panel driver in before working on the 911360 panel again.

  arch/arm/boot/dts/bcm-cygnus.dtsi | 10 ++
  1 file changed, 10 insertions(+)

diff --git a/arch/arm/boot/dts/bcm-cygnus.dtsi 
b/arch/arm/boot/dts/bcm-cygnus.dtsi
index 7c957ea06c66..74f73ff24aec 100644
--- a/arch/arm/boot/dts/bcm-cygnus.dtsi
+++ b/arch/arm/boot/dts/bcm-cygnus.dtsi
@@ -575,6 +575,16 @@
status = "disabled";
};
  
+		clcd: clcd@180a {

please place in correct address ordered location in file

+   compatible = "arm,pl111", "arm,primecell";
+   reg = <0x180a 0x1000>;
+   interrupts = ;
+   interrupt-names = "combined";
+   clocks = <_clk>, <_clk>;
+   clock-names = "clcdclk", "apb_pclk";
+   status = "disabled";
+   };
+
keypad: keypad@180ac000 {
compatible = "brcm,bcm-keypad";
reg = <0x180ac000 0x14c>;

[PATCH 1/2] ARM: dts: Add the CLCD controller to Cygnus.

2017-08-31 Thread Eric Anholt 
This doesn't yet enable it on any particular platform, as we still
need a panel driver for bcm911360_entphn.

Signed-off-by: Eric Anholt 
---

These bits are just carving off a little bit of my 911360_entphn panel
series, to reduce conflicts when rebasing (which I just did for
testing pl111 changes for cygnus regressions).  I'm waiting to get my
current RPi panel driver in before working on the 911360 panel again.

 arch/arm/boot/dts/bcm-cygnus.dtsi | 10 ++
 1 file changed, 10 insertions(+)

diff --git a/arch/arm/boot/dts/bcm-cygnus.dtsi 
b/arch/arm/boot/dts/bcm-cygnus.dtsi
index 7c957ea06c66..74f73ff24aec 100644
--- a/arch/arm/boot/dts/bcm-cygnus.dtsi
+++ b/arch/arm/boot/dts/bcm-cygnus.dtsi
@@ -575,6 +575,16 @@
status = "disabled";
};
 
+   clcd: clcd@180a {
+   compatible = "arm,pl111", "arm,primecell";
+   reg = <0x180a 0x1000>;
+   interrupts = ;
+   interrupt-names = "combined";
+   clocks = <_clk>, <_clk>;
+   clock-names = "clcdclk", "apb_pclk";
+   status = "disabled";
+   };
+
keypad: keypad@180ac000 {
compatible = "brcm,bcm-keypad";
reg = <0x180ac000 0x14c>;
-- 
2.14.1

[PATCH 1/2] ARM: dts: Add the CLCD controller to Cygnus.

2017-08-31 Thread Eric Anholt 
This doesn't yet enable it on any particular platform, as we still
need a panel driver for bcm911360_entphn.

Signed-off-by: Eric Anholt 
---

These bits are just carving off a little bit of my 911360_entphn panel
series, to reduce conflicts when rebasing (which I just did for
testing pl111 changes for cygnus regressions).  I'm waiting to get my
current RPi panel driver in before working on the 911360 panel again.

 arch/arm/boot/dts/bcm-cygnus.dtsi | 10 ++
 1 file changed, 10 insertions(+)

diff --git a/arch/arm/boot/dts/bcm-cygnus.dtsi 
b/arch/arm/boot/dts/bcm-cygnus.dtsi
index 7c957ea06c66..74f73ff24aec 100644
--- a/arch/arm/boot/dts/bcm-cygnus.dtsi
+++ b/arch/arm/boot/dts/bcm-cygnus.dtsi
@@ -575,6 +575,16 @@
status = "disabled";
};
 
+   clcd: clcd@180a {
+   compatible = "arm,pl111", "arm,primecell";
+   reg = <0x180a 0x1000>;
+   interrupts = ;
+   interrupt-names = "combined";
+   clocks = <_clk>, <_clk>;
+   clock-names = "clcdclk", "apb_pclk";
+   status = "disabled";
+   };
+
keypad: keypad@180ac000 {
compatible = "brcm,bcm-keypad";
reg = <0x180ac000 0x14c>;
-- 
2.14.1