Re: [PATCH 1/2] ASoC: fsl-spdif: big-endian support

2014-02-11 Thread Nicolin Chen
On Tue, Feb 11, 2014 at 03:39:44PM +0800, Xiubo Li-B47053 wrote: > > > > > + - big-endian : If this property is absent, the native endian mode will > > > + be in use as default, or the big endian mode will be in use for all > > > the > > > + device registers. > > > + > > > > @Shawn > >

Re: [PATCH 1/2] ASoC: fsl-spdif: big-endian support

2014-02-11 Thread Nicolin Chen
On Tue, Feb 11, 2014 at 03:39:44PM +0800, Xiubo Li-B47053 wrote: + - big-endian : If this property is absent, the native endian mode will + be in use as default, or the big endian mode will be in use for all the + device registers. + @Shawn Does DT have an existing

RE: [PATCH 1/2] ASoC: fsl-spdif: big-endian support

2014-02-10 Thread li.xi...@freescale.com
> > + - big-endian : If this property is absent, the native endian mode will > > + be in use as default, or the big endian mode will be in use for all the > > + device registers. > > + > > @Shawn > Does DT have an existing approach to determine if the current SoC this IP > uses is BE or

RE: [PATCH 1/2] ASoC: fsl-spdif: big-endian support

2014-02-10 Thread li.xi...@freescale.com
> > + spdif_priv->big_endian = of_property_read_bool(np, "big-endian"); > > + if (spdif_priv->big_endian) > > + fsl_spdif_regmap_config.val_format_endian = REGMAP_ENDIAN_BIG; > > Why not just: > if (of_property_read_bool(np, "big-endian")) >

Re: [PATCH 1/2] ASoC: fsl-spdif: big-endian support

2014-02-10 Thread Nicolin Chen
On Tue, Feb 11, 2014 at 01:41:15PM +0800, Xiubo Li wrote: > For most platforms, the CPU and SPDIF device is in the same endianess > mode. While for the LS1 platform, the CPU is in LE mode and the SPDIF > is in BE mode. > > Signed-off-by: Xiubo Li > Cc: Nicolin Chen > --- >

[PATCH 1/2] ASoC: fsl-spdif: big-endian support

2014-02-10 Thread Xiubo Li
For most platforms, the CPU and SPDIF device is in the same endianess mode. While for the LS1 platform, the CPU is in LE mode and the SPDIF is in BE mode. Signed-off-by: Xiubo Li Cc: Nicolin Chen --- Documentation/devicetree/bindings/sound/fsl,spdif.txt | 4 sound/soc/fsl/fsl_spdif.c

[PATCH 1/2] ASoC: fsl-spdif: big-endian support

2014-02-10 Thread Xiubo Li
For most platforms, the CPU and SPDIF device is in the same endianess mode. While for the LS1 platform, the CPU is in LE mode and the SPDIF is in BE mode. Signed-off-by: Xiubo Li li.xi...@freescale.com Cc: Nicolin Chen guangyu.c...@freescale.com ---

Re: [PATCH 1/2] ASoC: fsl-spdif: big-endian support

2014-02-10 Thread Nicolin Chen
On Tue, Feb 11, 2014 at 01:41:15PM +0800, Xiubo Li wrote: For most platforms, the CPU and SPDIF device is in the same endianess mode. While for the LS1 platform, the CPU is in LE mode and the SPDIF is in BE mode. Signed-off-by: Xiubo Li li.xi...@freescale.com Cc: Nicolin Chen

RE: [PATCH 1/2] ASoC: fsl-spdif: big-endian support

2014-02-10 Thread li.xi...@freescale.com
+ spdif_priv-big_endian = of_property_read_bool(np, big-endian); + if (spdif_priv-big_endian) + fsl_spdif_regmap_config.val_format_endian = REGMAP_ENDIAN_BIG; Why not just: if (of_property_read_bool(np, big-endian))

RE: [PATCH 1/2] ASoC: fsl-spdif: big-endian support

2014-02-10 Thread li.xi...@freescale.com
+ - big-endian : If this property is absent, the native endian mode will + be in use as default, or the big endian mode will be in use for all the + device registers. + @Shawn Does DT have an existing approach to determine if the current SoC this IP uses is BE or LE? I am