Re: [PATCH 1/2] New Driver for IOSF-SB MBI access on Intel SOCs

2013-11-23 Thread One Thousand Gnomes
On Thu, 21 Nov 2013 22:05:56 -0800 "David E. Box" wrote: > +static int iosf_mbi_probe(struct platform_device *pdev) > +{ > + struct resource *mem; > + > + /* Get and map MBI address space */ > + mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); > + iosf_mbi_data.addr =

Re: [PATCH 1/2] New Driver for IOSF-SB MBI access on Intel SOCs

2013-11-23 Thread One Thousand Gnomes
On Thu, 21 Nov 2013 22:05:56 -0800 David E. Box david.e@linux.intel.com wrote: +static int iosf_mbi_probe(struct platform_device *pdev) +{ + struct resource *mem; + + /* Get and map MBI address space */ + mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); +

Re: [PATCH 1/2] New Driver for IOSF-SB MBI access on Intel SOCs

2013-11-22 Thread Matthew Garrett
On Thu, Nov 21, 2013 at 10:05:56PM -0800, David E. Box wrote: > + bool "IOSF-SB MailBox Interface access support for Intel SOC's" Any reason this can't be modular? > diff --git a/arch/x86/kernel/iosf_mbi.c b/arch/x86/kernel/iosf_mbi.c This is effectively a driver, so putting it under

Re: [PATCH 1/2] New Driver for IOSF-SB MBI access on Intel SOCs

2013-11-22 Thread Matthew Garrett
On Thu, Nov 21, 2013 at 10:05:56PM -0800, David E. Box wrote: + bool IOSF-SB MailBox Interface access support for Intel SOC's Any reason this can't be modular? diff --git a/arch/x86/kernel/iosf_mbi.c b/arch/x86/kernel/iosf_mbi.c This is effectively a driver, so putting it under

[PATCH 1/2] New Driver for IOSF-SB MBI access on Intel SOCs

2013-11-21 Thread David E. Box
From: "David E. Box" Current Intel SOC cores use a MailBox Interface (MBI) to provide access to unit devices connected to the system fabric. This driver implements the API required for other kernel drivers to configure the unit registers accessible through this interface. Drivers that will

[PATCH 1/2] New Driver for IOSF-SB MBI access on Intel SOCs

2013-11-21 Thread David E. Box
From: David E. Box david.e@linux.intel.com Current Intel SOC cores use a MailBox Interface (MBI) to provide access to unit devices connected to the system fabric. This driver implements the API required for other kernel drivers to configure the unit registers accessible through this