Re: [PATCH 1/2] PCI: also set up legacy files only after sysfs init

2021-02-05 Thread Daniel Vetter
On Thu, Feb 4, 2021 at 11:24 PM Pali Rohár wrote: > > On Thursday 04 February 2021 15:50:19 Bjorn Helgaas wrote: > > [+cc Oliver, Pali, Krzysztof] > > Just to note that extending or using sysfs_initialized introduces > another race condition into kernel code which results in PCI fatal > errors.

Re: [PATCH 1/2] PCI: also set up legacy files only after sysfs init

2021-02-05 Thread Pali Rohár
On Friday 05 February 2021 10:59:50 Daniel Vetter wrote: > On Thu, Feb 4, 2021 at 11:24 PM Pali Rohár wrote: > > > > On Thursday 04 February 2021 15:50:19 Bjorn Helgaas wrote: > > > [+cc Oliver, Pali, Krzysztof] > > > > Just to note that extending or using sysfs_initialized introduces > > another

Re: [PATCH 1/2] PCI: also set up legacy files only after sysfs init

2021-02-05 Thread Daniel Vetter
On Fri, Feb 5, 2021 at 11:04 AM Pali Rohár wrote: > > On Friday 05 February 2021 10:59:50 Daniel Vetter wrote: > > On Thu, Feb 4, 2021 at 11:24 PM Pali Rohár wrote: > > > > > > On Thursday 04 February 2021 15:50:19 Bjorn Helgaas wrote: > > > > [+cc Oliver, Pali, Krzysztof] > > > > > > Just to

Re: [PATCH 1/2] PCI: also set up legacy files only after sysfs init

2021-02-05 Thread Pali Rohár
On Friday 05 February 2021 11:16:00 Daniel Vetter wrote: > On Fri, Feb 5, 2021 at 11:04 AM Pali Rohár wrote: > > > > On Friday 05 February 2021 10:59:50 Daniel Vetter wrote: > > > On Thu, Feb 4, 2021 at 11:24 PM Pali Rohár wrote: > > > > > > > > On Thursday 04 February 2021 15:50:19 Bjorn

Re: [PATCH 1/2] PCI: also set up legacy files only after sysfs init

2021-02-05 Thread Daniel Vetter
On Thu, Feb 4, 2021 at 10:50 PM Bjorn Helgaas wrote: > > [+cc Oliver, Pali, Krzysztof] > > s/also/Also/ in subject > > On Thu, Feb 04, 2021 at 05:58:30PM +0100, Daniel Vetter wrote: > > We are already doing this for all the regular sysfs files on PCI > > devices, but not yet on the legacy io

Re: [PATCH 1/2] PCI: also set up legacy files only after sysfs init

2021-02-04 Thread Pali Rohár
On Thursday 04 February 2021 15:50:19 Bjorn Helgaas wrote: > [+cc Oliver, Pali, Krzysztof] Just to note that extending or using sysfs_initialized introduces another race condition into kernel code which results in PCI fatal errors. Details are in email discussion which Bjorn already sent. >

Re: [PATCH 1/2] PCI: also set up legacy files only after sysfs init

2021-02-04 Thread Bjorn Helgaas
[+cc Oliver, Pali, Krzysztof] s/also/Also/ in subject On Thu, Feb 04, 2021 at 05:58:30PM +0100, Daniel Vetter wrote: > We are already doing this for all the regular sysfs files on PCI > devices, but not yet on the legacy io files on the PCI buses. Thus far > now problem, but in the next patch I

[PATCH 1/2] PCI: also set up legacy files only after sysfs init

2021-02-04 Thread Daniel Vetter
We are already doing this for all the regular sysfs files on PCI devices, but not yet on the legacy io files on the PCI buses. Thus far now problem, but in the next patch I want to wire up iomem revoke support. That needs the vfs up an running already to make so that iomem_get_mapping() works.