Re: [PATCH 1/2] PCI: controller: thunder: fix compile testing

2021-02-26 Thread Robert Richter
On 25.02.21 15:37:09, Arnd Bergmann wrote: > From: Arnd Bergmann > > Compile-testing these drivers is currently broken. Enabling > it causes a couple of build failures though: > > drivers/pci/controller/pci-thunder-ecam.c:119:30: error: shift count >= width > of type

Re: [PATCH 1/2] PCI: controller: thunder: fix compile testing

2021-02-25 Thread Kuppuswamy, Sathyanarayanan
On 2/25/21 10:51 AM, Bjorn Helgaas wrote: Thanks for looking this over! I'd like to acknowledge your review, but I need an explicit Reviewed-by or similar. I don't want to put words in your mouth by converting "Looks good to me" to "Reviewed-by". will do so in future reviews.

Re: [PATCH 1/2] PCI: controller: thunder: fix compile testing

2021-02-25 Thread Bjorn Helgaas
On Thu, Feb 25, 2021 at 09:44:12AM -0800, Kuppuswamy, Sathyanarayanan wrote: > On 2/25/21 6:37 AM, Arnd Bergmann wrote: > > From: Arnd Bergmann > > > > Compile-testing these drivers is currently broken. Enabling > > it causes a couple of build failures though: > > > >

Re: [PATCH 1/2] PCI: controller: thunder: fix compile testing

2021-02-25 Thread Kuppuswamy, Sathyanarayanan
On 2/25/21 6:37 AM, Arnd Bergmann wrote: From: Arnd Bergmann Compile-testing these drivers is currently broken. Enabling it causes a couple of build failures though: drivers/pci/controller/pci-thunder-ecam.c:119:30: error: shift count >= width of type [-Werror,-Wshift-count-overflow]

[PATCH 1/2] PCI: controller: thunder: fix compile testing

2021-02-25 Thread Arnd Bergmann
From: Arnd Bergmann Compile-testing these drivers is currently broken. Enabling it causes a couple of build failures though: drivers/pci/controller/pci-thunder-ecam.c:119:30: error: shift count >= width of type [-Werror,-Wshift-count-overflow] drivers/pci/controller/pci-thunder-pem.c:54:2: