Re: [PATCH 1/2] drivers: hwmon: Add W83773G driver

Hi Guenter, Thanks a lot for the detailed review. I will try to fix all the comments and send v2 patch. On Sun, Nov 5, 2017 at 3:30 AM, Guenter Roeck wrote: > On 11/01/2017 11:33 PM, Lei YU wrote: >> >> Nuvoton W83773G is a hardware monitor IC providing one local >>

Re: [PATCH 1/2] drivers: hwmon: Add W83773G driver

Hi Guenter, Thanks a lot for the detailed review. I will try to fix all the comments and send v2 patch. On Sun, Nov 5, 2017 at 3:30 AM, Guenter Roeck wrote: > On 11/01/2017 11:33 PM, Lei YU wrote: >> >> Nuvoton W83773G is a hardware monitor IC providing one local >> temperature and two remote

Re: [PATCH 1/2] drivers: hwmon: Add W83773G driver

Hi Lei, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on hwmon/hwmon-next] [also build test WARNING on v4.14-rc7 next-20171103] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH 1/2] drivers: hwmon: Add W83773G driver

Hi Lei, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on hwmon/hwmon-next] [also build test WARNING on v4.14-rc7 next-20171103] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH 1/2] drivers: hwmon: Add W83773G driver

On 11/01/2017 11:33 PM, Lei YU wrote: Nuvoton W83773G is a hardware monitor IC providing one local temperature and two remote temperature sensors. I agree that a separate driver for this chip make sense. Some work to do, though. This is only an initial review; later versions will probably

Re: [PATCH 1/2] drivers: hwmon: Add W83773G driver

On 11/01/2017 11:33 PM, Lei YU wrote: Nuvoton W83773G is a hardware monitor IC providing one local temperature and two remote temperature sensors. I agree that a separate driver for this chip make sense. Some work to do, though. This is only an initial review; later versions will probably

Re: [PATCH 1/2] drivers: hwmon: Add W83773G driver

On Thu, Nov 2, 2017 at 10:04 PM, Guenter Roeck wrote: > On 11/01/2017 11:33 PM, Lei YU wrote: >> >> Nuvoton W83773G is a hardware monitor IC providing one local >> temperature and two remote temperature sensors. >> > This chip is pretty close to LM90. Have you explored adding

Re: [PATCH 1/2] drivers: hwmon: Add W83773G driver

On Thu, Nov 2, 2017 at 10:04 PM, Guenter Roeck wrote: > On 11/01/2017 11:33 PM, Lei YU wrote: >> >> Nuvoton W83773G is a hardware monitor IC providing one local >> temperature and two remote temperature sensors. >> > This chip is pretty close to LM90. Have you explored adding support for it > to

Re: [PATCH 1/2] drivers: hwmon: Add W83773G driver

On 11/01/2017 11:33 PM, Lei YU wrote: Nuvoton W83773G is a hardware monitor IC providing one local temperature and two remote temperature sensors. This chip is pretty close to LM90. Have you explored adding support for it to the LM90 driver ? Signed-off-by: Lei YU ---

Re: [PATCH 1/2] drivers: hwmon: Add W83773G driver

On 11/01/2017 11:33 PM, Lei YU wrote: Nuvoton W83773G is a hardware monitor IC providing one local temperature and two remote temperature sensors. This chip is pretty close to LM90. Have you explored adding support for it to the LM90 driver ? Signed-off-by: Lei YU ---

[PATCH 1/2] drivers: hwmon: Add W83773G driver

Nuvoton W83773G is a hardware monitor IC providing one local temperature and two remote temperature sensors. Signed-off-by: Lei YU --- drivers/hwmon/Kconfig | 11 ++ drivers/hwmon/Makefile | 1 + drivers/hwmon/w83773g.c | 276

[PATCH 1/2] drivers: hwmon: Add W83773G driver

Nuvoton W83773G is a hardware monitor IC providing one local temperature and two remote temperature sensors. Signed-off-by: Lei YU --- drivers/hwmon/Kconfig | 11 ++ drivers/hwmon/Makefile | 1 + drivers/hwmon/w83773g.c | 276 3 files