Re: [PATCH 1/2] drm/radeon: refactor set_page chipset interface v2

2012-09-15 Thread Christian König
Looks good in general, some minor comments below: On 14.09.2012 19:49, Dmitry Cherkasov wrote: From: Christian König Cleanup the interface in preparation for hierarchical page tables. v2: * add incr parameter to set_page for simple scattered PTs uptates * added PDE-specific flags to r600_

[PATCH 1/2] drm/radeon: refactor set_page chipset interface v2

2012-09-14 Thread Dmitry Cherkasov
From: Christian König Cleanup the interface in preparation for hierarchical page tables. v2: * add incr parameter to set_page for simple scattered PTs uptates * added PDE-specific flags to r600_flags and radeon_drm.h * removed superflous value masking with 0x Signed-off-by: Chris