Re: [PATCH 1/2] drm: Add NVIDIA Tegra20 support

2012-11-13 Thread Terje Bergström
On 13.11.2012 10:03, Thierry Reding wrote: > That should be fixed with v2 I posted a few hours ago. That's true. > Yes, Tegra30 support will follow in a separate patch. As for IOMMU > support it should eventually be made completely transparent, but I'm not > opposed to adding a patch with

Re: [PATCH 1/2] drm: Add NVIDIA Tegra20 support

2012-11-13 Thread Thierry Reding
On Tue, Nov 13, 2012 at 10:00:01AM +0200, Terje Bergström wrote: > On 09.11.2012 15:59, Thierry Reding wrote: > > This commit adds a KMS driver for the Tegra20 SoC. This includes basic > > support for host1x and the two display controllers found on the Tegra20 > > SoC. Each display controller can

Re: [PATCH 1/2] drm: Add NVIDIA Tegra20 support

2012-11-13 Thread Thierry Reding
On Tue, Nov 13, 2012 at 10:00:01AM +0200, Terje Bergström wrote: On 09.11.2012 15:59, Thierry Reding wrote: This commit adds a KMS driver for the Tegra20 SoC. This includes basic support for host1x and the two display controllers found on the Tegra20 SoC. Each display controller can drive a

Re: [PATCH 1/2] drm: Add NVIDIA Tegra20 support

2012-11-13 Thread Terje Bergström
On 13.11.2012 10:03, Thierry Reding wrote: That should be fixed with v2 I posted a few hours ago. That's true. Yes, Tegra30 support will follow in a separate patch. As for IOMMU support it should eventually be made completely transparent, but I'm not opposed to adding a patch with explicit

Re: [PATCH 1/2] drm: Add NVIDIA Tegra20 support

2012-11-12 Thread Terje Bergström
On 09.11.2012 15:59, Thierry Reding wrote: > This commit adds a KMS driver for the Tegra20 SoC. This includes basic > support for host1x and the two display controllers found on the Tegra20 > SoC. Each display controller can drive a separate RGB/LVDS output. Thanks Thierry for the hard work. I

Re: [PATCH 1/2] drm: Add NVIDIA Tegra20 support

2012-11-12 Thread Terje Bergström
On 09.11.2012 15:59, Thierry Reding wrote: This commit adds a KMS driver for the Tegra20 SoC. This includes basic support for host1x and the two display controllers found on the Tegra20 SoC. Each display controller can drive a separate RGB/LVDS output. Thanks Thierry for the hard work. I

Re: [PATCH 1/2] drm: Add NVIDIA Tegra20 support

2012-11-10 Thread Terje Bergström
On 09.11.2012 23:03, Thierry Reding wrote: On Fri, Nov 09, 2012 at 10:26:27AM -0600, Rob Clark wrote: hmm, are these values defined by the hw? They look like register offsets into the DC block? I don't think they are defined by the hardware. From what I gather these can arbitrarily be

Re: [PATCH 1/2] drm: Add NVIDIA Tegra20 support

2012-11-10 Thread Thierry Reding
On Fri, Nov 09, 2012 at 05:09:51PM -0700, Stephen Warren wrote: > On 11/09/2012 06:59 AM, Thierry Reding wrote: > > This commit adds a KMS driver for the Tegra20 SoC. This includes basic > > support for host1x and the two display controllers found on the Tegra20 > > SoC. Each display controller

Re: [PATCH 1/2] drm: Add NVIDIA Tegra20 support

2012-11-10 Thread Thierry Reding
On Fri, Nov 09, 2012 at 05:09:51PM -0700, Stephen Warren wrote: On 11/09/2012 06:59 AM, Thierry Reding wrote: This commit adds a KMS driver for the Tegra20 SoC. This includes basic support for host1x and the two display controllers found on the Tegra20 SoC. Each display controller can drive

Re: [PATCH 1/2] drm: Add NVIDIA Tegra20 support

2012-11-10 Thread Terje Bergström
On 09.11.2012 23:03, Thierry Reding wrote: On Fri, Nov 09, 2012 at 10:26:27AM -0600, Rob Clark wrote: hmm, are these values defined by the hw? They look like register offsets into the DC block? I don't think they are defined by the hardware. From what I gather these can arbitrarily be

Re: [PATCH 1/2] drm: Add NVIDIA Tegra20 support

2012-11-09 Thread Stephen Warren
On 11/09/2012 06:59 AM, Thierry Reding wrote: > This commit adds a KMS driver for the Tegra20 SoC. This includes basic > support for host1x and the two display controllers found on the Tegra20 > SoC. Each display controller can drive a separate RGB/LVDS output. I applied these two patches and the

Re: [PATCH 1/2] drm: Add NVIDIA Tegra20 support

2012-11-09 Thread Stephen Warren
On 11/09/2012 06:59 AM, Thierry Reding wrote: > This commit adds a KMS driver for the Tegra20 SoC. This includes basic > support for host1x and the two display controllers found on the Tegra20 > SoC. Each display controller can drive a separate RGB/LVDS output. > diff --git >

Re: [PATCH 1/2] drm: Add NVIDIA Tegra20 support

2012-11-09 Thread Thierry Reding
On Fri, Nov 09, 2012 at 10:26:27AM -0600, Rob Clark wrote: > On Fri, Nov 9, 2012 at 10:00 AM, Thierry Reding > wrote: > > On Fri, Nov 09, 2012 at 09:18:58AM -0600, Rob Clark wrote: > >> On Fri, Nov 9, 2012 at 7:59 AM, Thierry Reding > >> wrote: > > [...] > >> > +static int regs_open(struct inode

Re: [PATCH 1/2] drm: Add NVIDIA Tegra20 support

2012-11-09 Thread Rob Clark
On Fri, Nov 9, 2012 at 10:00 AM, Thierry Reding wrote: > On Fri, Nov 09, 2012 at 09:18:58AM -0600, Rob Clark wrote: >> On Fri, Nov 9, 2012 at 7:59 AM, Thierry Reding >> wrote: > [...] >> > +static int regs_open(struct inode *inode, struct file *file) >> > +{ >> > + return single_open(file,

Re: [PATCH 1/2] drm: Add NVIDIA Tegra20 support

2012-11-09 Thread Thierry Reding
On Fri, Nov 09, 2012 at 09:18:58AM -0600, Rob Clark wrote: > On Fri, Nov 9, 2012 at 7:59 AM, Thierry Reding > wrote: [...] > > +static int regs_open(struct inode *inode, struct file *file) > > +{ > > + return single_open(file, regs_show, inode->i_private); > > +} > > + > > +static const

Re: [PATCH 1/2] drm: Add NVIDIA Tegra20 support

2012-11-09 Thread Thierry Reding
On Fri, Nov 09, 2012 at 09:18:58AM -0600, Rob Clark wrote: On Fri, Nov 9, 2012 at 7:59 AM, Thierry Reding thierry.red...@avionic-design.de wrote: [...] +static int regs_open(struct inode *inode, struct file *file) +{ + return single_open(file, regs_show, inode-i_private); +} +

Re: [PATCH 1/2] drm: Add NVIDIA Tegra20 support

2012-11-09 Thread Rob Clark
On Fri, Nov 9, 2012 at 10:00 AM, Thierry Reding thierry.red...@avionic-design.de wrote: On Fri, Nov 09, 2012 at 09:18:58AM -0600, Rob Clark wrote: On Fri, Nov 9, 2012 at 7:59 AM, Thierry Reding thierry.red...@avionic-design.de wrote: [...] +static int regs_open(struct inode *inode, struct

Re: [PATCH 1/2] drm: Add NVIDIA Tegra20 support

2012-11-09 Thread Thierry Reding
On Fri, Nov 09, 2012 at 10:26:27AM -0600, Rob Clark wrote: On Fri, Nov 9, 2012 at 10:00 AM, Thierry Reding thierry.red...@avionic-design.de wrote: On Fri, Nov 09, 2012 at 09:18:58AM -0600, Rob Clark wrote: On Fri, Nov 9, 2012 at 7:59 AM, Thierry Reding thierry.red...@avionic-design.de

Re: [PATCH 1/2] drm: Add NVIDIA Tegra20 support

2012-11-09 Thread Stephen Warren
On 11/09/2012 06:59 AM, Thierry Reding wrote: This commit adds a KMS driver for the Tegra20 SoC. This includes basic support for host1x and the two display controllers found on the Tegra20 SoC. Each display controller can drive a separate RGB/LVDS output. diff --git

Re: [PATCH 1/2] drm: Add NVIDIA Tegra20 support

2012-11-09 Thread Stephen Warren
On 11/09/2012 06:59 AM, Thierry Reding wrote: This commit adds a KMS driver for the Tegra20 SoC. This includes basic support for host1x and the two display controllers found on the Tegra20 SoC. Each display controller can drive a separate RGB/LVDS output. I applied these two patches and the