Re: [PATCH 1/2] dt-bindings: clock: reset: Add AXG AO Clock and Reset Bindings
Hi Philippe On 02/09/2018 07:07 PM, Philippe Ombredanne wrote: > On Fri, Feb 9, 2018 at 8:00 AM, Yixun Lanwrote: >> Add dt-bindings headers for the Meson-AXG's AO clock and >> reset controller. >> >> CC: >> Signed-off-by: Yixun Lan >> --- >> include/dt-bindings/clock/axg-aoclkc.h | 26 ++ >> include/dt-bindings/reset/axg-aoclkc.h | 20 >> 2 files changed, 46 insertions(+) >> create mode 100644 include/dt-bindings/clock/axg-aoclkc.h >> create mode 100644 include/dt-bindings/reset/axg-aoclkc.h >> >> diff --git a/include/dt-bindings/clock/axg-aoclkc.h >> b/include/dt-bindings/clock/axg-aoclkc.h >> new file mode 100644 >> index ..78683abb4247 >> --- /dev/null >> +++ b/include/dt-bindings/clock/axg-aoclkc.h >> @@ -0,0 +1,26 @@ >> +/* SPDX-License-Identifier: (GPL-2.0+ OR BSD) */ > > nit... BSD is not a valid license id as documented in LICENSES [1] : > please use one of these: > BSD-2-Clause or BSD-3-Clause > > Thank you! > > [1] > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/LICENSES/preferred > Thanks for the hint I'll update to BSD-3-Clause, since this license is just a copy from previous gxbb-aoclkc.h file. Yixun
Re: [PATCH 1/2] dt-bindings: clock: reset: Add AXG AO Clock and Reset Bindings
Hi Philippe On 02/09/2018 07:07 PM, Philippe Ombredanne wrote: > On Fri, Feb 9, 2018 at 8:00 AM, Yixun Lan wrote: >> Add dt-bindings headers for the Meson-AXG's AO clock and >> reset controller. >> >> CC: >> Signed-off-by: Yixun Lan >> --- >> include/dt-bindings/clock/axg-aoclkc.h | 26 ++ >> include/dt-bindings/reset/axg-aoclkc.h | 20 >> 2 files changed, 46 insertions(+) >> create mode 100644 include/dt-bindings/clock/axg-aoclkc.h >> create mode 100644 include/dt-bindings/reset/axg-aoclkc.h >> >> diff --git a/include/dt-bindings/clock/axg-aoclkc.h >> b/include/dt-bindings/clock/axg-aoclkc.h >> new file mode 100644 >> index ..78683abb4247 >> --- /dev/null >> +++ b/include/dt-bindings/clock/axg-aoclkc.h >> @@ -0,0 +1,26 @@ >> +/* SPDX-License-Identifier: (GPL-2.0+ OR BSD) */ > > nit... BSD is not a valid license id as documented in LICENSES [1] : > please use one of these: > BSD-2-Clause or BSD-3-Clause > > Thank you! > > [1] > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/LICENSES/preferred > Thanks for the hint I'll update to BSD-3-Clause, since this license is just a copy from previous gxbb-aoclkc.h file. Yixun
Re: [PATCH 1/2] dt-bindings: clock: reset: Add AXG AO Clock and Reset Bindings
On Fri, Feb 9, 2018 at 8:00 AM, Yixun Lanwrote: > Add dt-bindings headers for the Meson-AXG's AO clock and > reset controller. > > CC: > Signed-off-by: Yixun Lan > --- > include/dt-bindings/clock/axg-aoclkc.h | 26 ++ > include/dt-bindings/reset/axg-aoclkc.h | 20 > 2 files changed, 46 insertions(+) > create mode 100644 include/dt-bindings/clock/axg-aoclkc.h > create mode 100644 include/dt-bindings/reset/axg-aoclkc.h > > diff --git a/include/dt-bindings/clock/axg-aoclkc.h > b/include/dt-bindings/clock/axg-aoclkc.h > new file mode 100644 > index ..78683abb4247 > --- /dev/null > +++ b/include/dt-bindings/clock/axg-aoclkc.h > @@ -0,0 +1,26 @@ > +/* SPDX-License-Identifier: (GPL-2.0+ OR BSD) */ nit... BSD is not a valid license id as documented in LICENSES [1] : please use one of these: BSD-2-Clause or BSD-3-Clause Thank you! [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/LICENSES/preferred -- Cordially Philippe Ombredanne
Re: [PATCH 1/2] dt-bindings: clock: reset: Add AXG AO Clock and Reset Bindings
On Fri, Feb 9, 2018 at 8:00 AM, Yixun Lan wrote: > Add dt-bindings headers for the Meson-AXG's AO clock and > reset controller. > > CC: > Signed-off-by: Yixun Lan > --- > include/dt-bindings/clock/axg-aoclkc.h | 26 ++ > include/dt-bindings/reset/axg-aoclkc.h | 20 > 2 files changed, 46 insertions(+) > create mode 100644 include/dt-bindings/clock/axg-aoclkc.h > create mode 100644 include/dt-bindings/reset/axg-aoclkc.h > > diff --git a/include/dt-bindings/clock/axg-aoclkc.h > b/include/dt-bindings/clock/axg-aoclkc.h > new file mode 100644 > index ..78683abb4247 > --- /dev/null > +++ b/include/dt-bindings/clock/axg-aoclkc.h > @@ -0,0 +1,26 @@ > +/* SPDX-License-Identifier: (GPL-2.0+ OR BSD) */ nit... BSD is not a valid license id as documented in LICENSES [1] : please use one of these: BSD-2-Clause or BSD-3-Clause Thank you! [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/LICENSES/preferred -- Cordially Philippe Ombredanne
[PATCH 1/2] dt-bindings: clock: reset: Add AXG AO Clock and Reset Bindings
Add dt-bindings headers for the Meson-AXG's AO clock and reset controller. CC:Signed-off-by: Yixun Lan --- include/dt-bindings/clock/axg-aoclkc.h | 26 ++ include/dt-bindings/reset/axg-aoclkc.h | 20 2 files changed, 46 insertions(+) create mode 100644 include/dt-bindings/clock/axg-aoclkc.h create mode 100644 include/dt-bindings/reset/axg-aoclkc.h diff --git a/include/dt-bindings/clock/axg-aoclkc.h b/include/dt-bindings/clock/axg-aoclkc.h new file mode 100644 index ..78683abb4247 --- /dev/null +++ b/include/dt-bindings/clock/axg-aoclkc.h @@ -0,0 +1,26 @@ +/* SPDX-License-Identifier: (GPL-2.0+ OR BSD) */ +/* + * Copyright (c) 2016 BayLibre, SAS + * Author: Neil Armstrong + * + * Copyright (c) 2018 Amlogic, inc. + * Author: Qiufang Dai + */ + +#ifndef DT_BINDINGS_CLOCK_AMLOGIC_MESON_AXG_AOCLK +#define DT_BINDINGS_CLOCK_AMLOGIC_MESON_AXG_AOCLK + +#define CLKID_AO_REMOTE0 +#define CLKID_AO_I2C_MASTER1 +#define CLKID_AO_I2C_SLAVE 2 +#define CLKID_AO_UART1 3 +#define CLKID_AO_UART2 4 +#define CLKID_AO_IR_BLASTER5 +#define CLKID_AO_SAR_ADC 6 +#define CLKID_AO_CLK81 7 +#define CLKID_AO_SAR_ADC_SEL 8 +#define CLKID_AO_SAR_ADC_DIV 9 +#define CLKID_AO_SAR_ADC_CLK 10 +#define CLKID_AO_ALT_XTAL 11 + +#endif diff --git a/include/dt-bindings/reset/axg-aoclkc.h b/include/dt-bindings/reset/axg-aoclkc.h new file mode 100644 index ..307f58161bbb --- /dev/null +++ b/include/dt-bindings/reset/axg-aoclkc.h @@ -0,0 +1,20 @@ +/* SPDX-License-Identifier: (GPL-2.0+ OR BSD) */ +/* + * Copyright (c) 2016 BayLibre, SAS + * Author: Neil Armstrong + * + * Copyright (c) 2018 Amlogic, inc. + * Author: Qiufang Dai + */ + +#ifndef DT_BINDINGS_RESET_AMLOGIC_MESON_AXG_AOCLK +#define DT_BINDINGS_RESET_AMLOGIC_MESON_AXG_AOCLK + +#define RESET_AO_REMOTE0 +#define RESET_AO_I2C_MASTER1 +#define RESET_AO_I2C_SLAVE 2 +#define RESET_AO_UART1 3 +#define RESET_AO_UART2 4 +#define RESET_AO_IR_BLASTER5 + +#endif -- 2.15.1
[PATCH 1/2] dt-bindings: clock: reset: Add AXG AO Clock and Reset Bindings
Add dt-bindings headers for the Meson-AXG's AO clock and reset controller. CC: Signed-off-by: Yixun Lan --- include/dt-bindings/clock/axg-aoclkc.h | 26 ++ include/dt-bindings/reset/axg-aoclkc.h | 20 2 files changed, 46 insertions(+) create mode 100644 include/dt-bindings/clock/axg-aoclkc.h create mode 100644 include/dt-bindings/reset/axg-aoclkc.h diff --git a/include/dt-bindings/clock/axg-aoclkc.h b/include/dt-bindings/clock/axg-aoclkc.h new file mode 100644 index ..78683abb4247 --- /dev/null +++ b/include/dt-bindings/clock/axg-aoclkc.h @@ -0,0 +1,26 @@ +/* SPDX-License-Identifier: (GPL-2.0+ OR BSD) */ +/* + * Copyright (c) 2016 BayLibre, SAS + * Author: Neil Armstrong + * + * Copyright (c) 2018 Amlogic, inc. + * Author: Qiufang Dai + */ + +#ifndef DT_BINDINGS_CLOCK_AMLOGIC_MESON_AXG_AOCLK +#define DT_BINDINGS_CLOCK_AMLOGIC_MESON_AXG_AOCLK + +#define CLKID_AO_REMOTE0 +#define CLKID_AO_I2C_MASTER1 +#define CLKID_AO_I2C_SLAVE 2 +#define CLKID_AO_UART1 3 +#define CLKID_AO_UART2 4 +#define CLKID_AO_IR_BLASTER5 +#define CLKID_AO_SAR_ADC 6 +#define CLKID_AO_CLK81 7 +#define CLKID_AO_SAR_ADC_SEL 8 +#define CLKID_AO_SAR_ADC_DIV 9 +#define CLKID_AO_SAR_ADC_CLK 10 +#define CLKID_AO_ALT_XTAL 11 + +#endif diff --git a/include/dt-bindings/reset/axg-aoclkc.h b/include/dt-bindings/reset/axg-aoclkc.h new file mode 100644 index ..307f58161bbb --- /dev/null +++ b/include/dt-bindings/reset/axg-aoclkc.h @@ -0,0 +1,20 @@ +/* SPDX-License-Identifier: (GPL-2.0+ OR BSD) */ +/* + * Copyright (c) 2016 BayLibre, SAS + * Author: Neil Armstrong + * + * Copyright (c) 2018 Amlogic, inc. + * Author: Qiufang Dai + */ + +#ifndef DT_BINDINGS_RESET_AMLOGIC_MESON_AXG_AOCLK +#define DT_BINDINGS_RESET_AMLOGIC_MESON_AXG_AOCLK + +#define RESET_AO_REMOTE0 +#define RESET_AO_I2C_MASTER1 +#define RESET_AO_I2C_SLAVE 2 +#define RESET_AO_UART1 3 +#define RESET_AO_UART2 4 +#define RESET_AO_IR_BLASTER5 + +#endif -- 2.15.1