Re: [PATCH 1/2] dyndbg: dont panic over bad input

2020-09-27 Thread Greg KH
On Mon, Sep 21, 2020 at 01:04:32PM -0600, Jim Cromie wrote: > This BUG_ON, from 2009, caught the impossible case of a word-char both > starting and ending a string (loosely speaking). A bad (reverted) > patch finally hit this case, but even "impossibly bad input" is no > reason to panic the

Re: [PATCH 1/2] dyndbg: dont panic over bad input

2020-09-22 Thread jim . cromie
On Tue, Sep 22, 2020 at 2:08 AM Petr Mladek wrote: > > On Mon 2020-09-21 13:04:32, Jim Cromie wrote: > > This BUG_ON, from 2009, caught the impossible case of a word-char both > > starting and ending a string (loosely speaking). A bad (reverted) > > patch finally hit this case, but even

Re: [PATCH 1/2] dyndbg: dont panic over bad input

2020-09-22 Thread Petr Mladek
On Mon 2020-09-21 13:04:32, Jim Cromie wrote: > This BUG_ON, from 2009, caught the impossible case of a word-char both > starting and ending a string (loosely speaking). A bad (reverted) > patch finally hit this case, but even "impossibly bad input" is no > reason to panic the kernel. Instead

Re: [PATCH 1/2] dyndbg: dont panic over bad input

2020-09-21 Thread jim . cromie
On Mon, Sep 21, 2020 at 1:29 PM Joe Perches wrote: > > On Mon, 2020-09-21 at 13:04 -0600, Jim Cromie wrote: > > This BUG_ON, from 2009, caught the impossible case of a word-char both > > starting and ending a string (loosely speaking). A bad (reverted) > > patch finally hit this case, but even

Re: [PATCH 1/2] dyndbg: dont panic over bad input

2020-09-21 Thread Joe Perches
On Mon, 2020-09-21 at 13:04 -0600, Jim Cromie wrote: > This BUG_ON, from 2009, caught the impossible case of a word-char both > starting and ending a string (loosely speaking). A bad (reverted) > patch finally hit this case, but even "impossibly bad input" is no > reason to panic the kernel.

[PATCH 1/2] dyndbg: dont panic over bad input

2020-09-21 Thread Jim Cromie
This BUG_ON, from 2009, caught the impossible case of a word-char both starting and ending a string (loosely speaking). A bad (reverted) patch finally hit this case, but even "impossibly bad input" is no reason to panic the kernel. Instead pr_err and return -EINVAL. Reported-by: Petr Mladek