Re: [PATCH 1/2] gpio: altera: use of_mm_gpiochip_remove() to fix memory leak

On Wed, Jun 17, 2015 at 1:59 PM, Masahiro Yamada wrote: > This driver calls of_mm_gpiochip_add() to add a memory mapped gpio > chip. So, of_mm_gpiochip_remove() should be used when removing it. > > The direct call of gpiochip_remove() misses unmapping the register > and freeing the label. > >

Re: [PATCH 1/2] gpio: altera: use of_mm_gpiochip_remove() to fix memory leak

On Wed, Jun 17, 2015 at 1:59 PM, Masahiro Yamada yamada.masah...@socionext.com wrote: This driver calls of_mm_gpiochip_add() to add a memory mapped gpio chip. So, of_mm_gpiochip_remove() should be used when removing it. The direct call of gpiochip_remove() misses unmapping the register and

Re: [PATCH 1/2] gpio: altera: use of_mm_gpiochip_remove() to fix memory leak

Acked-by: Tien Hock Loh On Wed, 2015-06-17 at 20:59 +0900, Masahiro Yamada wrote: > This driver calls of_mm_gpiochip_add() to add a memory mapped gpio > chip. So, of_mm_gpiochip_remove() should be used when removing it. > > The direct call of gpiochip_remove() misses unmapping the register >

Re: [PATCH 1/2] gpio: altera: use of_mm_gpiochip_remove() to fix memory leak

Acked-by: Tien Hock Loh th...@altera.com On Wed, 2015-06-17 at 20:59 +0900, Masahiro Yamada wrote: This driver calls of_mm_gpiochip_add() to add a memory mapped gpio chip. So, of_mm_gpiochip_remove() should be used when removing it. The direct call of gpiochip_remove() misses unmapping the

Re: [PATCH 1/2] gpio: altera: use of_mm_gpiochip_remove() to fix memory leak

On Wed, Jun 17, 2015 at 8:59 PM, Masahiro Yamada wrote: > This driver calls of_mm_gpiochip_add() to add a memory mapped gpio > chip. So, of_mm_gpiochip_remove() should be used when removing it. > > The direct call of gpiochip_remove() misses unmapping the register > and freeing the label. > >

Re: [PATCH 1/2] gpio: altera: use of_mm_gpiochip_remove() to fix memory leak

On Wed, Jun 17, 2015 at 8:59 PM, Masahiro Yamada yamada.masah...@socionext.com wrote: This driver calls of_mm_gpiochip_add() to add a memory mapped gpio chip. So, of_mm_gpiochip_remove() should be used when removing it. The direct call of gpiochip_remove() misses unmapping the register and

[PATCH 1/2] gpio: altera: use of_mm_gpiochip_remove() to fix memory leak

This driver calls of_mm_gpiochip_add() to add a memory mapped gpio chip. So, of_mm_gpiochip_remove() should be used when removing it. The direct call of gpiochip_remove() misses unmapping the register and freeing the label. Signed-off-by: Masahiro Yamada --- drivers/gpio/gpio-altera.c | 2 +-

[PATCH 1/2] gpio: altera: use of_mm_gpiochip_remove() to fix memory leak

This driver calls of_mm_gpiochip_add() to add a memory mapped gpio chip. So, of_mm_gpiochip_remove() should be used when removing it. The direct call of gpiochip_remove() misses unmapping the register and freeing the label. Signed-off-by: Masahiro Yamada yamada.masah...@socionext.com ---