Re: [PATCH 1/2] kbuild: refactor scripts/Makefile.extrawarn

2019-08-29 Thread Masahiro Yamada
On Wed, Aug 28, 2019 at 11:19 PM Sedat Dilek wrote: > > On Wed, Aug 28, 2019 at 9:20 AM Sedat Dilek wrote: > > > > On Wed, Aug 28, 2019 at 7:55 AM Masahiro Yamada > > wrote: > > > > > > Instead of the warning-[123] magic, let's accumulate compiler options > > > to KBUILD_CFLAGS directly as the

Re: [PATCH 1/2] kbuild: refactor scripts/Makefile.extrawarn

2019-08-29 Thread Sedat Dilek
> So, if it is desired to pass the CLANG extrawarn compiler-options to > all W=... then I ask myself why the CLANG block is in the W=1 block > only? > So if CLANG extrawarn options are independent of any W=... make-option > then I prefer to put it in a seperate block with an appropriate > comment.

Re: [PATCH 1/2] kbuild: refactor scripts/Makefile.extrawarn

2019-08-29 Thread Sedat Dilek
On Thu, Aug 29, 2019 at 12:38 AM 'Nick Desaulniers' via Clang Built Linux wrote: > > On Tue, Aug 27, 2019 at 10:54 PM Masahiro Yamada > wrote: > > > > Instead of the warning-[123] magic, let's accumulate compiler options > > to KBUILD_CFLAGS directly as the top Makefile does. I think this makes

Re: [PATCH 1/2] kbuild: refactor scripts/Makefile.extrawarn

2019-08-28 Thread Nick Desaulniers
On Tue, Aug 27, 2019 at 10:54 PM Masahiro Yamada wrote: > > Instead of the warning-[123] magic, let's accumulate compiler options > to KBUILD_CFLAGS directly as the top Makefile does. I think this makes > easier to understand what is going on in this file. > > This commit slightly changes the

Re: [PATCH 1/2] kbuild: refactor scripts/Makefile.extrawarn

2019-08-28 Thread Nick Desaulniers
On Wed, Aug 28, 2019 at 12:20 AM Sedat Dilek wrote: > > On Wed, Aug 28, 2019 at 7:55 AM Masahiro Yamada > wrote: > > > > Instead of the warning-[123] magic, let's accumulate compiler options > > to KBUILD_CFLAGS directly as the top Makefile does. I think this makes > > easier to understand what

Re: [PATCH 1/2] kbuild: refactor scripts/Makefile.extrawarn

2019-08-28 Thread Nathan Chancellor
On Wed, Aug 28, 2019 at 02:54:24PM +0900, Masahiro Yamada wrote: > Instead of the warning-[123] magic, let's accumulate compiler options > to KBUILD_CFLAGS directly as the top Makefile does. I think this makes > easier to understand what is going on in this file. > > This commit slightly changes

Re: [PATCH 1/2] kbuild: refactor scripts/Makefile.extrawarn

2019-08-28 Thread Sedat Dilek
Something like that... [PATCH 1/2] kbuild: Improve extrawarn documentation [PATCH 2/2] kbuild: Rename extrawarn Kconfig to KBUILD_EXTRA_CC_CHECKS - Sedat - From 1275ec0f1d31c4ac57b73b318bdc45151d99e8dc Mon Sep 17 00:00:00 2001 From: Sedat Dilek Date: Wed, 28 Aug 2019 16:27:13 +0200 Subject:

Re: [PATCH 1/2] kbuild: refactor scripts/Makefile.extrawarn

2019-08-28 Thread Sedat Dilek
> build-time checking. For more details see . Grrr. s/ Documentation/kbuild/kbuild.rst / scripts/Makefile.extrawarn - Sedat -

Re: [PATCH 1/2] kbuild: refactor scripts/Makefile.extrawarn

2019-08-28 Thread Sedat Dilek
On Wed, Aug 28, 2019 at 9:20 AM Sedat Dilek wrote: > > On Wed, Aug 28, 2019 at 7:55 AM Masahiro Yamada > wrote: > > > > Instead of the warning-[123] magic, let's accumulate compiler options > > to KBUILD_CFLAGS directly as the top Makefile does. I think this makes > > easier to understand what

Re: [PATCH 1/2] kbuild: refactor scripts/Makefile.extrawarn

2019-08-28 Thread Sedat Dilek
On Wed, Aug 28, 2019 at 7:55 AM Masahiro Yamada wrote: > > Instead of the warning-[123] magic, let's accumulate compiler options > to KBUILD_CFLAGS directly as the top Makefile does. I think this makes > easier to understand what is going on in this file. > > This commit slightly changes the

[PATCH 1/2] kbuild: refactor scripts/Makefile.extrawarn

2019-08-27 Thread Masahiro Yamada
Instead of the warning-[123] magic, let's accumulate compiler options to KBUILD_CFLAGS directly as the top Makefile does. I think this makes easier to understand what is going on in this file. This commit slightly changes the behavior, I think all of which are OK. [1] Currently, cc-option calls