Re: [PATCH 1/2] media: davinci: vpif capture: upgrade the driver with v4l offerings

2014-03-31 Thread Hans Verkuil
On 03/31/2014 07:24 PM, Prabhakar Lad wrote: > Hi Hans, > > On Mon, Mar 31, 2014 at 8:34 PM, Hans Verkuil wrote: >> Hi Prabhakar, >> >> This looks really nice! >> > Writing a video driver has become really easy with almost 90% of work > done by v4l core itself :) That was the idea! >> I'll do a

Re: [PATCH 1/2] media: davinci: vpif capture: upgrade the driver with v4l offerings

2014-03-31 Thread Prabhakar Lad
Hi Hans, On Mon, Mar 31, 2014 at 8:34 PM, Hans Verkuil wrote: > Hi Prabhakar, > > This looks really nice! > Writing a video driver has become really easy with almost 90% of work done by v4l core itself :) > I'll do a full review on Friday, but in the meantime can you post the output OK. > of 'v

Re: [PATCH 1/2] media: davinci: vpif capture: upgrade the driver with v4l offerings

2014-03-31 Thread Hans Verkuil
Hi Prabhakar, This looks really nice! I'll do a full review on Friday, but in the meantime can you post the output of 'v4l2-compliance -s' using the latest v4l2-compliance version? I've made some commits today, so you need to do a git pull of v4l-utils.git. I also have a small comment below: On

[PATCH 1/2] media: davinci: vpif capture: upgrade the driver with v4l offerings

2014-03-31 Thread Lad, Prabhakar
From: "Lad, Prabhakar" This patch upgrades the vpif display driver with v4l helpers, this patch does the following, 1: initialize the vb2 queue and context at the time of probe and removes context at remove() callback. 2: uses vb2_ioctl_*() helpers. 3: uses vb2_fop_*() helpers. 4: uses SIMPLE_DE