Re: [PATCH 1/2] memory: brcmstb_dpfe: Simplify with dev_err_probe()

2020-09-02 Thread Krzysztof Kozlowski 
On Fri, Aug 28, 2020 at 05:37:46PM +0200, Krzysztof Kozlowski wrote:
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe().  Less code and the error value gets printed.
> 
> Signed-off-by: Krzysztof Kozlowski 
> ---
>  drivers/memory/brcmstb_dpfe.c | 7 ++-

Applied.

Best regards,
Krzysztof

Re: [PATCH 1/2] memory: brcmstb_dpfe: Simplify with dev_err_probe()

2020-08-28 Thread Florian Fainelli 
On 8/28/20 8:37 AM, Krzysztof Kozlowski wrote:
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe().  Less code and the error value gets printed.
> 
> Signed-off-by: Krzysztof Kozlowski 

Acked-by: Florian Fainelli 
-- 
Florian

Re: [PATCH 1/2] memory: brcmstb_dpfe: Simplify with dev_err_probe()

2020-08-28 Thread Markus Mayer 
On Fri, 28 Aug 2020 at 08:37, Krzysztof Kozlowski  wrote:
>
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe().  Less code and the error value gets printed.
>
> Signed-off-by: Krzysztof Kozlowski 

Acked-by: Markus Mayer 

> ---
>  drivers/memory/brcmstb_dpfe.c | 7 ++-
>  1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/memory/brcmstb_dpfe.c b/drivers/memory/brcmstb_dpfe.c
> index dcf50bb8dd69..f43ba69fbb3e 100644
> --- a/drivers/memory/brcmstb_dpfe.c
> +++ b/drivers/memory/brcmstb_dpfe.c
> @@ -901,11 +901,8 @@ static int brcmstb_dpfe_probe(struct platform_device 
> *pdev)
> }
>
> ret = brcmstb_dpfe_download_firmware(priv);
> -   if (ret) {
> -   if (ret != -EPROBE_DEFER)
> -   dev_err(dev, "Couldn't download firmware -- %d\n", 
> ret);
> -   return ret;
> -   }
> +   if (ret)
> +   return dev_err_probe(dev, ret, "Couldn't download 
> firmware\n");
>
> ret = sysfs_create_groups(>dev.kobj, 
> priv->dpfe_api->sysfs_attrs);
> if (!ret)
> --
> 2.17.1
>

[PATCH 1/2] memory: brcmstb_dpfe: Simplify with dev_err_probe()

2020-08-28 Thread Krzysztof Kozlowski 
Common pattern of handling deferred probe can be simplified with
dev_err_probe().  Less code and the error value gets printed.

Signed-off-by: Krzysztof Kozlowski 
---
 drivers/memory/brcmstb_dpfe.c | 7 ++-
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/memory/brcmstb_dpfe.c b/drivers/memory/brcmstb_dpfe.c
index dcf50bb8dd69..f43ba69fbb3e 100644
--- a/drivers/memory/brcmstb_dpfe.c
+++ b/drivers/memory/brcmstb_dpfe.c
@@ -901,11 +901,8 @@ static int brcmstb_dpfe_probe(struct platform_device *pdev)
}
 
ret = brcmstb_dpfe_download_firmware(priv);
-   if (ret) {
-   if (ret != -EPROBE_DEFER)
-   dev_err(dev, "Couldn't download firmware -- %d\n", ret);
-   return ret;
-   }
+   if (ret)
+   return dev_err_probe(dev, ret, "Couldn't download firmware\n");
 
ret = sysfs_create_groups(>dev.kobj, priv->dpfe_api->sysfs_attrs);
if (!ret)
-- 
2.17.1