Re: [PATCH 1/2] mlx5: only register devlink when ethernet is available

2016-06-17 Thread Leon Romanovsky
On Fri, Jun 17, 2016 at 05:02:33PM +0200, Arnd Bergmann wrote: > On Friday, June 17, 2016 5:50:14 PM CEST Saeed Mahameed wrote: > > On Wed, Jun 15, 2016 at 11:50 PM, Arnd Bergmann wrote: > > > On Wednesday, June 15, 2016 7:04:54 PM CEST Saeed Mahameed wrote: > > > Ok, I see. It

Re: [PATCH 1/2] mlx5: only register devlink when ethernet is available

2016-06-17 Thread Leon Romanovsky
On Fri, Jun 17, 2016 at 05:02:33PM +0200, Arnd Bergmann wrote: > On Friday, June 17, 2016 5:50:14 PM CEST Saeed Mahameed wrote: > > On Wed, Jun 15, 2016 at 11:50 PM, Arnd Bergmann wrote: > > > On Wednesday, June 15, 2016 7:04:54 PM CEST Saeed Mahameed wrote: > > > Ok, I see. It would be nice if

Re: [PATCH 1/2] mlx5: only register devlink when ethernet is available

2016-06-17 Thread Arnd Bergmann
On Friday, June 17, 2016 5:50:14 PM CEST Saeed Mahameed wrote: > On Wed, Jun 15, 2016 at 11:50 PM, Arnd Bergmann wrote: > > On Wednesday, June 15, 2016 7:04:54 PM CEST Saeed Mahameed wrote: > > Ok, I see. It would be nice if the process had a way to avoid build > > regressions > >

Re: [PATCH 1/2] mlx5: only register devlink when ethernet is available

2016-06-17 Thread Arnd Bergmann
On Friday, June 17, 2016 5:50:14 PM CEST Saeed Mahameed wrote: > On Wed, Jun 15, 2016 at 11:50 PM, Arnd Bergmann wrote: > > On Wednesday, June 15, 2016 7:04:54 PM CEST Saeed Mahameed wrote: > > Ok, I see. It would be nice if the process had a way to avoid build > > regressions > > in linux-next,

Re: [PATCH 1/2] mlx5: only register devlink when ethernet is available

2016-06-17 Thread Saeed Mahameed
On Wed, Jun 15, 2016 at 11:50 PM, Arnd Bergmann wrote: > On Wednesday, June 15, 2016 7:04:54 PM CEST Saeed Mahameed wrote: > Ok, I see. It would be nice if the process had a way to avoid build > regressions > in linux-next, in particular if you already have a fix by the time a

Re: [PATCH 1/2] mlx5: only register devlink when ethernet is available

2016-06-17 Thread Saeed Mahameed
On Wed, Jun 15, 2016 at 11:50 PM, Arnd Bergmann wrote: > On Wednesday, June 15, 2016 7:04:54 PM CEST Saeed Mahameed wrote: > Ok, I see. It would be nice if the process had a way to avoid build > regressions > in linux-next, in particular if you already have a fix by the time a patch > that

Re: [PATCH 1/2] mlx5: only register devlink when ethernet is available

2016-06-15 Thread Arnd Bergmann
On Wednesday, June 15, 2016 7:04:54 PM CEST Saeed Mahameed wrote: > > Hi Arnd, > > We already took care of those issues, they only apply to Leon's tree > https://git.kernel.org/cgit/linux/kernel/git/leon/linux-rdma.git/, > this tree is meant to maintain MLX5 Shared code between netdev and >

Re: [PATCH 1/2] mlx5: only register devlink when ethernet is available

2016-06-15 Thread Arnd Bergmann
On Wednesday, June 15, 2016 7:04:54 PM CEST Saeed Mahameed wrote: > > Hi Arnd, > > We already took care of those issues, they only apply to Leon's tree > https://git.kernel.org/cgit/linux/kernel/git/leon/linux-rdma.git/, > this tree is meant to maintain MLX5 Shared code between netdev and >

Re: [PATCH 1/2] mlx5: only register devlink when ethernet is available

2016-06-15 Thread Saeed Mahameed
On Wed, Jun 15, 2016 at 6:27 PM, Arnd Bergmann wrote: > We get a build error with the mlx5 driver when the ethernet > support (CONFIG_MLX5_CORE_EN) is disabled: > > drivers/net/ethernet/mellanox/mlx5/core/main.c:1320:22: error: > 'mlx5_devlink_eswitch_mode_set' undeclared here

Re: [PATCH 1/2] mlx5: only register devlink when ethernet is available

2016-06-15 Thread Saeed Mahameed
On Wed, Jun 15, 2016 at 6:27 PM, Arnd Bergmann wrote: > We get a build error with the mlx5 driver when the ethernet > support (CONFIG_MLX5_CORE_EN) is disabled: > > drivers/net/ethernet/mellanox/mlx5/core/main.c:1320:22: error: > 'mlx5_devlink_eswitch_mode_set' undeclared here (not in a

[PATCH 1/2] mlx5: only register devlink when ethernet is available

2016-06-15 Thread Arnd Bergmann
We get a build error with the mlx5 driver when the ethernet support (CONFIG_MLX5_CORE_EN) is disabled: drivers/net/ethernet/mellanox/mlx5/core/main.c:1320:22: error: 'mlx5_devlink_eswitch_mode_set' undeclared here (not in a function) drivers/net/ethernet/mellanox/mlx5/core/main.c:1321:22: error:

[PATCH 1/2] mlx5: only register devlink when ethernet is available

2016-06-15 Thread Arnd Bergmann
We get a build error with the mlx5 driver when the ethernet support (CONFIG_MLX5_CORE_EN) is disabled: drivers/net/ethernet/mellanox/mlx5/core/main.c:1320:22: error: 'mlx5_devlink_eswitch_mode_set' undeclared here (not in a function) drivers/net/ethernet/mellanox/mlx5/core/main.c:1321:22: error: