Re: [PATCH 1/2] modpost: reduce visibility of symbols and constify r/o arrays

2014-08-27 Thread Rusty Russell
Mathias Krause writes: > Internally used symbols of modpost don't need to be externally visible; > make them static. Also constify the string arrays so they resist in the > r/o section instead of being runtime writable. I'm not convinced of the second patch, but I've applied it anyway. Thanks,

Re: [PATCH 1/2] modpost: reduce visibility of symbols and constify r/o arrays

2014-08-27 Thread Rusty Russell
Mathias Krause mini...@googlemail.com writes: Internally used symbols of modpost don't need to be externally visible; make them static. Also constify the string arrays so they resist in the r/o section instead of being runtime writable. I'm not convinced of the second patch, but I've applied

[PATCH 1/2] modpost: reduce visibility of symbols and constify r/o arrays

2014-08-25 Thread Mathias Krause
Internally used symbols of modpost don't need to be externally visible; make them static. Also constify the string arrays so they resist in the r/o section instead of being runtime writable. Those changes lead to a small size reduction as can be seen below: textdata bss dec

[PATCH 1/2] modpost: reduce visibility of symbols and constify r/o arrays

2014-08-25 Thread Mathias Krause
Internally used symbols of modpost don't need to be externally visible; make them static. Also constify the string arrays so they resist in the r/o section instead of being runtime writable. Those changes lead to a small size reduction as can be seen below: textdata bss dec