Re: [PATCH 1/2] of/fdt: Allow architectures to override CONFIG_CMDLINE logic

2018-09-28 Thread Palmer Dabbelt
On Fri, 07 Sep 2018 13:29:03 PDT (-0700), robh...@kernel.org wrote: On Fri, Sep 7, 2018 at 1:55 PM Paul Burton wrote: The CONFIG_CMDLINE-related logic in early_init_dt_scan_chosen() falls back to copying CONFIG_CMDLINE into boot_command_line/data if the DT has a /chosen node but that node has

Re: [PATCH 1/2] of/fdt: Allow architectures to override CONFIG_CMDLINE logic

2018-09-07 Thread Rob Herring
On Fri, Sep 7, 2018 at 4:01 PM Paul Burton wrote: > > Hi Rob, > > On Fri, Sep 07, 2018 at 03:29:03PM -0500, Rob Herring wrote: > > On Fri, Sep 7, 2018 at 1:55 PM Paul Burton wrote: > > > The CONFIG_CMDLINE-related logic in early_init_dt_scan_chosen() falls > > > back to copying CONFIG_CMDLINE int

Re: [PATCH 1/2] of/fdt: Allow architectures to override CONFIG_CMDLINE logic

2018-09-07 Thread Paul Burton
Hi Rob, On Fri, Sep 07, 2018 at 03:29:03PM -0500, Rob Herring wrote: > On Fri, Sep 7, 2018 at 1:55 PM Paul Burton wrote: > > The CONFIG_CMDLINE-related logic in early_init_dt_scan_chosen() falls > > back to copying CONFIG_CMDLINE into boot_command_line/data if the DT has > > a /chosen node but th

Re: [PATCH 1/2] of/fdt: Allow architectures to override CONFIG_CMDLINE logic

2018-09-07 Thread Rob Herring
On Fri, Sep 7, 2018 at 1:55 PM Paul Burton wrote: > > The CONFIG_CMDLINE-related logic in early_init_dt_scan_chosen() falls > back to copying CONFIG_CMDLINE into boot_command_line/data if the DT has > a /chosen node but that node has no bootargs property or a bootargs > property of length zero. T

[PATCH 1/2] of/fdt: Allow architectures to override CONFIG_CMDLINE logic

2018-09-07 Thread Paul Burton
The CONFIG_CMDLINE-related logic in early_init_dt_scan_chosen() falls back to copying CONFIG_CMDLINE into boot_command_line/data if the DT has a /chosen node but that node has no bootargs property or a bootargs property of length zero. This is problematic for the MIPS architecture because we suppo