Re: [PATCH 1/2] pci: prevent sk hynix nvme from entering D3

2018-11-07 Thread Christoph Hellwig
On Tue, Nov 06, 2018 at 06:11:31PM +0800, AceLan Kao wrote: > Agree, this is not a good fix for Sk hynix nvme, so Dell is still pushing > Sk hynix to fix it from firmware. > But before the firmware is ready, this is still a issue that need to be fixed > in > kernel side, and the new firmware may

Re: [PATCH 1/2] pci: prevent sk hynix nvme from entering D3

2018-11-07 Thread Christoph Hellwig
On Tue, Nov 06, 2018 at 06:11:31PM +0800, AceLan Kao wrote: > Agree, this is not a good fix for Sk hynix nvme, so Dell is still pushing > Sk hynix to fix it from firmware. > But before the firmware is ready, this is still a issue that need to be fixed > in > kernel side, and the new firmware may

Re: [PATCH 1/2] pci: prevent sk hynix nvme from entering D3

2018-11-06 Thread AceLan Kao
Christoph Hellwig 於 2018年11月6日 週二 下午3:10寫道: > > On Tue, Nov 06, 2018 at 10:04:01AM +0800, AceLan Kao wrote: > > It leads to the power consumption raises to 2.2W during s2idle, while > > it consumes less than 1W during long idle if put SK hynix nvme to D3 > > and then enter s2idle. > > >From SK

Re: [PATCH 1/2] pci: prevent sk hynix nvme from entering D3

2018-11-06 Thread AceLan Kao
Christoph Hellwig 於 2018年11月6日 週二 下午3:10寫道: > > On Tue, Nov 06, 2018 at 10:04:01AM +0800, AceLan Kao wrote: > > It leads to the power consumption raises to 2.2W during s2idle, while > > it consumes less than 1W during long idle if put SK hynix nvme to D3 > > and then enter s2idle. > > >From SK

Re: [PATCH 1/2] pci: prevent sk hynix nvme from entering D3

2018-11-05 Thread Christoph Hellwig
On Tue, Nov 06, 2018 at 10:04:01AM +0800, AceLan Kao wrote: > It leads to the power consumption raises to 2.2W during s2idle, while > it consumes less than 1W during long idle if put SK hynix nvme to D3 > and then enter s2idle. > >From SK hynix FE, MS Windows doesn't put nvme to D3, and uses its

Re: [PATCH 1/2] pci: prevent sk hynix nvme from entering D3

2018-11-05 Thread Christoph Hellwig
On Tue, Nov 06, 2018 at 10:04:01AM +0800, AceLan Kao wrote: > It leads to the power consumption raises to 2.2W during s2idle, while > it consumes less than 1W during long idle if put SK hynix nvme to D3 > and then enter s2idle. > >From SK hynix FE, MS Windows doesn't put nvme to D3, and uses its

[PATCH 1/2] pci: prevent sk hynix nvme from entering D3

2018-11-05 Thread AceLan Kao
It leads to the power consumption raises to 2.2W during s2idle, while it consumes less than 1W during long idle if put SK hynix nvme to D3 and then enter s2idle. >From SK hynix FE, MS Windows doesn't put nvme to D3, and uses its own APST feature to do the power management. To leverage its APST

[PATCH 1/2] pci: prevent sk hynix nvme from entering D3

2018-11-05 Thread AceLan Kao
It leads to the power consumption raises to 2.2W during s2idle, while it consumes less than 1W during long idle if put SK hynix nvme to D3 and then enter s2idle. >From SK hynix FE, MS Windows doesn't put nvme to D3, and uses its own APST feature to do the power management. To leverage its APST