Re: [PATCH 1/2] regmap: fix NULL pointer dereference in regmap_name_read_file()

2018-01-24 Thread Mark Brown
On Wed, Jan 24, 2018 at 10:27:22AM -0600, David Lechner wrote: > On 01/24/2018 10:19 AM, Mark Brown wrote: > > Indeed. It is an improvement but not exactly helpful. > Would it be better if it said "this regmap does not have driver" instead > of "(null)"? That's both not idiomatically good and

Re: [PATCH 1/2] regmap: fix NULL pointer dereference in regmap_name_read_file()

2018-01-24 Thread Mark Brown
On Wed, Jan 24, 2018 at 10:27:22AM -0600, David Lechner wrote: > On 01/24/2018 10:19 AM, Mark Brown wrote: > > Indeed. It is an improvement but not exactly helpful. > Would it be better if it said "this regmap does not have driver" instead > of "(null)"? That's both not idiomatically good and

Re: [PATCH 1/2] regmap: fix NULL pointer dereference in regmap_name_read_file()

2018-01-24 Thread David Lechner
On 01/24/2018 10:19 AM, Mark Brown wrote: On Wed, Jan 24, 2018 at 05:14:50PM +0100, Lars-Peter Clausen wrote: On 01/23/2018 11:53 PM, David Lechner wrote: This fixes a possible NULL pointer dereference oops in regmap_name_read_file() when the regmap does not have a device associated with it.

Re: [PATCH 1/2] regmap: fix NULL pointer dereference in regmap_name_read_file()

2018-01-24 Thread David Lechner
On 01/24/2018 10:19 AM, Mark Brown wrote: On Wed, Jan 24, 2018 at 05:14:50PM +0100, Lars-Peter Clausen wrote: On 01/23/2018 11:53 PM, David Lechner wrote: This fixes a possible NULL pointer dereference oops in regmap_name_read_file() when the regmap does not have a device associated with it.

Re: [PATCH 1/2] regmap: fix NULL pointer dereference in regmap_name_read_file()

2018-01-24 Thread David Lechner
On 01/24/2018 10:14 AM, Lars-Peter Clausen wrote: On 01/23/2018 11:53 PM, David Lechner wrote: This fixes a possible NULL pointer dereference oops in regmap_name_read_file() when the regmap does not have a device associated with it. Signed-off-by: David Lechner ---

Re: [PATCH 1/2] regmap: fix NULL pointer dereference in regmap_name_read_file()

2018-01-24 Thread David Lechner
On 01/24/2018 10:14 AM, Lars-Peter Clausen wrote: On 01/23/2018 11:53 PM, David Lechner wrote: This fixes a possible NULL pointer dereference oops in regmap_name_read_file() when the regmap does not have a device associated with it. Signed-off-by: David Lechner ---

Re: [PATCH 1/2] regmap: fix NULL pointer dereference in regmap_name_read_file()

2018-01-24 Thread Mark Brown
On Wed, Jan 24, 2018 at 05:14:50PM +0100, Lars-Peter Clausen wrote: > On 01/23/2018 11:53 PM, David Lechner wrote: > > This fixes a possible NULL pointer dereference oops in > > regmap_name_read_file() when the regmap does not have a device > > associated with it. > > - ret = snprintf(buf,

Re: [PATCH 1/2] regmap: fix NULL pointer dereference in regmap_name_read_file()

2018-01-24 Thread Mark Brown
On Wed, Jan 24, 2018 at 05:14:50PM +0100, Lars-Peter Clausen wrote: > On 01/23/2018 11:53 PM, David Lechner wrote: > > This fixes a possible NULL pointer dereference oops in > > regmap_name_read_file() when the regmap does not have a device > > associated with it. > > - ret = snprintf(buf,

Re: [PATCH 1/2] regmap: fix NULL pointer dereference in regmap_name_read_file()

2018-01-24 Thread Lars-Peter Clausen
On 01/23/2018 11:53 PM, David Lechner wrote: > This fixes a possible NULL pointer dereference oops in > regmap_name_read_file() when the regmap does not have a device > associated with it. > > Signed-off-by: David Lechner > --- > drivers/base/regmap/regmap-debugfs.c | 6

Re: [PATCH 1/2] regmap: fix NULL pointer dereference in regmap_name_read_file()

2018-01-24 Thread Lars-Peter Clausen
On 01/23/2018 11:53 PM, David Lechner wrote: > This fixes a possible NULL pointer dereference oops in > regmap_name_read_file() when the regmap does not have a device > associated with it. > > Signed-off-by: David Lechner > --- > drivers/base/regmap/regmap-debugfs.c | 6 +- > 1 file

Re: [PATCH 1/2] regmap: fix NULL pointer dereference in regmap_name_read_file()

2018-01-24 Thread David Lechner
On 01/24/2018 05:30 AM, Mark Brown wrote: On Tue, Jan 23, 2018 at 04:53:42PM -0600, David Lechner wrote: This fixes a possible NULL pointer dereference oops in regmap_name_read_file() when the regmap does not have a device associated with it. How are you managing to get a regmap without a

Re: [PATCH 1/2] regmap: fix NULL pointer dereference in regmap_name_read_file()

2018-01-24 Thread David Lechner
On 01/24/2018 05:30 AM, Mark Brown wrote: On Tue, Jan 23, 2018 at 04:53:42PM -0600, David Lechner wrote: This fixes a possible NULL pointer dereference oops in regmap_name_read_file() when the regmap does not have a device associated with it. How are you managing to get a regmap without a

Re: [PATCH 1/2] regmap: fix NULL pointer dereference in regmap_name_read_file()

2018-01-24 Thread Mark Brown
On Tue, Jan 23, 2018 at 04:53:42PM -0600, David Lechner wrote: > This fixes a possible NULL pointer dereference oops in > regmap_name_read_file() when the regmap does not have a device > associated with it. How are you managing to get a regmap without a device associated with it? signature.asc

Re: [PATCH 1/2] regmap: fix NULL pointer dereference in regmap_name_read_file()

2018-01-24 Thread Mark Brown
On Tue, Jan 23, 2018 at 04:53:42PM -0600, David Lechner wrote: > This fixes a possible NULL pointer dereference oops in > regmap_name_read_file() when the regmap does not have a device > associated with it. How are you managing to get a regmap without a device associated with it? signature.asc

[PATCH 1/2] regmap: fix NULL pointer dereference in regmap_name_read_file()

2018-01-23 Thread David Lechner
This fixes a possible NULL pointer dereference oops in regmap_name_read_file() when the regmap does not have a device associated with it. Signed-off-by: David Lechner --- drivers/base/regmap/regmap-debugfs.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff

[PATCH 1/2] regmap: fix NULL pointer dereference in regmap_name_read_file()

2018-01-23 Thread David Lechner
This fixes a possible NULL pointer dereference oops in regmap_name_read_file() when the regmap does not have a device associated with it. Signed-off-by: David Lechner --- drivers/base/regmap/regmap-debugfs.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git