Re: [PATCH 1/2] regulator: s2mpa01: Don't check enable_shift before setting enable ramp rate

2014-04-02 Thread Mark Brown
On Fri, Mar 21, 2014 at 04:15:20PM +0800, Axel Lin wrote: > Current code misses updating the register when enable_shift is 0. > e.g. S2MPA01_BUCK4_RAMP_EN_SHIFT is 0. Applied, thanks. signature.asc Description: Digital signature

Re: [PATCH 1/2] regulator: s2mpa01: Don't check enable_shift before setting enable ramp rate

2014-04-02 Thread Mark Brown
On Fri, Mar 21, 2014 at 04:15:20PM +0800, Axel Lin wrote: Current code misses updating the register when enable_shift is 0. e.g. S2MPA01_BUCK4_RAMP_EN_SHIFT is 0. Applied, thanks. signature.asc Description: Digital signature

Re: [PATCH 1/2] regulator: s2mpa01: Don't check enable_shift before setting enable ramp rate

2014-04-01 Thread Sachin Kamat
Hi Axel, On 21 March 2014 13:45, Axel Lin wrote: > Current code misses updating the register when enable_shift is 0. > e.g. S2MPA01_BUCK4_RAMP_EN_SHIFT is 0. > > Signed-off-by: Axel Lin Acked-by: Sachin Kamat -- With warm regards, Sachin -- To unsubscribe from this list: send the line

Re: [PATCH 1/2] regulator: s2mpa01: Don't check enable_shift before setting enable ramp rate

2014-04-01 Thread Sachin Kamat
Hi Axel, On 21 March 2014 13:45, Axel Lin axel@ingics.com wrote: Current code misses updating the register when enable_shift is 0. e.g. S2MPA01_BUCK4_RAMP_EN_SHIFT is 0. Signed-off-by: Axel Lin axel@ingics.com Acked-by: Sachin Kamat sachin.ka...@linaro.org -- With warm regards,

Re: [PATCH 1/2] regulator: s2mpa01: Don't check enable_shift before setting enable ramp rate

2014-03-31 Thread Axel Lin
2014-03-21 16:15 GMT+08:00 Axel Lin : > Current code misses updating the register when enable_shift is 0. > e.g. S2MPA01_BUCK4_RAMP_EN_SHIFT is 0. Hi Sachin and Krzysztof, I think these 2 patches are bug fix. Any comment on this patch serial? Regards, Axel -- To unsubscribe from this list: send

Re: [PATCH 1/2] regulator: s2mpa01: Don't check enable_shift before setting enable ramp rate

2014-03-31 Thread Axel Lin
2014-03-21 16:15 GMT+08:00 Axel Lin axel@ingics.com: Current code misses updating the register when enable_shift is 0. e.g. S2MPA01_BUCK4_RAMP_EN_SHIFT is 0. Hi Sachin and Krzysztof, I think these 2 patches are bug fix. Any comment on this patch serial? Regards, Axel -- To unsubscribe

[PATCH 1/2] regulator: s2mpa01: Don't check enable_shift before setting enable ramp rate

2014-03-21 Thread Axel Lin
Current code misses updating the register when enable_shift is 0. e.g. S2MPA01_BUCK4_RAMP_EN_SHIFT is 0. Signed-off-by: Axel Lin --- drivers/regulator/s2mpa01.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/regulator/s2mpa01.c

[PATCH 1/2] regulator: s2mpa01: Don't check enable_shift before setting enable ramp rate

2014-03-21 Thread Axel Lin
Current code misses updating the register when enable_shift is 0. e.g. S2MPA01_BUCK4_RAMP_EN_SHIFT is 0. Signed-off-by: Axel Lin axel@ingics.com --- drivers/regulator/s2mpa01.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/regulator/s2mpa01.c