Robert Hancock wrote:
> Tejun Heo wrote:
>> Tejun Heo wrote:
>>> If so, can you please add that switching into register mode is okay as
>>> long as there's no other ADMA commands in flight and add
>>> WARN_ON((qc->flags & ATA_QCFLAG_RESULT_TF) && link->sactive)?
>>
>> More accurately,
Robert Hancock wrote:
Tejun Heo wrote:
Tejun Heo wrote:
If so, can you please add that switching into register mode is okay as
long as there's no other ADMA commands in flight and add
WARN_ON((qc-flags ATA_QCFLAG_RESULT_TF) link-sactive)?
More accurately, link-sactive test can be
Tejun Heo wrote:
Tejun Heo wrote:
If so, can you please add that switching into register mode is okay as
long as there's no other ADMA commands in flight and add
WARN_ON((qc->flags & ATA_QCFLAG_RESULT_TF) && link->sactive)?
More accurately, link->sactive test can be substituted with
Tejun Heo wrote:
Tejun Heo wrote:
If so, can you please add that switching into register mode is okay as
long as there's no other ADMA commands in flight and add
WARN_ON((qc-flags ATA_QCFLAG_RESULT_TF) link-sactive)?
More accurately, link-sactive test can be substituted with
Tejun Heo wrote:
> If so, can you please add that switching into register mode is okay as
> long as there's no other ADMA commands in flight and add
> WARN_ON((qc->flags & ATA_QCFLAG_RESULT_TF) && link->sactive)?
More accurately, link->sactive test can be substituted with
(ap->qc_allocated & ~(1
Hello,
Robert Hancock wrote:
> We need to run any DMA command with result taskfile requested in ADMA mode
> when the port is in ADMA mode, otherwise it may try to use the legacy DMA
> engine
> in ADMA mode which is not allowed. Enforce this with BUG_ON() since data
> corruption could potentially
Hello,
Robert Hancock wrote:
We need to run any DMA command with result taskfile requested in ADMA mode
when the port is in ADMA mode, otherwise it may try to use the legacy DMA
engine
in ADMA mode which is not allowed. Enforce this with BUG_ON() since data
corruption could potentially
Tejun Heo wrote:
If so, can you please add that switching into register mode is okay as
long as there's no other ADMA commands in flight and add
WARN_ON((qc-flags ATA_QCFLAG_RESULT_TF) link-sactive)?
More accurately, link-sactive test can be substituted with
(ap-qc_allocated ~(1 qc-tag)).
We need to run any DMA command with result taskfile requested in ADMA mode
when the port is in ADMA mode, otherwise it may try to use the legacy DMA engine
in ADMA mode which is not allowed. Enforce this with BUG_ON() since data
corruption could potentially result if this happened.
Signed-off-by:
We need to run any DMA command with result taskfile requested in ADMA mode
when the port is in ADMA mode, otherwise it may try to use the legacy DMA engine
in ADMA mode which is not allowed. Enforce this with BUG_ON() since data
corruption could potentially result if this happened.
Signed-off-by:
10 matches
Mail list logo