Re: [PATCH 1/2] ses: use scsi_is_sas_rphy instead of is_sas_attached

2016-08-15 Thread Johannes Thumshirn
On Mon, Aug 15, 2016 at 07:59:25AM -0700, James Bottomley wrote: > On Mon, 2016-08-15 at 16:40 +0200, Johannes Thumshirn wrote: > > On Mon, Aug 15, 2016 at 07:25:53AM -0700, James Bottomley wrote: > > > On Mon, 2016-08-15 at 22:11 +0800, kbuild test robot wrote: > > > > Hi Johannes, > > > > > > >

Re: [PATCH 1/2] ses: use scsi_is_sas_rphy instead of is_sas_attached

2016-08-15 Thread Johannes Thumshirn
On Mon, Aug 15, 2016 at 07:59:25AM -0700, James Bottomley wrote: > On Mon, 2016-08-15 at 16:40 +0200, Johannes Thumshirn wrote: > > On Mon, Aug 15, 2016 at 07:25:53AM -0700, James Bottomley wrote: > > > On Mon, 2016-08-15 at 22:11 +0800, kbuild test robot wrote: > > > > Hi Johannes, > > > > > > >

Re: [PATCH 1/2] ses: use scsi_is_sas_rphy instead of is_sas_attached

2016-08-15 Thread James Bottomley
On Mon, 2016-08-15 at 16:40 +0200, Johannes Thumshirn wrote: > On Mon, Aug 15, 2016 at 07:25:53AM -0700, James Bottomley wrote: > > On Mon, 2016-08-15 at 22:11 +0800, kbuild test robot wrote: > > > Hi Johannes, > > > > > > [auto build test ERROR on scsi/for-next] > > > [also build test ERROR on

Re: [PATCH 1/2] ses: use scsi_is_sas_rphy instead of is_sas_attached

2016-08-15 Thread James Bottomley
On Mon, 2016-08-15 at 16:40 +0200, Johannes Thumshirn wrote: > On Mon, Aug 15, 2016 at 07:25:53AM -0700, James Bottomley wrote: > > On Mon, 2016-08-15 at 22:11 +0800, kbuild test robot wrote: > > > Hi Johannes, > > > > > > [auto build test ERROR on scsi/for-next] > > > [also build test ERROR on

Re: [PATCH 1/2] ses: use scsi_is_sas_rphy instead of is_sas_attached

2016-08-15 Thread Johannes Thumshirn
On Mon, Aug 15, 2016 at 07:25:53AM -0700, James Bottomley wrote: > On Mon, 2016-08-15 at 22:11 +0800, kbuild test robot wrote: > > Hi Johannes, > > > > [auto build test ERROR on scsi/for-next] > > [also build test ERROR on v4.8-rc2 next-20160815] > > [if your patch is applied to the wrong git

Re: [PATCH 1/2] ses: use scsi_is_sas_rphy instead of is_sas_attached

2016-08-15 Thread Johannes Thumshirn
On Mon, Aug 15, 2016 at 07:25:53AM -0700, James Bottomley wrote: > On Mon, 2016-08-15 at 22:11 +0800, kbuild test robot wrote: > > Hi Johannes, > > > > [auto build test ERROR on scsi/for-next] > > [also build test ERROR on v4.8-rc2 next-20160815] > > [if your patch is applied to the wrong git

Re: [PATCH 1/2] ses: use scsi_is_sas_rphy instead of is_sas_attached

2016-08-15 Thread James Bottomley
On Mon, 2016-08-15 at 22:11 +0800, kbuild test robot wrote: > Hi Johannes, > > [auto build test ERROR on scsi/for-next] > [also build test ERROR on v4.8-rc2 next-20160815] > [if your patch is applied to the wrong git tree, please drop us a > note to help improve the system] This is happening

Re: [PATCH 1/2] ses: use scsi_is_sas_rphy instead of is_sas_attached

2016-08-15 Thread James Bottomley
On Mon, 2016-08-15 at 22:11 +0800, kbuild test robot wrote: > Hi Johannes, > > [auto build test ERROR on scsi/for-next] > [also build test ERROR on v4.8-rc2 next-20160815] > [if your patch is applied to the wrong git tree, please drop us a > note to help improve the system] This is happening

Re: [PATCH 1/2] ses: use scsi_is_sas_rphy instead of is_sas_attached

2016-08-15 Thread kbuild test robot
Hi Johannes, [auto build test ERROR on scsi/for-next] [also build test ERROR on v4.8-rc2 next-20160815] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH 1/2] ses: use scsi_is_sas_rphy instead of is_sas_attached

2016-08-15 Thread kbuild test robot
Hi Johannes, [auto build test ERROR on scsi/for-next] [also build test ERROR on v4.8-rc2 next-20160815] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

[PATCH 1/2] ses: use scsi_is_sas_rphy instead of is_sas_attached

2016-08-15 Thread Johannes Thumshirn
Use scsi_is_sas_rphy() instead of is_sas_attached() to decide whether we should obtain the SAS address from a scsi device or not. This will prevent us from tripping on the BUG_ON() in sas_sdev_to_rdev() if the rphy isn't attached to the SAS transport class, like it is with hpsa's logical devices.

[PATCH 1/2] ses: use scsi_is_sas_rphy instead of is_sas_attached

2016-08-15 Thread Johannes Thumshirn
Use scsi_is_sas_rphy() instead of is_sas_attached() to decide whether we should obtain the SAS address from a scsi device or not. This will prevent us from tripping on the BUG_ON() in sas_sdev_to_rdev() if the rphy isn't attached to the SAS transport class, like it is with hpsa's logical devices.