Re: [PATCH 1/2] spi: tegra20-sflash: cleanup wait_for_completion return handling

2015-02-02 Thread Laxman Dewangan
On Monday 02 February 2015 02:38 PM, Nicholas Mc Guire wrote: On Mon, 02 Feb 2015, Laxman Dewangan wrote: + if (WARN_ON(dma_timeout == 0)) { dev_err(tsd->dev, - "spi trasfer timeout, err %d\n", ret); +

Re: [PATCH 1/2] spi: tegra20-sflash: cleanup wait_for_completion return handling

2015-02-02 Thread Nicholas Mc Guire
On Mon, 02 Feb 2015, Laxman Dewangan wrote: > On Sunday 01 February 2015 06:30 PM, Nicholas Mc Guire wrote: >> return type of wait_for_completion_timeout is unsigned long not int, this >> patch adds an appropriate variable and fixes up the assignment. >> As the string in dev_err already states

Re: [PATCH 1/2] spi: tegra20-sflash: cleanup wait_for_completion return handling

2015-02-02 Thread Laxman Dewangan
On Sunday 01 February 2015 06:30 PM, Nicholas Mc Guire wrote: return type of wait_for_completion_timeout is unsigned long not int, this patch adds an appropriate variable and fixes up the assignment. As the string in dev_err already states "timeout" there is little point in printing the 0 here.

Re: [PATCH 1/2] spi: tegra20-sflash: cleanup wait_for_completion return handling

2015-02-02 Thread Laxman Dewangan
On Sunday 01 February 2015 06:30 PM, Nicholas Mc Guire wrote: return type of wait_for_completion_timeout is unsigned long not int, this patch adds an appropriate variable and fixes up the assignment. As the string in dev_err already states timeout there is little point in printing the 0 here.

Re: [PATCH 1/2] spi: tegra20-sflash: cleanup wait_for_completion return handling

2015-02-02 Thread Nicholas Mc Guire
On Mon, 02 Feb 2015, Laxman Dewangan wrote: On Sunday 01 February 2015 06:30 PM, Nicholas Mc Guire wrote: return type of wait_for_completion_timeout is unsigned long not int, this patch adds an appropriate variable and fixes up the assignment. As the string in dev_err already states timeout

Re: [PATCH 1/2] spi: tegra20-sflash: cleanup wait_for_completion return handling

2015-02-02 Thread Laxman Dewangan
On Monday 02 February 2015 02:38 PM, Nicholas Mc Guire wrote: On Mon, 02 Feb 2015, Laxman Dewangan wrote: + if (WARN_ON(dma_timeout == 0)) { dev_err(tsd-dev, - spi trasfer timeout, err %d\n, ret); +

[PATCH 1/2] spi: tegra20-sflash: cleanup wait_for_completion return handling

2015-02-01 Thread Nicholas Mc Guire
return type of wait_for_completion_timeout is unsigned long not int, this patch adds an appropriate variable and fixes up the assignment. As the string in dev_err already states "timeout" there is little point in printing the 0 here. Signed-off-by: Nicholas Mc Guire --- This patch was only

[PATCH 1/2] spi: tegra20-sflash: cleanup wait_for_completion return handling

2015-02-01 Thread Nicholas Mc Guire
return type of wait_for_completion_timeout is unsigned long not int, this patch adds an appropriate variable and fixes up the assignment. As the string in dev_err already states "timeout" there is little point in printing the 0 here. Signed-off-by: Nicholas Mc Guire --- This patch was only

[PATCH 1/2] spi: tegra20-sflash: cleanup wait_for_completion return handling

2015-02-01 Thread Nicholas Mc Guire
return type of wait_for_completion_timeout is unsigned long not int, this patch adds an appropriate variable and fixes up the assignment. As the string in dev_err already states timeout there is little point in printing the 0 here. Signed-off-by: Nicholas Mc Guire hof...@osadl.org --- This patch

[PATCH 1/2] spi: tegra20-sflash: cleanup wait_for_completion return handling

2015-02-01 Thread Nicholas Mc Guire
return type of wait_for_completion_timeout is unsigned long not int, this patch adds an appropriate variable and fixes up the assignment. As the string in dev_err already states timeout there is little point in printing the 0 here. Signed-off-by: Nicholas Mc Guire hof...@osadl.org --- This patch