Re: [PATCH 1/2] x86/events/amd/iommu: Fix sysfs type mismatch

2021-04-15 Thread Nathan Chancellor
On Thu, Apr 15, 2021 at 08:53:35AM +0100, Christoph Hellwig wrote: > On Wed, Apr 14, 2021 at 05:11:11PM -0700, Nathan Chancellor wrote: > > dev_attr_show() calls _iommu_event_show() via an indirect call but > > _iommu_event_show()'s type does not currently match the type of the > > show() member

Re: [PATCH 1/2] x86/events/amd/iommu: Fix sysfs type mismatch

2021-04-15 Thread Christoph Hellwig
On Wed, Apr 14, 2021 at 05:11:11PM -0700, Nathan Chancellor wrote: > dev_attr_show() calls _iommu_event_show() via an indirect call but > _iommu_event_show()'s type does not currently match the type of the > show() member in 'struct device_attribute', resulting in a Control Flow > Integrity

[PATCH 1/2] x86/events/amd/iommu: Fix sysfs type mismatch

2021-04-14 Thread Nathan Chancellor
dev_attr_show() calls _iommu_event_show() via an indirect call but _iommu_event_show()'s type does not currently match the type of the show() member in 'struct device_attribute', resulting in a Control Flow Integrity violation. $ cat /sys/devices/amd_iommu_1/events/mem_dte_hit csource=0x0a $