Re: [PATCH 1/2] x86: Fix typo preventing msr_set/clear_bit from having an effect

2014-05-09 Thread Borislav Petkov
On Fri, May 09, 2014 at 12:39:42PM +0200, Andres Freund wrote: > It got caught before the release, so all is well... Yeah. > Actually rather surprised it only causes relatively minor problems; > i.e. still boots. Well, I did switch only a couple of sites in intel.c, maybe you got lucky... (if

Re: [PATCH 1/2] x86: Fix typo preventing msr_set/clear_bit from having an effect

2014-05-09 Thread Andres Freund
Hi, On 2014-05-09 09:54:52 +0200, Borislav Petkov wrote: > On Fri, May 09, 2014 at 03:29:16AM +0200, Andres Freund wrote: > > Due to a typo the msr accessor function introduced in > > 22085a66c2fab6cf9b9393c056a3600a6b4735de didn't have any lasting > > effects because they accidentally wrote the

Re: [PATCH 1/2] x86: Fix typo preventing msr_set/clear_bit from having an effect

2014-05-09 Thread Borislav Petkov
On Fri, May 09, 2014 at 03:29:16AM +0200, Andres Freund wrote: > Due to a typo the msr accessor function introduced in > 22085a66c2fab6cf9b9393c056a3600a6b4735de didn't have any lasting > effects because they accidentally wrote the old value back. > > After

Re: [PATCH 1/2] x86: Fix typo preventing msr_set/clear_bit from having an effect

2014-05-09 Thread Borislav Petkov
On Fri, May 09, 2014 at 03:29:16AM +0200, Andres Freund wrote: Due to a typo the msr accessor function introduced in 22085a66c2fab6cf9b9393c056a3600a6b4735de didn't have any lasting effects because they accidentally wrote the old value back. After c0a639ad0bc6b178b46996bd1f821a04643e2bde

Re: [PATCH 1/2] x86: Fix typo preventing msr_set/clear_bit from having an effect

2014-05-09 Thread Andres Freund
Hi, On 2014-05-09 09:54:52 +0200, Borislav Petkov wrote: On Fri, May 09, 2014 at 03:29:16AM +0200, Andres Freund wrote: Due to a typo the msr accessor function introduced in 22085a66c2fab6cf9b9393c056a3600a6b4735de didn't have any lasting effects because they accidentally wrote the old

Re: [PATCH 1/2] x86: Fix typo preventing msr_set/clear_bit from having an effect

2014-05-09 Thread Borislav Petkov
On Fri, May 09, 2014 at 12:39:42PM +0200, Andres Freund wrote: It got caught before the release, so all is well... Yeah. Actually rather surprised it only causes relatively minor problems; i.e. still boots. Well, I did switch only a couple of sites in intel.c, maybe you got lucky... (if that

[PATCH 1/2] x86: Fix typo preventing msr_set/clear_bit from having an effect

2014-05-08 Thread Andres Freund
Due to a typo the msr accessor function introduced in 22085a66c2fab6cf9b9393c056a3600a6b4735de didn't have any lasting effects because they accidentally wrote the old value back. After c0a639ad0bc6b178b46996bd1f821a04643e2bde this at the very least this causes cpuid limits not to be lifted on

[PATCH 1/2] x86: Fix typo preventing msr_set/clear_bit from having an effect

2014-05-08 Thread Andres Freund
Due to a typo the msr accessor function introduced in 22085a66c2fab6cf9b9393c056a3600a6b4735de didn't have any lasting effects because they accidentally wrote the old value back. After c0a639ad0bc6b178b46996bd1f821a04643e2bde this at the very least this causes cpuid limits not to be lifted on