Re: [PATCH 1/2] xtensa: remove nargs from __SYSCALL

2019-01-03 Thread Firoz Khan
Hi Max, On Fri, 4 Jan 2019 at 11:25, Max Filippov wrote: > On Thu, Jan 3, 2019 at 9:17 PM Firoz Khan wrote: > > On Fri, 4 Jan 2019 at 08:28, Max Filippov wrote: > > > On Wed, Jan 2, 2019 at 7:29 AM Firoz Khan wrote: > > This was intentional as I was trying compile other one architecture with

Re: [PATCH 1/2] xtensa: remove nargs from __SYSCALL

2019-01-03 Thread Max Filippov
On Thu, Jan 3, 2019 at 9:17 PM Firoz Khan wrote: > On Fri, 4 Jan 2019 at 08:28, Max Filippov wrote: > > On Wed, Jan 2, 2019 at 7:29 AM Firoz Khan wrote: > > > while [ $t_nxt -lt $t_nr ]; do > > > - printf "__SYSCALL(%s, sys_ni_syscall, )\n" "${t_nxt}" > > > +

Re: [PATCH 1/2] xtensa: remove nargs from __SYSCALL

2019-01-03 Thread Firoz Khan
Hi Max, Thanks for your reply. On Fri, 4 Jan 2019 at 08:28, Max Filippov wrote: > On Wed, Jan 2, 2019 at 7:29 AM Firoz Khan wrote: > > while [ $t_nxt -lt $t_nr ]; do > > - printf "__SYSCALL(%s, sys_ni_syscall, )\n" "${t_nxt}" > > + printf

Re: [PATCH 1/2] xtensa: remove nargs from __SYSCALL

2019-01-03 Thread Max Filippov
On Wed, Jan 2, 2019 at 7:29 AM Firoz Khan wrote: > > The __SYSCALL macro's arguments are system call number, > system call entry name and number of arguments for the > system call. > > Argument- nargs in __SYSCALL(nr, entry, nargs) is neither > calculated nor used anywhere. So it would be better

[PATCH 1/2] xtensa: remove nargs from __SYSCALL

2019-01-02 Thread Firoz Khan
The __SYSCALL macro's arguments are system call number, system call entry name and number of arguments for the system call. Argument- nargs in __SYSCALL(nr, entry, nargs) is neither calculated nor used anywhere. So it would be better to keep the implementaion as __SYSCALL(nr, entry). This will