Re: [PATCH 1/2 v8] ASoC: dwc: Add PIO PCM extension

2016-06-07 Thread Mark Brown
On Mon, May 30, 2016 at 10:53:15AM +0100, Jose Abreu wrote: A few small things but this looks basically fine. > + if (isr[i] & 0x33) > + irq_valid = true; This checks for a mask of 0x33 but... > + > + /* > + * Check if TX fifo is empty.

Re: [PATCH 1/2 v8] ASoC: dwc: Add PIO PCM extension

2016-06-07 Thread Mark Brown
On Mon, May 30, 2016 at 10:53:15AM +0100, Jose Abreu wrote: A few small things but this looks basically fine. > + if (isr[i] & 0x33) > + irq_valid = true; This checks for a mask of 0x33 but... > + > + /* > + * Check if TX fifo is empty.

[PATCH 1/2 v8] ASoC: dwc: Add PIO PCM extension

2016-05-30 Thread Jose Abreu
A PCM extension was added to I2S driver so that audio samples are transferred using PIO mode. The PCM supports two channels @ 16 or 32 bits with rates 32k, 44.1k and 48k. Although the mainline I2S driver uses ALSA DMA engine the I2S controller can be built without DMA support, therefore this is

[PATCH 1/2 v8] ASoC: dwc: Add PIO PCM extension

2016-05-30 Thread Jose Abreu
A PCM extension was added to I2S driver so that audio samples are transferred using PIO mode. The PCM supports two channels @ 16 or 32 bits with rates 32k, 44.1k and 48k. Although the mainline I2S driver uses ALSA DMA engine the I2S controller can be built without DMA support, therefore this is