Re: [PATCH 1/3] Introduce FW_INFO* functions and messages

2013-12-16 Thread Joe Perches
On Mon, 2013-12-16 at 08:01 -0500, Prarit Bhargava wrote: > Sorry everyone, I was out on PTO for the past few weeks. > > > On 12/06/2013 07:30 AM, Matt Fleming wrote: > > On Thu, 05 Dec, at 07:55:03AM, Joe Perches wrote: > >> On Thu, 2013-12-05 at 11:30 +, Matt Fleming wrote: > >>> On Wed,

Re: [PATCH 1/3] Introduce FW_INFO* functions and messages

2013-12-16 Thread Prarit Bhargava
Sorry everyone, I was out on PTO for the past few weeks. On 12/06/2013 07:30 AM, Matt Fleming wrote: > On Thu, 05 Dec, at 07:55:03AM, Joe Perches wrote: >> On Thu, 2013-12-05 at 11:30 +, Matt Fleming wrote: >>> On Wed, 04 Dec, at 07:22:57PM, Arnd Bergmann wrote: The other part I

Re: [PATCH 1/3] Introduce FW_INFO* functions and messages

2013-12-16 Thread Prarit Bhargava
Sorry everyone, I was out on PTO for the past few weeks. On 12/06/2013 07:30 AM, Matt Fleming wrote: On Thu, 05 Dec, at 07:55:03AM, Joe Perches wrote: On Thu, 2013-12-05 at 11:30 +, Matt Fleming wrote: On Wed, 04 Dec, at 07:22:57PM, Arnd Bergmann wrote: The other part I noticed about

Re: [PATCH 1/3] Introduce FW_INFO* functions and messages

2013-12-16 Thread Joe Perches
On Mon, 2013-12-16 at 08:01 -0500, Prarit Bhargava wrote: Sorry everyone, I was out on PTO for the past few weeks. On 12/06/2013 07:30 AM, Matt Fleming wrote: On Thu, 05 Dec, at 07:55:03AM, Joe Perches wrote: On Thu, 2013-12-05 at 11:30 +, Matt Fleming wrote: On Wed, 04 Dec, at

Re: [PATCH 1/3] Introduce FW_INFO* functions and messages

2013-12-06 Thread Matt Fleming
On Thu, 05 Dec, at 07:55:03AM, Joe Perches wrote: > On Thu, 2013-12-05 at 11:30 +, Matt Fleming wrote: > > On Wed, 04 Dec, at 07:22:57PM, Arnd Bergmann wrote: > > > The other part I noticed about this particular patchset is that it's > > > not really "firmware" as such, but specifically PC

Re: [PATCH 1/3] Introduce FW_INFO* functions and messages

2013-12-06 Thread Matt Fleming
On Thu, 05 Dec, at 07:55:03AM, Joe Perches wrote: On Thu, 2013-12-05 at 11:30 +, Matt Fleming wrote: On Wed, 04 Dec, at 07:22:57PM, Arnd Bergmann wrote: The other part I noticed about this particular patchset is that it's not really firmware as such, but specifically PC wiht ACPI that

Re: [PATCH 1/3] Introduce FW_INFO* functions and messages

2013-12-05 Thread Joe Perches
On Thu, 2013-12-05 at 11:30 +, Matt Fleming wrote: > On Wed, 04 Dec, at 07:22:57PM, Arnd Bergmann wrote: > > The other part I noticed about this particular patchset is that it's > > not really "firmware" as such, but specifically PC wiht ACPI that > > gets covered here. So rather than

Re: [PATCH 1/3] Introduce FW_INFO* functions and messages

2013-12-05 Thread Matt Fleming
On Wed, 04 Dec, at 07:22:57PM, Arnd Bergmann wrote: > The other part I noticed about this particular patchset is that it's > not really "firmware" as such, but specifically PC wiht ACPI that > gets covered here. So rather than generalizing the code, another > option would be to narrow down the

Re: [PATCH 1/3] Introduce FW_INFO* functions and messages

2013-12-05 Thread Matt Fleming
On Wed, 04 Dec, at 07:22:57PM, Arnd Bergmann wrote: The other part I noticed about this particular patchset is that it's not really firmware as such, but specifically PC wiht ACPI that gets covered here. So rather than generalizing the code, another option would be to narrow down the scope and

Re: [PATCH 1/3] Introduce FW_INFO* functions and messages

2013-12-05 Thread Joe Perches
On Thu, 2013-12-05 at 11:30 +, Matt Fleming wrote: On Wed, 04 Dec, at 07:22:57PM, Arnd Bergmann wrote: The other part I noticed about this particular patchset is that it's not really firmware as such, but specifically PC wiht ACPI that gets covered here. So rather than generalizing the

Re: [PATCH 1/3] Introduce FW_INFO* functions and messages

2013-12-04 Thread Arnd Bergmann
On Tuesday 03 December 2013, Andrew Morton wrote: > I do wonder if it all should be generalised a bit - it creates a bunch > of infrastructure which is specific to system firmware issues, but > what's so special about firmware? Why can't I use this infrastructure > to log netdev errors or acpi

Re: [PATCH 1/3] Introduce FW_INFO* functions and messages

2013-12-04 Thread Joe Perches
On Wed, 2013-12-04 at 06:51 -0500, Prarit Bhargava wrote: > > On 12/03/2013 04:21 PM, Andrew Morton wrote: > > On Mon, 2 Dec 2013 10:19:37 -0500 Prarit Bhargava > > wrote: > > A slight simplification: > > > >> +static inline char *dump_hadware_arch_desc(void) > >> +{ > >> + return NULL; > >>

Re: [PATCH 1/3] Introduce FW_INFO* functions and messages

2013-12-04 Thread Prarit Bhargava
On 12/03/2013 04:21 PM, Andrew Morton wrote: > On Mon, 2 Dec 2013 10:19:37 -0500 Prarit Bhargava wrote: > A slight simplification: > >> +static inline char *dump_hadware_arch_desc(void) >> +{ >> +return NULL; >> +} > > return "unavailable"; > >> +void warn_slowpath_fmt_dev(const

Re: [PATCH 1/3] Introduce FW_INFO* functions and messages

2013-12-04 Thread Prarit Bhargava
On 12/03/2013 04:21 PM, Andrew Morton wrote: On Mon, 2 Dec 2013 10:19:37 -0500 Prarit Bhargava pra...@redhat.com wrote: A slight simplification: +static inline char *dump_hadware_arch_desc(void) +{ +return NULL; +} return unavailable; +void warn_slowpath_fmt_dev(const

Re: [PATCH 1/3] Introduce FW_INFO* functions and messages

2013-12-04 Thread Joe Perches
On Wed, 2013-12-04 at 06:51 -0500, Prarit Bhargava wrote: On 12/03/2013 04:21 PM, Andrew Morton wrote: On Mon, 2 Dec 2013 10:19:37 -0500 Prarit Bhargava pra...@redhat.com wrote: A slight simplification: +static inline char *dump_hadware_arch_desc(void) +{ + return NULL; +}

Re: [PATCH 1/3] Introduce FW_INFO* functions and messages

2013-12-04 Thread Arnd Bergmann
On Tuesday 03 December 2013, Andrew Morton wrote: I do wonder if it all should be generalised a bit - it creates a bunch of infrastructure which is specific to system firmware issues, but what's so special about firmware? Why can't I use this infrastructure to log netdev errors or acpi errors

Re: [PATCH 1/3] Introduce FW_INFO* functions and messages

2013-12-03 Thread Andrew Morton
On Mon, 2 Dec 2013 10:19:37 -0500 Prarit Bhargava wrote: > Logging and tracking firmware bugs in the kernel has long been an issue > for system administrators. The current kernel does not have a good > uniform method of reporting firmware bugs and the code in the kernel is a > mix of printk's

Re: [PATCH 1/3] Introduce FW_INFO* functions and messages

2013-12-03 Thread Andrew Morton
On Mon, 2 Dec 2013 10:19:37 -0500 Prarit Bhargava pra...@redhat.com wrote: Logging and tracking firmware bugs in the kernel has long been an issue for system administrators. The current kernel does not have a good uniform method of reporting firmware bugs and the code in the kernel is a mix

[PATCH 1/3] Introduce FW_INFO* functions and messages

2013-12-02 Thread Prarit Bhargava
Logging and tracking firmware bugs in the kernel has long been an issue for system administrators. The current kernel does not have a good uniform method of reporting firmware bugs and the code in the kernel is a mix of printk's and WARN_ONs. This causes problems for both system administrators

[PATCH 1/3] Introduce FW_INFO* functions and messages

2013-12-02 Thread Prarit Bhargava
Logging and tracking firmware bugs in the kernel has long been an issue for system administrators. The current kernel does not have a good uniform method of reporting firmware bugs and the code in the kernel is a mix of printk's and WARN_ONs. This causes problems for both system administrators